[S] Change in dart/sdk[main]: Avoid using List<int>, prefer Uint8List

0 views
Skip to first unread message

Jonas Jensen (Gerrit)

unread,
Jun 23, 2026, 4:27:34 AM (21 hours ago) Jun 23
to Sigurd Meldgaard, rev...@dartlang.org
Attention needed from Sigurd Meldgaard

Jonas Jensen voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Sigurd Meldgaard
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I8b11e181b8f83c90b04d14f0255c1f5f441da10a
Gerrit-Change-Number: 516241
Gerrit-PatchSet: 1
Gerrit-Owner: Jonas Jensen <jon...@google.com>
Gerrit-Reviewer: Jonas Jensen <jon...@google.com>
Gerrit-Reviewer: Sigurd Meldgaard <sig...@google.com>
Gerrit-Attention: Sigurd Meldgaard <sig...@google.com>
Gerrit-Comment-Date: Tue, 23 Jun 2026 08:27:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Sigurd Meldgaard (Gerrit)

unread,
Jun 23, 2026, 4:30:18 AM (21 hours ago) Jun 23
to Jonas Jensen, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Jonas Jensen

Sigurd Meldgaard voted and added 1 comment

Votes added by Sigurd Meldgaard

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Sigurd Meldgaard . resolved

Could we make the commit message a bit more specific? Mention dartpad_worker perhaps? Perhaps say if this improves performance significantly

Open in Gerrit

Related details

Attention is currently required from:
  • Jonas Jensen
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I8b11e181b8f83c90b04d14f0255c1f5f441da10a
Gerrit-Change-Number: 516241
Gerrit-PatchSet: 1
Gerrit-Owner: Jonas Jensen <jon...@google.com>
Gerrit-Reviewer: Jonas Jensen <jon...@google.com>
Gerrit-Reviewer: Sigurd Meldgaard <sig...@google.com>
Gerrit-Attention: Jonas Jensen <jon...@google.com>
Gerrit-Comment-Date: Tue, 23 Jun 2026 08:30:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Sigurd Meldgaard (Gerrit)

unread,
Jun 23, 2026, 4:30:29 AM (21 hours ago) Jun 23
to Jonas Jensen, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Jonas Jensen

Sigurd Meldgaard voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jonas Jensen
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I8b11e181b8f83c90b04d14f0255c1f5f441da10a
Gerrit-Change-Number: 516241
Gerrit-PatchSet: 1
Gerrit-Owner: Jonas Jensen <jon...@google.com>
Gerrit-Reviewer: Jonas Jensen <jon...@google.com>
Gerrit-Reviewer: Sigurd Meldgaard <sig...@google.com>
Gerrit-Attention: Jonas Jensen <jon...@google.com>
Gerrit-Comment-Date: Tue, 23 Jun 2026 08:30:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Jonas Jensen (Gerrit)

unread,
Jun 23, 2026, 4:33:05 AM (21 hours ago) Jun 23
to Sigurd Meldgaard, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Sigurd Meldgaard

Jonas Jensen voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Sigurd Meldgaard
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I8b11e181b8f83c90b04d14f0255c1f5f441da10a
Gerrit-Change-Number: 516241
Gerrit-PatchSet: 1
Gerrit-Owner: Jonas Jensen <jon...@google.com>
Gerrit-Reviewer: Jonas Jensen <jon...@google.com>
Gerrit-Reviewer: Sigurd Meldgaard <sig...@google.com>
Gerrit-Attention: Sigurd Meldgaard <sig...@google.com>
Gerrit-Comment-Date: Tue, 23 Jun 2026 08:32:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
Jun 23, 2026, 5:05:09 AM (20 hours ago) Jun 23
to Jonas Jensen, Sigurd Meldgaard, rev...@dartlang.org

dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
Avoid using List<int>, prefer Uint8List
Change-Id: I8b11e181b8f83c90b04d14f0255c1f5f441da10a
Commit-Queue: Jonas Jensen <jon...@google.com>
Reviewed-by: Sigurd Meldgaard <sig...@google.com>
Auto-Submit: Jonas Jensen <jon...@google.com>
Files:
  • M pkg/dartpad_worker/lib/src/resource_provider/resource_provider_file.dart
Change size: S
Delta: 1 file changed, 7 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Sigurd Meldgaard
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I8b11e181b8f83c90b04d14f0255c1f5f441da10a
Gerrit-Change-Number: 516241
Gerrit-PatchSet: 2
Gerrit-Owner: Jonas Jensen <jon...@google.com>
Gerrit-Reviewer: Jonas Jensen <jon...@google.com>
Gerrit-Reviewer: Sigurd Meldgaard <sig...@google.com>
open
diffy
satisfied_requirement

Stephen Adams (Gerrit)

unread,
Jun 23, 2026, 1:21:11 PM (12 hours ago) Jun 23
to Jonas Jensen, dart-...@luci-project-accounts.iam.gserviceaccount.com, Sigurd Meldgaard, rev...@dartlang.org

Stephen Adams added 1 comment

Patchset-level comments
Sigurd Meldgaard . resolved

Could we make the commit message a bit more specific? Mention dartpad_worker perhaps? Perhaps say if this improves performance significantly

Stephen Adams

I would have found this useful - I needlessly looked into the change because it was worded so generally

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I8b11e181b8f83c90b04d14f0255c1f5f441da10a
Gerrit-Change-Number: 516241
Gerrit-PatchSet: 2
Gerrit-Owner: Jonas Jensen <jon...@google.com>
Gerrit-Reviewer: Jonas Jensen <jon...@google.com>
Gerrit-Reviewer: Sigurd Meldgaard <sig...@google.com>
Gerrit-CC: Stephen Adams <s...@google.com>
Gerrit-Comment-Date: Tue, 23 Jun 2026 17:21:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sigurd Meldgaard <sig...@google.com>
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages