[S] Change in dart/sdk[main]: Avoid using List<int>, prefer Uint8List
0 views
Skip to first unread message
Jonas Jensen (Gerrit)
Jun 23, 2026, 4:27:34 AM (21 hours ago) Jun 23
to Sigurd Meldgaard, rev...@dartlang.org
Attention needed from Sigurd Meldgaard
Jonas Jensen voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Sigurd Meldgaard
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sigurd Meldgaard (Gerrit)
Jun 23, 2026, 4:30:18 AM (21 hours ago) Jun 23
to Jonas Jensen, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Jonas Jensen
Sigurd Meldgaard voted and added 1 comment![]( "Open in Gerrit")
Votes added by Sigurd Meldgaard
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Sigurd Meldgaard . resolved
Could we make the commit message a bit more specific? Mention dartpad_worker perhaps? Perhaps say if this improves performance significantly
Related details
Attention is currently required from:
- Jonas Jensen
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sigurd Meldgaard (Gerrit)
Jun 23, 2026, 4:30:29 AM (21 hours ago) Jun 23
to Jonas Jensen, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Jonas Jensen
Sigurd Meldgaard voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Jonas Jensen
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jonas Jensen (Gerrit)
Jun 23, 2026, 4:33:05 AM (21 hours ago) Jun 23
to Sigurd Meldgaard, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Sigurd Meldgaard
Jonas Jensen voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Sigurd Meldgaard
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 23, 2026, 5:05:09 AM (20 hours ago) Jun 23
to Jonas Jensen, Sigurd Meldgaard, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Avoid using List<int>, prefer Uint8List
Change-Id: I8b11e181b8f83c90b04d14f0255c1f5f441da10a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/516241
Commit-Queue: Jonas Jensen <jon...@google.com>
Reviewed-by: Sigurd Meldgaard <sig...@google.com>
Auto-Submit: Jonas Jensen <jon...@google.com>
Files:
- M pkg/dartpad_worker/lib/src/resource_provider/resource_provider_file.dart
Change size: S
Delta: 1 file changed, 7 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Sigurd Meldgaard
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Stephen Adams (Gerrit)
Jun 23, 2026, 1:21:11 PM (12 hours ago) Jun 23
to Jonas Jensen, dart-...@luci-project-accounts.iam.gserviceaccount.com, Sigurd Meldgaard, rev...@dartlang.org
Stephen Adams added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Sigurd Meldgaard . resolved
Could we make the commit message a bit more specific? Mention dartpad_worker perhaps? Perhaps say if this improves performance significantly
Stephen Adams
I would have found this useful - I needlessly looked into the change because it was worded so generally
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages