[M] Change in dart/sdk[main]: [CFE] Strong_suite fuzzing wraps in part; Fix crashes because of wron...

0 views
Skip to first unread message

Johnni Winther (Gerrit)

unread,
Aug 8, 2025, 9:21:43 AM8/8/25
to Jens Johansen, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Jens Johansen

Johnni Winther voted and added 1 comment

Votes added by Johnni Winther

Code-Review+1

1 comment

File pkg/front_end/test/testing/suite.dart
Line 1138, Patchset 1 (Latest):part of "${newEntryUri}";
Johnni Winther . unresolved

I guess this only works to the extent that we can handle imports/exports in parts for the still experimental enhanced parts features.

Open in Gerrit

Related details

Attention is currently required from:
  • Jens Johansen
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I107db0517c066db2aa3084a0e383858a2b6a37bf
Gerrit-Change-Number: 444420
Gerrit-PatchSet: 1
Gerrit-Owner: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Attention: Jens Johansen <je...@google.com>
Gerrit-Comment-Date: Fri, 08 Aug 2025 13:21:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Jens Johansen (Gerrit)

unread,
Aug 8, 2025, 9:23:31 AM8/8/25
to Johnni Winther, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org

Jens Johansen voted and added 1 comment

Votes added by Jens Johansen

Commit-Queue+2

1 comment

File pkg/front_end/test/testing/suite.dart
Line 1138, Patchset 1 (Latest):part of "${newEntryUri}";
Johnni Winther . resolved

I guess this only works to the extent that we can handle imports/exports in parts for the still experimental enhanced parts features.

Jens Johansen

I was about to skip if there were imports/exports etc --- but then I realized that I only want to test for it crashing or not, and then I didn't.

There might be some crashes that will not be found, sure.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I107db0517c066db2aa3084a0e383858a2b6a37bf
Gerrit-Change-Number: 444420
Gerrit-PatchSet: 1
Gerrit-Owner: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Fri, 08 Aug 2025 13:23:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Johnni Winther <johnni...@google.com>
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Aug 8, 2025, 9:23:49 AM8/8/25
to Jens Johansen, Johnni Winther, dart-fe-te...@google.com, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
[CFE] Strong_suite fuzzing wraps in part; Fix crashes because of wrong uri

First crash found while doing work on the messages_suite that already
wraps in part.
Change-Id: I107db0517c066db2aa3084a0e383858a2b6a37bf
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Jens Johansen <je...@google.com>
Files:
  • M pkg/front_end/lib/src/kernel/kernel_helper.dart
  • M pkg/front_end/lib/src/type_inference/inference_visitor_base.dart
  • M pkg/front_end/test/testing/suite.dart
  • A pkg/front_end/testcases/super_parameters/default_values_2.dart
  • A pkg/front_end/testcases/super_parameters/default_values_2.dart.strong.expect
  • A pkg/front_end/testcases/super_parameters/default_values_2.dart.strong.modular.expect
  • A pkg/front_end/testcases/super_parameters/default_values_2.dart.strong.outline.expect
  • A pkg/front_end/testcases/super_parameters/default_values_2.dart.strong.transformed.expect
  • A pkg/front_end/testcases/super_parameters/default_values_2.dart.textual_outline.expect
  • A pkg/front_end/testcases/super_parameters/default_values_2.dart.textual_outline_modelled.expect
  • A pkg/front_end/testcases/super_parameters/default_values_2_lib.dart
Change size: M
Delta: 11 files changed, 230 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Johnni Winther
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I107db0517c066db2aa3084a0e383858a2b6a37bf
Gerrit-Change-Number: 444420
Gerrit-PatchSet: 2
Gerrit-Owner: Jens Johansen <je...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages