[L] Change in dart/sdk[main]: Control flow optimizations

0 views
Skip to first unread message

Alexander Markov (Gerrit)

unread,
Dec 9, 2025, 12:17:09 PM12/9/25
to Alexander Markov, Slava Egorov, Nicholas Shahan, Nate Biggs, Alexander Aprelev, Tess Strickland, Stephen Adams, Commit Queue, rev...@dartlang.org
Attention needed from Slava Egorov

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Slava Egorov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ie82fd2e09a0ba3e133abc65819a45e0fc3d3812a
Gerrit-Change-Number: 467120
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-CC: Alexander Aprelev <a...@google.com>
Gerrit-CC: Nate Biggs <nate...@google.com>
Gerrit-CC: Nicholas Shahan <nsh...@google.com>
Gerrit-CC: Stephen Adams <s...@google.com>
Gerrit-CC: Tess Strickland <sstr...@google.com>
Gerrit-Attention: Slava Egorov <veg...@google.com>
Gerrit-Comment-Date: Tue, 09 Dec 2025 17:17:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Slava Egorov (Gerrit)

unread,
Dec 10, 2025, 7:59:05 AM12/10/25
to Alexander Markov, Nicholas Shahan, Nate Biggs, Alexander Aprelev, Tess Strickland, Stephen Adams, Commit Queue, rev...@dartlang.org
Attention needed from Alexander Markov

Slava Egorov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Markov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ie82fd2e09a0ba3e133abc65819a45e0fc3d3812a
Gerrit-Change-Number: 467120
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-CC: Alexander Aprelev <a...@google.com>
Gerrit-CC: Nate Biggs <nate...@google.com>
Gerrit-CC: Nicholas Shahan <nsh...@google.com>
Gerrit-CC: Stephen Adams <s...@google.com>
Gerrit-CC: Tess Strickland <sstr...@google.com>
Gerrit-Attention: Alexander Markov <alexm...@google.com>
Gerrit-Comment-Date: Wed, 10 Dec 2025 12:59:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Alexander Markov (Gerrit)

unread,
Dec 10, 2025, 8:51:38 AM12/10/25
to Alexander Markov, Slava Egorov, Nicholas Shahan, Nate Biggs, Alexander Aprelev, Tess Strickland, Stephen Adams, Commit Queue, rev...@dartlang.org

Alexander Markov voted and added 1 comment

Votes added by Alexander Markov

Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Alexander Markov . resolved

Thank you, Slava!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ie82fd2e09a0ba3e133abc65819a45e0fc3d3812a
Gerrit-Change-Number: 467120
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-CC: Alexander Aprelev <a...@google.com>
Gerrit-CC: Nate Biggs <nate...@google.com>
Gerrit-CC: Nicholas Shahan <nsh...@google.com>
Gerrit-CC: Stephen Adams <s...@google.com>
Gerrit-CC: Tess Strickland <sstr...@google.com>
Gerrit-Comment-Date: Wed, 10 Dec 2025 13:51:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Dec 10, 2025, 8:51:53 AM12/10/25
to Alexander Markov, Slava Egorov, Nicholas Shahan, Nate Biggs, Alexander Aprelev, Tess Strickland, Stephen Adams, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
Control flow optimizations

Add a pass to remove redundancies in the control flow such as empty
basic blocks, useless branches and gotos.
Change-Id: Ie82fd2e09a0ba3e133abc65819a45e0fc3d3812a
Reviewed-by: Slava Egorov <veg...@google.com>
Commit-Queue: Alexander Markov <alexm...@google.com>
Files:
  • A pkg/cfg/lib/passes/control_flow_optimizations.dart
  • M pkg/cfg/test/ir_test.dart
  • M pkg/cfg/testcases/constant_propagation.dart.expect
  • M pkg/cfg/testcases/dominators.dart.expect
  • M pkg/cfg/testcases/loops.dart.expect
  • M pkg/cfg/testcases/simplification.dart.expect
  • M pkg/cfg/testcases/statements.dart.expect
  • M pkg/cfg/testcases/unreachable_ast.dart.expect
  • M pkg/cfg/testcases/value_numbering.dart.expect
Change size: L
Delta: 9 files changed, 178 insertions(+), 142 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Slava Egorov
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ie82fd2e09a0ba3e133abc65819a45e0fc3d3812a
Gerrit-Change-Number: 467120
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-CC: Alexander Aprelev <a...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages