[XS] Change in dart/sdk[main]: [co19] Roll co19 to 911100f1901c7e6de8ba5c8c290a0a3b7e33a997

0 views
Skip to first unread message

Sergey Grekhov (Gerrit)

unread,
Dec 19, 2025, 3:22:11 AM (3 days ago) Dec 19
to Alexander Thomas, Erik Ernst, rev...@dartlang.org
Attention needed from Alexander Thomas and Erik Ernst

Sergey Grekhov has uploaded the change for review

Sergey Grekhov would like Alexander Thomas and Erik Ernst to review this change.

Commit message

[co19] Roll co19 to 911100f1901c7e6de8ba5c8c290a0a3b7e33a997

2025-12-18 sgrek...@gmail.com dart-lang/co19#3182. Add more augmenting getters/setters tests (dart-lang/co19#3448)
2025-12-17 sgrek...@gmail.com dart-lang/co19#3182. Add more tests for augmenting external getters and setters (dart-lang/co19#3447)
2025-12-17 sgrek...@gmail.com dart-lang/co19#3182. Add more augmenting getters/setters tests (dart-lang/co19#3446)
2025-12-16 sgrek...@gmail.com dart-lang/co19#3182. Add more tests for augmenting getters (dart-lang/co19#3444)
2025-12-12 sgrek...@gmail.com dart-lang/co19#3182. Replace augmenting getter tests (dart-lang/co19#3443)

R=at...@google.com, eer...@google.com
Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try
Change-Id: I04af7a7a61611fc599d885be641a2aecd71fa9f5

Change information

Files:
  • M DEPS
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Thomas
  • Erik Ernst
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I04af7a7a61611fc599d885be641a2aecd71fa9f5
Gerrit-Change-Number: 469140
Gerrit-PatchSet: 1
Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Reviewer: Alexander Thomas <at...@google.com>
Gerrit-Reviewer: Erik Ernst <eer...@google.com>
Gerrit-Reviewer: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Attention: Alexander Thomas <at...@google.com>
Gerrit-Attention: Erik Ernst <eer...@google.com>
unsatisfied_requirement
open
diffy

Erik Ernst (Gerrit)

unread,
Dec 19, 2025, 3:27:01 AM (3 days ago) Dec 19
to Sergey Grekhov, Commit Queue, Alexander Thomas, rev...@dartlang.org
Attention needed from Alexander Thomas and Sergey Grekhov

Erik Ernst voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Thomas
  • Sergey Grekhov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I04af7a7a61611fc599d885be641a2aecd71fa9f5
Gerrit-Change-Number: 469140
Gerrit-PatchSet: 1
Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Reviewer: Alexander Thomas <at...@google.com>
Gerrit-Reviewer: Erik Ernst <eer...@google.com>
Gerrit-Reviewer: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Attention: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Attention: Alexander Thomas <at...@google.com>
Gerrit-Comment-Date: Fri, 19 Dec 2025 08:26:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Sergey Grekhov (Gerrit)

unread,
Dec 19, 2025, 5:00:02 AM (3 days ago) Dec 19
to Erik Ernst, Commit Queue, Alexander Thomas, rev...@dartlang.org
Attention needed from Alexander Thomas and Erik Ernst

Sergey Grekhov voted and added 1 comment

Votes added by Sergey Grekhov

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Sergey Grekhov . resolved

All failures are OK (caused by tests for Augmentations, a feature that has not been implemented yet).

Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Thomas
  • Erik Ernst
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I04af7a7a61611fc599d885be641a2aecd71fa9f5
Gerrit-Change-Number: 469140
Gerrit-PatchSet: 2
Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Reviewer: Alexander Thomas <at...@google.com>
Gerrit-Reviewer: Erik Ernst <eer...@google.com>
Gerrit-Reviewer: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Attention: Alexander Thomas <at...@google.com>
Gerrit-Attention: Erik Ernst <eer...@google.com>
Gerrit-Comment-Date: Fri, 19 Dec 2025 09:59:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Erik Ernst (Gerrit)

unread,
Dec 19, 2025, 5:10:00 AM (2 days ago) Dec 19
to Sergey Grekhov, Commit Queue, Alexander Thomas, rev...@dartlang.org
Attention needed from Alexander Thomas and Sergey Grekhov

Erik Ernst voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Thomas
  • Sergey Grekhov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I04af7a7a61611fc599d885be641a2aecd71fa9f5
Gerrit-Change-Number: 469140
Gerrit-PatchSet: 2
Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Reviewer: Alexander Thomas <at...@google.com>
Gerrit-Reviewer: Erik Ernst <eer...@google.com>
Gerrit-Reviewer: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Attention: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Attention: Alexander Thomas <at...@google.com>
Gerrit-Comment-Date: Fri, 19 Dec 2025 10:09:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Alexander Thomas (Gerrit)

unread,
Dec 19, 2025, 6:52:49 AM (2 days ago) Dec 19
to Sergey Grekhov, Erik Ernst, Commit Queue, rev...@dartlang.org
Attention needed from Erik Ernst and Sergey Grekhov

Alexander Thomas voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Erik Ernst
  • Sergey Grekhov
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I04af7a7a61611fc599d885be641a2aecd71fa9f5
    Gerrit-Change-Number: 469140
    Gerrit-PatchSet: 2
    Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
    Gerrit-Reviewer: Alexander Thomas <at...@google.com>
    Gerrit-Reviewer: Erik Ernst <eer...@google.com>
    Gerrit-Reviewer: Sergey Grekhov <sgrek...@gmail.com>
    Gerrit-Attention: Sergey Grekhov <sgrek...@gmail.com>
    Gerrit-Attention: Erik Ernst <eer...@google.com>
    Gerrit-Comment-Date: Fri, 19 Dec 2025 11:52:44 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Commit Queue (Gerrit)

    unread,
    Dec 19, 2025, 6:53:05 AM (2 days ago) Dec 19
    to Sergey Grekhov, Alexander Thomas, Erik Ernst, rev...@dartlang.org

    Commit Queue submitted the change

    Change information

    Commit message:
    [co19] Roll co19 to 911100f1901c7e6de8ba5c8c290a0a3b7e33a997

    2025-12-18 sgrek...@gmail.com dart-lang/co19#3182. Add more augmenting getters/setters tests (dart-lang/co19#3448)
    2025-12-17 sgrek...@gmail.com dart-lang/co19#3182. Add more tests for augmenting external getters and setters (dart-lang/co19#3447)
    2025-12-17 sgrek...@gmail.com dart-lang/co19#3182. Add more augmenting getters/setters tests (dart-lang/co19#3446)
    2025-12-16 sgrek...@gmail.com dart-lang/co19#3182. Add more tests for augmenting getters (dart-lang/co19#3444)
    2025-12-12 sgrek...@gmail.com dart-lang/co19#3182. Replace augmenting getter tests (dart-lang/co19#3443)

    R=at...@google.com, eer...@google.com
    Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try
    Change-Id: I04af7a7a61611fc599d885be641a2aecd71fa9f5
    Reviewed-by: Erik Ernst <eer...@google.com>
    Auto-Submit: Sergey Grekhov <sgrek...@gmail.com>
    Commit-Queue: Alexander Thomas <at...@google.com>
    Reviewed-by: Alexander Thomas <at...@google.com>
    Files:
    • M DEPS
    • M tests/co19/co19-dart2js.status
    • M tests/co19/co19-dartdevc.status
    Change size: S
    Delta: 3 files changed, 13 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Erik Ernst, +1 by Alexander Thomas
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I04af7a7a61611fc599d885be641a2aecd71fa9f5
    Gerrit-Change-Number: 469140
    Gerrit-PatchSet: 3
    Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
    Gerrit-Reviewer: Alexander Thomas <at...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages