[M] Change in dart/sdk[main]: Add a --no-plugins option to prevent analyzer plugins from running

0 views
Skip to first unread message

Samuel Rawlins (Gerrit)

unread,
Jan 9, 2026, 12:46:46 PM (2 days ago) Jan 9
to Brian Wilkerson, Daco Harkes, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Daco Harkes

Samuel Rawlins voted and added 1 comment

Votes added by Samuel Rawlins

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Samuel Rawlins . resolved

The best spot I could find in analysis server code, to disable plugins, was in the plugin watcher. So we still have an instance of PluginWatcher. But it's `addedDriver` and `removeDriver` methods just do nothing.

I think it would be more complicated to have nullable PluginWatcher instances here and there but I could look into different implementations if we think they'd be better.

Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
  • Daco Harkes
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I902badd0a7a072b98691d88ad7b382828227b1fc
Gerrit-Change-Number: 471660
Gerrit-PatchSet: 2
Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Daco Harkes <dacoh...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Attention: Daco Harkes <dacoh...@google.com>
Gerrit-Comment-Date: Fri, 09 Jan 2026 17:46:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Brian Wilkerson (Gerrit)

unread,
Jan 9, 2026, 1:00:53 PM (2 days ago) Jan 9
to Samuel Rawlins, Brian Wilkerson, Daco Harkes, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Daco Harkes and Samuel Rawlins

Brian Wilkerson voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daco Harkes
  • Samuel Rawlins
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I902badd0a7a072b98691d88ad7b382828227b1fc
    Gerrit-Change-Number: 471660
    Gerrit-PatchSet: 2
    Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Daco Harkes <dacoh...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Daco Harkes <dacoh...@google.com>
    Gerrit-Comment-Date: Fri, 09 Jan 2026 18:00:50 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages