[S] Change in dart/sdk[main]: [ Service ] Fix various tests for package:dart_runtime_service_vm

0 views
Skip to first unread message

Ben Konyi (Gerrit)

unread,
Mar 27, 2026, 10:54:12 AM (3 days ago) Mar 27
to Jessy Yameogo, Nicholas Shahan, rev...@dartlang.org
Attention needed from Jessy Yameogo and Nicholas Shahan

Ben Konyi voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jessy Yameogo
  • Nicholas Shahan
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ic18c2b24a103347eee60ee803a873f747dbfee7a
Gerrit-Change-Number: 491200
Gerrit-PatchSet: 2
Gerrit-Owner: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Jessy Yameogo <yje...@google.com>
Gerrit-Reviewer: Nicholas Shahan <nsh...@google.com>
Gerrit-Attention: Jessy Yameogo <yje...@google.com>
Gerrit-Attention: Nicholas Shahan <nsh...@google.com>
Gerrit-Comment-Date: Fri, 27 Mar 2026 14:54:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nicholas Shahan (Gerrit)

unread,
2:01 PM (7 hours ago) 2:01 PM
to Ben Konyi, Commit Queue, Jessy Yameogo, rev...@dartlang.org
Attention needed from Ben Konyi and Jessy Yameogo

Nicholas Shahan voted and added 1 comment

Votes added by Nicholas Shahan

Code-Review+1

1 comment

File pkg/dart_runtime_service_vm/lib/src/dart_runtime_service_vm_rpcs.dart
Line 103, Patchset 2 (Latest): // TODO(bkonyi): remove for protocol version 5.x.
Nicholas Shahan . unresolved

A tracking issue link would be good here.

Open in Gerrit

Related details

Attention is currently required from:
  • Ben Konyi
  • Jessy Yameogo
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ic18c2b24a103347eee60ee803a873f747dbfee7a
Gerrit-Change-Number: 491200
Gerrit-PatchSet: 2
Gerrit-Owner: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Jessy Yameogo <yje...@google.com>
Gerrit-Reviewer: Nicholas Shahan <nsh...@google.com>
Gerrit-Attention: Ben Konyi <bko...@google.com>
Gerrit-Attention: Jessy Yameogo <yje...@google.com>
Gerrit-Comment-Date: Mon, 30 Mar 2026 18:01:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages