[M] Change in dart/sdk[main]: [analysis_server] Add client-side validation for Add Import Prefix

0 views
Skip to first unread message

Brian Wilkerson (Gerrit)

unread,
10:31 AM (13 hours ago) 10:31 AM
to Danny Tuppeny, Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Danny Tuppeny and Samuel Rawlins

Brian Wilkerson voted

Code-Review+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Danny Tuppeny
  • Samuel Rawlins
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I4901f6d75d5efbc502368a5e4d71a9aa7aa812d8
Gerrit-Change-Number: 524441
Gerrit-PatchSet: 1
Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Danny Tuppeny <da...@tuppeny.com>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Wed, 15 Jul 2026 14:31:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Samuel Rawlins (Gerrit)

unread,
12:45 PM (11 hours ago) 12:45 PM
to Danny Tuppeny, dart-...@luci-project-accounts.iam.gserviceaccount.com, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Danny Tuppeny

Samuel Rawlins voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Danny Tuppeny
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I4901f6d75d5efbc502368a5e4d71a9aa7aa812d8
    Gerrit-Change-Number: 524441
    Gerrit-PatchSet: 1
    Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Comment-Date: Wed, 15 Jul 2026 16:45:36 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Samuel Rawlins (Gerrit)

    unread,
    12:46 PM (11 hours ago) 12:46 PM
    to Danny Tuppeny, dart-...@luci-project-accounts.iam.gserviceaccount.com, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Danny Tuppeny

    Samuel Rawlins voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Danny Tuppeny
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I4901f6d75d5efbc502368a5e4d71a9aa7aa812d8
    Gerrit-Change-Number: 524441
    Gerrit-PatchSet: 1
    Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Comment-Date: Wed, 15 Jul 2026 16:46:02 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

    unread,
    12:47 PM (11 hours ago) 12:47 PM
    to Danny Tuppeny, Samuel Rawlins, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org

    dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

    Change information

    Commit message:
    [analysis_server] Add client-side validation for Add Import Prefix

    + fix a bug in the keyword regex that was disallowing keywords anywhere in the string instead of only full matches

    Fixes https://github.com/Dart-Code/Dart-Code/issues/6092
    Change-Id: I4901f6d75d5efbc502368a5e4d71a9aa7aa812d8
    Reviewed-by: Brian Wilkerson <brianwi...@google.com>
    Reviewed-by: Samuel Rawlins <sraw...@google.com>
    Commit-Queue: Samuel Rawlins <sraw...@google.com>
    Files:
    • M pkg/analysis_server/lib/src/services/refactoring/add_import_prefix.dart
    • M pkg/analysis_server/lib/src/services/refactoring/client_side_validators.dart
    • M pkg/analysis_server/test/services/refactoring/client_side_validation_test.dart
    • M pkg/analysis_server/test/src/services/refactoring/add_constructor_name_test.dart
    • M pkg/analysis_server/test/src/services/refactoring/add_import_prefix_test.dart
    Change size: M
    Delta: 5 files changed, 196 insertions(+), 28 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Brian Wilkerson, +1 by Samuel Rawlins
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I4901f6d75d5efbc502368a5e4d71a9aa7aa812d8
    Gerrit-Change-Number: 524441
    Gerrit-PatchSet: 2
    Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages