[XL] Change in dart/sdk[main]: [ SDK ] Add `js_runtime` and `js_dev_runtime` stubs for `dart:ffi`

0 views
Skip to first unread message

Ben Konyi (Gerrit)

unread,
Nov 28, 2025, 12:35:45 PM (yesterday) Nov 28
to Mark Zhou, Daco Harkes, Nate Biggs, Sigmund Cherem, dart2js-te...@google.com, dart-dc-te...@google.com, rev...@dartlang.org
Attention needed from Daco Harkes and Mark Zhou

Ben Konyi voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daco Harkes
  • Mark Zhou
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedCore-Library-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I7347dc81c8bffe0becaf4b1d002d6aca2de60244
Gerrit-Change-Number: 464960
Gerrit-PatchSet: 2
Gerrit-Owner: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Ben Konyi <bko...@google.com>
Gerrit-Reviewer: Daco Harkes <dacoh...@google.com>
Gerrit-Reviewer: Mark Zhou <mark...@google.com>
Gerrit-CC: Nate Biggs <nate...@google.com>
Gerrit-CC: Sigmund Cherem <sig...@google.com>
Gerrit-Attention: Mark Zhou <mark...@google.com>
Gerrit-Attention: Daco Harkes <dacoh...@google.com>
Gerrit-Comment-Date: Fri, 28 Nov 2025 17:35:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Ben Konyi (Gerrit)

unread,
Nov 28, 2025, 2:13:36 PM (yesterday) Nov 28
to Commit Queue, Mark Zhou, Daco Harkes, Nate Biggs, Sigmund Cherem, dart2js-te...@google.com, dart-dc-te...@google.com, rev...@dartlang.org
Attention needed from Daco Harkes and Mark Zhou

Ben Konyi added 2 comments

File sdk/lib/ffi/ffi.dart
Line 525, Patchset 6 (Latest): external bool get keepIsolateAlive;
Ben Konyi . unresolved

@dacoh...@google.com, I wasn't able to get this to work without adding explicit getters and setters as the patching mechanism doesn't seem to like patching properties with implicit getters and setters.

Line 2448, Patchset 6 (Latest): external Pointer<Never> get address;
Ben Konyi . unresolved

I _think_ this was a bug and don't think this is breaking since it shouldn't be possible to assign a `Pointer<Never>` anyway?

Open in Gerrit

Related details

Attention is currently required from:
  • Daco Harkes
  • Mark Zhou
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement satisfiedCore-Library-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I7347dc81c8bffe0becaf4b1d002d6aca2de60244
    Gerrit-Change-Number: 464960
    Gerrit-PatchSet: 6
    Gerrit-Owner: Ben Konyi <bko...@google.com>
    Gerrit-Reviewer: Ben Konyi <bko...@google.com>
    Gerrit-Reviewer: Daco Harkes <dacoh...@google.com>
    Gerrit-Reviewer: Mark Zhou <mark...@google.com>
    Gerrit-CC: Nate Biggs <nate...@google.com>
    Gerrit-CC: Sigmund Cherem <sig...@google.com>
    Gerrit-Attention: Mark Zhou <mark...@google.com>
    Gerrit-Attention: Daco Harkes <dacoh...@google.com>
    Gerrit-Comment-Date: Fri, 28 Nov 2025 19:13:32 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages