[XL] Change in dart/sdk[main]: [cfe][PrimaryConstructors] Treat enum generative constructors as impl...
0 views
Skip to first unread message
Johnni Winther (Gerrit)
Apr 21, 2026, 9:27:37 AM (yesterday) Apr 21
to Konstantin Shcheglov, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov
Johnni Winther voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Konstantin Shcheglov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Apr 21, 2026, 12:34:57 PM (23 hours ago) Apr 21
to Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther
Konstantin Shcheglov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Johnni Winther
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johnni Winther (Gerrit)
Apr 21, 2026, 3:00:32 PM (20 hours ago) Apr 21
to Konstantin Shcheglov, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-fe-te...@google.com, rev...@dartlang.org
Johnni Winther voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Apr 21, 2026, 3:00:47 PM (20 hours ago) Apr 21
to Johnni Winther, Konstantin Shcheglov, dart-fe-te...@google.com, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[cfe][PrimaryConstructors] Treat enum generative constructors as implicitly const
This treats enum generative constructors as implicitly const when primary-constructors is enabled.
Change-Id: Ic12f31b52468d3f725861bce20e259029dfd1d74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/495280
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Commit-Queue: Johnni Winther <johnni...@google.com>
Files:
- M pkg/front_end/lib/src/codes/diagnostic.g.dart
- M pkg/front_end/lib/src/source/outline_builder.dart
- M pkg/front_end/messages.yaml
- M pkg/front_end/testcases/enhanced_enums/malformed_constructors.dart
- M pkg/front_end/testcases/enhanced_enums/malformed_constructors.dart.strong.expect
- M pkg/front_end/testcases/enhanced_enums/malformed_constructors.dart.strong.modular.expect
- M pkg/front_end/testcases/enhanced_enums/malformed_constructors.dart.strong.outline.expect
- M pkg/front_end/testcases/enhanced_enums/malformed_constructors.dart.strong.transformed.expect
- M pkg/front_end/testcases/enhanced_enums/malformed_constructors.dart.textual_outline.expect
- M pkg/front_end/testcases/enhanced_enums/malformed_constructors.dart.textual_outline_modelled.expect
- M pkg/front_end/testcases/enhanced_enums/missed_checks.dart.strong.expect
- M pkg/front_end/testcases/enhanced_enums/missed_checks.dart.strong.modular.expect
- M pkg/front_end/testcases/enhanced_enums/missed_checks.dart.strong.outline.expect
- M pkg/front_end/testcases/enhanced_enums/missed_checks.dart.strong.transformed.expect
- M pkg/front_end/testcases/enhanced_enums/super_parameters/malformed_constructors.dart
- M pkg/front_end/testcases/enhanced_enums/super_parameters/malformed_constructors.dart.strong.expect
- M pkg/front_end/testcases/enhanced_enums/super_parameters/malformed_constructors.dart.strong.modular.expect
- M pkg/front_end/testcases/enhanced_enums/super_parameters/malformed_constructors.dart.strong.outline.expect
- M pkg/front_end/testcases/enhanced_enums/super_parameters/malformed_constructors.dart.strong.transformed.expect
- M pkg/front_end/testcases/enhanced_enums/super_parameters/malformed_constructors.dart.textual_outline.expect
- M pkg/front_end/testcases/enhanced_enums/super_parameters/malformed_constructors.dart.textual_outline_modelled.expect
- A pkg/front_end/testcases/primary_constructors/enum_const_pre_feature.dart
- A pkg/front_end/testcases/primary_constructors/enum_const_pre_feature.dart.strong.expect
- A pkg/front_end/testcases/primary_constructors/enum_const_pre_feature.dart.strong.modular.expect
- A pkg/front_end/testcases/primary_constructors/enum_const_pre_feature.dart.strong.outline.expect
- A pkg/front_end/testcases/primary_constructors/enum_const_pre_feature.dart.strong.transformed.expect
- A pkg/front_end/testcases/primary_constructors/enum_const_pre_feature.dart.textual_outline.expect
- A pkg/front_end/testcases/primary_constructors/enum_const_pre_feature.dart.textual_outline_modelled.expect
- M pkg/front_end/testcases/primary_constructors/enum_primary_constructor.dart
- M pkg/front_end/testcases/primary_constructors/enum_primary_constructor.dart.strong.expect
- M pkg/front_end/testcases/primary_constructors/enum_primary_constructor.dart.strong.modular.expect
- M pkg/front_end/testcases/primary_constructors/enum_primary_constructor.dart.strong.outline.expect
- M pkg/front_end/testcases/primary_constructors/enum_primary_constructor.dart.strong.transformed.expect
- M pkg/front_end/testcases/primary_constructors/enum_primary_constructor.dart.textual_outline.expect
- M pkg/front_end/testcases/primary_constructors/enum_primary_constructor.dart.textual_outline_modelled.expect
Change size: XL
Delta: 35 files changed, 1379 insertions(+), 168 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Konstantin Shcheglov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages