Felipe Morschel (Gerrit)

unread,

Mar 4, 2026, 11:16:27 AMMar 4

to dart-analys...@google.com, rev...@dartlang.org

Felipe Morschel has uploaded the change for review

Commit message

[DAS] Adds more information to type parameter hovers

Fixes: https://github.com/dart-lang/sdk/issues/62770

Change-Id: I9a806d1195ab3fc9c133fe91fb1376aaed0ae824

Change information

Files:

M pkg/analysis_server/lib/protocol/protocol_generated.dart
M pkg/analysis_server/lib/src/computer/computer_hover.dart
M pkg/analysis_server/lib/src/lsp/handlers/handler_hover.dart
M pkg/analysis_server/test/analysis/get_hover_test.dart
M pkg/analysis_server/test/lsp/hover_test.dart
M pkg/analyzer/lib/src/dart/element/display_string_builder.dart

Change size: L

Delta: 6 files changed, 219 insertions(+), 94 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Felipe Morschel (Gerrit)

unread,

Mar 4, 2026, 12:38:07 PMMar 4

to Brian Wilkerson, Samuel Rawlins, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Brian Wilkerson and Samuel Rawlins

Felipe Morschel voted Auto-Submit+1

Auto-Submit

+1

Open in Gerrit

Related details

Attention is currently required from:

Brian Wilkerson
Samuel Rawlins

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Felipe Morschel (Gerrit)

unread,

Mar 4, 2026, 12:39:24 PMMar 4

to Konstantin Shcheglov, Brian Wilkerson, Samuel Rawlins, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Brian Wilkerson, Konstantin Shcheglov and Samuel Rawlins

Felipe Morschel added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Felipe Morschel . resolved

Oh, I missed the `analyzer` change, so I'll add Konstantin too, and you can choose whoever reviews this. Thanks!

Open in Gerrit

Related details

Attention is currently required from:

Brian Wilkerson
Konstantin Shcheglov
Samuel Rawlins

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Danny Tuppeny (Gerrit)

unread,

Mar 4, 2026, 1:04:39 PMMar 4

to Felipe Morschel, Konstantin Shcheglov, Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Brian Wilkerson, Felipe Morschel, Konstantin Shcheglov and Samuel Rawlins

Danny Tuppeny added 2 comments

File pkg/analysis_server/tool/spec/spec_input.html

Line 4666, Patchset 2 (Latest): <field name="containingInstanceDescription" optional="true">

Danny Tuppeny . unresolved

If we did make changes here, there's a changelog section (either here, or in the common_types file?) that should be updated.

File pkg/analysis_server_client/lib/src/protocol/protocol_generated.dart

Line 10317, Patchset 2 (Parent):/// "containingClassDescription": optional String

Danny Tuppeny . unresolved

I think removing/renaming this is a breaking change to the legacy protocol (it's marked as optional so not breaking in the sense of breaking the protocol, but would prevent the data that was in it previously from being shown).

I don't know if IntelliJ is still using this though - I did find it referenced in a change here:

https://github.com/flutter/dart-intellij-third-party/commit/20004620ae97ea70d4485d56a63f2d51a258cba4

But that file doesn't seem to exist now, so I'm not sure what that means.

Open in Gerrit

Related details

Attention is currently required from:

Brian Wilkerson
Felipe Morschel
Konstantin Shcheglov
Samuel Rawlins

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Felipe Morschel (Gerrit)

unread,

Mar 4, 2026, 1:06:50 PMMar 4

to Konstantin Shcheglov, Brian Wilkerson, Samuel Rawlins, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Brian Wilkerson, Danny Tuppeny, Konstantin Shcheglov and Samuel Rawlins

Felipe Morschel added 2 comments

File pkg/analysis_server/tool/spec/spec_input.html

Line 4666, Patchset 2 (Latest): <field name="containingInstanceDescription" optional="true">

Danny Tuppeny . unresolved

If we did make changes here, there's a changelog section (either here, or in the common_types file?) that should be updated.

Felipe Morschel

I'll look for it, thanks!

File pkg/analysis_server_client/lib/src/protocol/protocol_generated.dart

Line 10317, Patchset 2 (Parent):/// "containingClassDescription": optional String

Danny Tuppeny . unresolved

I think removing/renaming this is a breaking change to the legacy protocol (it's marked as optional so not breaking in the sense of breaking the protocol, but would prevent the data that was in it previously from being shown).
I don't know if IntelliJ is still using this though - I did find it referenced in a change here:
https://github.com/flutter/dart-intellij-third-party/commit/20004620ae97ea70d4485d56a63f2d51a258cba4
But that file doesn't seem to exist now, so I'm not sure what that means.

Felipe Morschel

This rename is merely a suggestion. If you think this would break things, I can easily roll back.

Open in Gerrit

Related details

Attention is currently required from:

Brian Wilkerson
Danny Tuppeny
Konstantin Shcheglov
Samuel Rawlins

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Brian Wilkerson (Gerrit)

unread,

Mar 4, 2026, 2:25:22 PMMar 4

to Felipe Morschel, Konstantin Shcheglov, Brian Wilkerson, Samuel Rawlins, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Danny Tuppeny, Felipe Morschel, Konstantin Shcheglov and Samuel Rawlins

Brian Wilkerson added 3 comments

File pkg/analysis_server/test/lsp/hover_test.dart

Line 441, Patchset 2:Declared in `f` in _package:test/main.dart_.''';

Brian Wilkerson . unresolved

What follows is me thinking out loud (as it were), not a request for changes.

I understand the value of including information about where a type parameter is defined because they can come from multiple declarations. It's less clear to me that it's helpful for things like local variables, though I suppose for deeply nested local functions (which should almost never be used) it might be useful when referencing a variable from an outer scope. Including the package name for local variables seems like noise.

In the type parameter case it would probably be better to identify the kind of the element rather than just the name. For example "the class `C`" or "the method `m` in the class `C`". Not sure it's worth the extra effort though.

Line 1396, Patchset 2:Declared in `<unnamed>` in `foo` in _package:test/main.dart_.''';

Brian Wilkerson . unresolved

That's not very helpful, but then it's a local variable so I'm not convinced any of the extra text is useful. It wouldn't be any more helpful, but would read better, to say "a closure" (without the backticks, of course).

File pkg/analysis_server/tool/spec/spec_input.html

Line 4666, Patchset 2: <field name="containingInstanceDescription" optional="true">

Danny Tuppeny . unresolved

If we did make changes here, there's a changelog section (either here, or in the common_types file?) that should be updated.

Felipe Morschel

I'll look for it, thanks!

Brian Wilkerson

I consider this rename to be a breaking change, despite the fact that the field is marked 'optional'. The IDE plugin shouldn't fail as a result of the field not being defined, but the UX will be negatively impacted. Please revert the name change. (The updates to the description are fine.)

Open in Gerrit

Related details

Attention is currently required from:

Danny Tuppeny
Felipe Morschel
Konstantin Shcheglov
Samuel Rawlins

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Felipe Morschel (Gerrit)

unread,

Mar 6, 2026, 3:21:04 PMMar 6

to Konstantin Shcheglov, Brian Wilkerson, Samuel Rawlins, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Brian Wilkerson, Danny Tuppeny, Konstantin Shcheglov and Samuel Rawlins

Felipe Morschel voted and added 4 comments

Votes added by Felipe Morschel

Auto-Submit

+1

4 comments

File pkg/analysis_server/test/lsp/hover_test.dart

Line 441, Patchset 2:Declared in `f` in _package:test/main.dart_.''';

Brian Wilkerson . resolved

What follows is me thinking out loud (as it were), not a request for changes.
I understand the value of including information about where a type parameter is defined because they can come from multiple declarations. It's less clear to me that it's helpful for things like local variables, though I suppose for deeply nested local functions (which should almost never be used) it might be useful when referencing a variable from an outer scope. Including the package name for local variables seems like noise.
In the type parameter case it would probably be better to identify the kind of the element rather than just the name. For example "the class `C`" or "the method `m` in the class `C`". Not sure it's worth the extra effort though.

Felipe Morschel

"the class `C`" or "the method `m` in the class `C`"

I'd love to have this. I didn't just do it because I wasn't sure how the class reference was used by IntelliJ (legacy). I'll do it, and if you can think of a case where this can be wrong, I can undo.

Including the package name for local variables seems like noise.

I agree, but it does so when it gets to the class by default, so special-casing that doesn't seem that important. And this would help if something like https://github.com/dart-lang/language/issues/67#issuecomment-4006650906 were ever implemented.

Line 1396, Patchset 2:Declared in `<unnamed>` in `foo` in _package:test/main.dart_.''';

Brian Wilkerson . resolved

That's not very helpful, but then it's a local variable so I'm not convinced any of the extra text is useful. It wouldn't be any more helpful, but would read better, to say "a closure" (without the backticks, of course).

Felipe Morschel

I can wrap that too. This is the displayName of the element.

File pkg/analysis_server/tool/spec/spec_input.html

Line 4666, Patchset 2: <field name="containingInstanceDescription" optional="true">

Danny Tuppeny . resolved

If we did make changes here, there's a changelog section (either here, or in the common_types file?) that should be updated.

Felipe Morschel

I'll look for it, thanks!

Brian Wilkerson

I consider this rename to be a breaking change, despite the fact that the field is marked 'optional'. The IDE plugin shouldn't fail as a result of the field not being defined, but the UX will be negatively impacted. Please revert the name change. (The updates to the description are fine.)

Felipe Morschel

I'll undo it and add the new field to the changelog. Thanks!

File pkg/analysis_server_client/lib/src/protocol/protocol_generated.dart

Line 10317, Patchset 2 (Parent):/// "containingClassDescription": optional String

Danny Tuppeny . resolved

I think removing/renaming this is a breaking change to the legacy protocol (it's marked as optional so not breaking in the sense of breaking the protocol, but would prevent the data that was in it previously from being shown).
I don't know if IntelliJ is still using this though - I did find it referenced in a change here:
https://github.com/flutter/dart-intellij-third-party/commit/20004620ae97ea70d4485d56a63f2d51a258cba4
But that file doesn't seem to exist now, so I'm not sure what that means.

Felipe Morschel

This rename is merely a suggestion. If you think this would break things, I can easily roll back.

Felipe Morschel

Done

Open in Gerrit

Related details

Attention is currently required from:

Brian Wilkerson
Danny Tuppeny
Konstantin Shcheglov
Samuel Rawlins

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

FMorschel (Gerrit)

unread,

Jul 15, 2026, 8:35:06 AMJul 15

to Konstantin Shcheglov, Brian Wilkerson, Samuel Rawlins, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Brian Wilkerson, Danny Tuppeny, Konstantin Shcheglov and Samuel Rawlins

FMorschel voted and added 1 comment

Votes added by FMorschel

Auto-Submit

+1

1 comment

File pkg/analysis_server/test/lsp/hover_test.dart

Line 1470, Patchset 4: await assertNullHover(content);

FMorschel . unresolved

After I created `test_typeParameter_declaration`, this one fails. What would you expect from this declaration? Should I special-case the `name` being `_`?

CC @brianwi...@google.com

Open in Gerrit

Related details

Attention is currently required from:

Brian Wilkerson
Danny Tuppeny
Konstantin Shcheglov
Samuel Rawlins

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Brian Wilkerson (Gerrit)

unread,

Jul 16, 2026, 2:34:33 PMJul 16

to FMorschel, Konstantin Shcheglov, Brian Wilkerson, Samuel Rawlins, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Danny Tuppeny, FMorschel, Konstantin Shcheglov and Samuel Rawlins

Brian Wilkerson added 1 comment

File pkg/analysis_server/test/lsp/hover_test.dart

Line 1470, Patchset 4: await assertNullHover(content);

FMorschel . unresolved

After I created `test_typeParameter_declaration`, this one fails. What would you expect from this declaration? Should I special-case the `name` being `_`?
CC @brianwi...@google.com

Brian Wilkerson

After I created test_typeParameter_declaration, this one fails.

Adding one test shouldn't be able to effect any other tests. Are you sure you didn't change anything else?

What would you expect from this declaration?

For hover? I don't know. I don't think there's anything useful to say, so we might want to just not produce a hover here, or for any wildcard.

But we should consider having a diagnostic (probably a lint) telling the user to remove the type parameter. There's no value that I can think of for using a wildcard as a type parameter.

Open in Gerrit

Related details

Attention is currently required from:

Danny Tuppeny
FMorschel
Konstantin Shcheglov
Samuel Rawlins

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

FMorschel (Gerrit)

unread,

Jul 16, 2026, 2:45:53 PMJul 16

to Konstantin Shcheglov, Brian Wilkerson, Samuel Rawlins, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Brian Wilkerson

FMorschel voted and added 1 comment

Votes added by FMorschel

Auto-Submit

+1

1 comment

File pkg/analysis_server/test/lsp/hover_test.dart

Line 1470, Patchset 4: await assertNullHover(content);

FMorschel . unresolved

After I created `test_typeParameter_declaration`, this one fails. What would you expect from this declaration? Should I special-case the `name` being `_`?
CC @brianwi...@google.com

Brian Wilkerson

After I created test_typeParameter_declaration, this one fails.
Adding one test shouldn't be able to effect any other tests. Are you sure you didn't change anything else?
What would you expect from this declaration?
For hover? I don't know. I don't think there's anything useful to say, so we might want to just not produce a hover here, or for any wildcard.
But we should consider having a diagnostic (probably a lint) telling the user to remove the type parameter. There's no value that I can think of for using a wildcard as a type parameter.

FMorschel

Adding one test shouldn't be able to effect any other tests. Are you sure you didn't change anything else?

Oh, yes, I changed more code to make it pass, because we simply weren't producing any hover at the declaration site. I should've been clearer.

I'll special-case for wildcards then.

We already have `no_wildcard_variable_uses`, but it doesn't trigger for type parameters.

I've opened https://github.com/dart-lang/sdk/issues/63831.

Open in Gerrit

Related details

Attention is currently required from:

Brian Wilkerson

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

FMorschel (Gerrit)

unread,

Aug 4, 2026, 11:18:44 PM (20 hours ago) Aug 4

to Konstantin Shcheglov, Brian Wilkerson, Samuel Rawlins, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Brian Wilkerson

FMorschel voted and added 1 comment

Votes added by FMorschel

Auto-Submit

+1

1 comment

File pkg/analysis_server/test/lsp/hover_test.dart

Line 1470, Patchset 4: await assertNullHover(content);

FMorschel . resolved

After I created `test_typeParameter_declaration`, this one fails. What would you expect from this declaration? Should I special-case the `name` being `_`?
CC @brianwi...@google.com

Brian Wilkerson

After I created test_typeParameter_declaration, this one fails.
Adding one test shouldn't be able to effect any other tests. Are you sure you didn't change anything else?
What would you expect from this declaration?
For hover? I don't know. I don't think there's anything useful to say, so we might want to just not produce a hover here, or for any wildcard.
But we should consider having a diagnostic (probably a lint) telling the user to remove the type parameter. There's no value that I can think of for using a wildcard as a type parameter.

FMorschel

Adding one test shouldn't be able to effect any other tests. Are you sure you didn't change anything else?
Oh, yes, I changed more code to make it pass, because we simply weren't producing any hover at the declaration site. I should've been clearer.
I'll special-case for wildcards then.
We already have `no_wildcard_variable_uses`, but it doesn't trigger for type parameters.
I've opened https://github.com/dart-lang/sdk/issues/63831.

FMorschel

Done

Open in Gerrit

Related details

Attention is currently required from:

Brian Wilkerson

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Danny Tuppeny (Gerrit)

unread,

6:12 AM (13 hours ago) 6:12 AM

to FMorschel, Konstantin Shcheglov, Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Brian Wilkerson and FMorschel

Danny Tuppeny added 1 comment

File pkg/analysis_server/tool/spec/spec_input.html

Line 4666, Patchset 2: <field name="containingInstanceDescription" optional="true">

Danny Tuppeny . resolved

If we did make changes here, there's a changelog section (either here, or in the common_types file?) that should be updated.

FMorschel

I'll look for it, thanks!

Brian Wilkerson

I consider this rename to be a breaking change, despite the fact that the field is marked 'optional'. The IDE plugin shouldn't fail as a result of the field not being defined, but the UX will be negatively impacted. Please revert the name change. (The updates to the description are fine.)

FMorschel

I'll undo it and add the new field to the changelog. Thanks!

Danny Tuppeny

If I'm looking at this correctly, this still contains the rename that could be breaking to legacy clients?

Open in Gerrit

Related details

Attention is currently required from:

Brian Wilkerson
FMorschel

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Brian Wilkerson (Gerrit)

unread,

1:50 PM (5 hours ago) 1:50 PM

to FMorschel, Brian Wilkerson, Konstantin Shcheglov, Samuel Rawlins, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Danny Tuppeny and FMorschel

Brian Wilkerson voted and added 1 comment

Votes added by Brian Wilkerson

Code-Review	+1
Commit-Queue	+1

1 comment

File pkg/analysis_server/tool/spec/spec_input.html

Line 4666, Patchset 2: <field name="containingInstanceDescription" optional="true">

Danny Tuppeny . resolved

If we did make changes here, there's a changelog section (either here, or in the common_types file?) that should be updated.

FMorschel

I'll look for it, thanks!

Brian Wilkerson

I consider this rename to be a breaking change, despite the fact that the field is marked 'optional'. The IDE plugin shouldn't fail as a result of the field not being defined, but the UX will be negatively impacted. Please revert the name change. (The updates to the description are fine.)

FMorschel

I'll undo it and add the new field to the changelog. Thanks!

Danny Tuppeny

If I'm looking at this correctly, this still contains the rename that could be breaking to legacy clients?

Brian Wilkerson

I don't think so. The 'undo' consisted of adding a new field with the new name rather than renaming an existing field to the new name. It appears that the old field is still being set to the old value, so there shouldn't be any degradation.

Open in Gerrit

Related details

Attention is currently required from:

Danny Tuppeny
FMorschel

Submit Requirements:

Code-Owners

Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

FMorschel (Gerrit)

unread,

1:54 PM (5 hours ago) 1:54 PM

to dart-...@luci-project-accounts.iam.gserviceaccount.com, Brian Wilkerson, Konstantin Shcheglov, Samuel Rawlins, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Danny Tuppeny

FMorschel voted and added 1 comment

Votes added by FMorschel

Auto-Submit

+1

1 comment

File pkg/analysis_server/tool/spec/spec_input.html

Line 4666, Patchset 2: <field name="containingInstanceDescription" optional="true">

Danny Tuppeny . resolved

If we did make changes here, there's a changelog section (either here, or in the common_types file?) that should be updated.

FMorschel

I'll look for it, thanks!

Brian Wilkerson

I consider this rename to be a breaking change, despite the fact that the field is marked 'optional'. The IDE plugin shouldn't fail as a result of the field not being defined, but the UX will be negatively impacted. Please revert the name change. (The updates to the description are fine.)

FMorschel

I'll undo it and add the new field to the changelog. Thanks!

Danny Tuppeny

If I'm looking at this correctly, this still contains the rename that could be breaking to legacy clients?

Brian Wilkerson

I don't think so. The 'undo' consisted of adding a new field with the new name rather than renaming an existing field to the new name. It appears that the old field is still being set to the old value, so there shouldn't be any degradation.

FMorschel

I've sent a new patchset, but I didn't respond to this thread (forgot, sorry). There was something incorrect with my previous changes. But it is fixed now.

Open in Gerrit

Related details

Attention is currently required from:

Danny Tuppeny

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

FMorschel (Gerrit)

unread,

3:09 PM (4 hours ago) 3:09 PM

to Keerti Parthasarathy, Samuel Rawlins, Konstantin Shcheglov, dart-...@luci-project-accounts.iam.gserviceaccount.com, Brian Wilkerson, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Brian Wilkerson and Keerti Parthasarathy

FMorschel voted and added 1 comment

Votes added by FMorschel

Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 8 (Latest):

FMorschel . resolved

Everything fixed. Thanks for the bots!

Open in Gerrit

Related details

Attention is currently required from:

Brian Wilkerson
Keerti Parthasarathy

Submit Requirements:

Code-Owners

Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Brian Wilkerson (Gerrit)

unread,

5:05 PM (2 hours ago) 5:05 PM

to FMorschel, Brian Wilkerson, Keerti Parthasarathy, Samuel Rawlins, Konstantin Shcheglov, dart-...@luci-project-accounts.iam.gserviceaccount.com, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org

Attention needed from FMorschel and Keerti Parthasarathy

Brian Wilkerson voted

Code-Review	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

FMorschel
Keerti Parthasarathy

Submit Requirements:

Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

FMorschel (Gerrit)

unread,

6:39 PM (22 minutes ago) 6:39 PM

to Brian Wilkerson, Keerti Parthasarathy, Samuel Rawlins, Konstantin Shcheglov, dart-...@luci-project-accounts.iam.gserviceaccount.com, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Brian Wilkerson and Keerti Parthasarathy

FMorschel voted and added 1 comment

Votes added by FMorschel

Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 8:

FMorschel . resolved

Everything fixed. Thanks for the bots!

FMorschel

Oh, a separate file with the same name elsewhere still had a problem. Now things are truly handled. Sorry for the false-positive.

Open in Gerrit

Related details

Attention is currently required from:

Brian Wilkerson
Keerti Parthasarathy

Submit Requirements:

Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[L] Change in dart/sdk[main]: [DAS] Adds more information to type parameter hovers

Felipe Morschel (Gerrit)

Felipe Morschel has uploaded the change for review

Commit message

Change information

Related details

Felipe Morschel (Gerrit)

Felipe Morschel voted Auto-Submit+1

Related details

Felipe Morschel (Gerrit)

Felipe Morschel added 1 comment

Related details

Danny Tuppeny (Gerrit)

Danny Tuppeny added 2 comments

Related details

Felipe Morschel (Gerrit)

Felipe Morschel added 2 comments

Related details

Brian Wilkerson (Gerrit)

Brian Wilkerson added 3 comments

Related details

Felipe Morschel (Gerrit)

Felipe Morschel voted and added 4 comments

Votes added by Felipe Morschel

4 comments

Related details

FMorschel (Gerrit)

FMorschel voted and added 1 comment

Votes added by FMorschel

1 comment

Related details

Brian Wilkerson (Gerrit)

Brian Wilkerson added 1 comment

Related details

FMorschel (Gerrit)

FMorschel voted and added 1 comment

Votes added by FMorschel

1 comment

Related details

FMorschel (Gerrit)

FMorschel voted and added 1 comment

Votes added by FMorschel

1 comment

Related details

Danny Tuppeny (Gerrit)

Danny Tuppeny added 1 comment

Related details

Brian Wilkerson (Gerrit)

Brian Wilkerson voted and added 1 comment

Votes added by Brian Wilkerson

1 comment

Related details

FMorschel (Gerrit)

FMorschel voted and added 1 comment

Votes added by FMorschel

1 comment

Related details

FMorschel (Gerrit)

FMorschel voted and added 1 comment

Votes added by FMorschel

1 comment

Related details

Brian Wilkerson (Gerrit)

Brian Wilkerson voted

Related details

FMorschel (Gerrit)

FMorschel voted and added 1 comment

Votes added by FMorschel

1 comment

Related details