[M] Change in dart/sdk[main]: [migrate] Allow additional force enabled codes in BulkFixProcessor.
Kallen Tu (Gerrit)
Kallen Tu added 2 comments![]( "Open in Gerrit")
Konstantin ShcheglovHey everyone. This is a WIP of changing the BulkFixProcessor to be able to handle force-enabled lints, which will eventually be used for the migrate tool's pre-migration and post-migration phase.
I cloned the driver and the analysis options map. The analysis options map has existing lints and the new ones we're trying to enable.
This is what I understood from our email thread, so let me know if I'm overlooking some API I should be using or if this is different than what you envisioned. I'd appreciate if you could give this a look to LMK if I'm completely off the mark here. Thank you!
Kallen TuMy understanding of the email thread was: don't clone, prefer using API; so create a new `AnalysisContextCollection` using the same `ByteStore` instance, maybe with `OverlayResourceProvider` to patch `analysis_options.yaml` file(s).
Kallen TuNoted. Made more changes, PTAL.
Resolving.
var originalDriver = (originalContext as DriverBasedAnalysisContext).driver;Kallen TuThe server already knows resourceProvider and byteStore, there is no need to pick them out of the driver. Pass them down from the calling context.
Passed them in as parameters, PTAL
Related details
- Brian Wilkerson
- Konstantin Shcheglov
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Konstantin Shcheglov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Konstantin Shcheglov
| Code-Review | +1 |
1 comment
this._workspace, {These probably could be part of workspace.
Related details
- Brian Wilkerson
- Kallen Tu
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kallen Tu (Gerrit)
Kallen Tu added 1 comment![]( "Open in Gerrit")
this._workspace, {These probably could be part of workspace.
Adding byteStore to `DartChangeWorkspace` changes 20+ callsites if the parameter was required, and many of those call sites aren't using BulkFixProcessor afterwards. If we kept it optional, I'd prefer it to be in the parameter list of BulkFixProcessor, like how it is now.
Removed the resourceProvider though. We can get that through the workspace.
Related details
- Brian Wilkerson
- Konstantin Shcheglov
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Brian Wilkerson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Brian Wilkerson
| Code-Review | +1 |
1 comment
includedPaths: [originalContext.contextRoot.root.path],I think this needs to pass in the excluded paths as well, otherwise it might analyze more files than intended, which could lead to unwanted fixes being applied.
If that's true, then we should have a regression test.
I don't think it will break users to land this as-is and address the exclusions in a follow-on CL if you want.
Related details
- Kallen Tu
- Konstantin Shcheglov
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kallen Tu (Gerrit)
Kallen Tu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kallen Tu
| Commit-Queue | +2 |
1 comment
includedPaths: [originalContext.contextRoot.root.path],I think this needs to pass in the excluded paths as well, otherwise it might analyze more files than intended, which could lead to unwanted fixes being applied.
If that's true, then we should have a regression test.
I don't think it will break users to land this as-is and address the exclusions in a follow-on CL if you want.
- Brian Wilkerson
- Konstantin Shcheglov
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
[migrate] Allow additional force enabled codes in BulkFixProcessor.
This CL allows the BulkFixProcessor to handle additional force-enabled
codes that may not be enabled in the existing analysis options of the
current project.
- M pkg/analysis_server/lib/src/handler/legacy/edit_bulk_fixes.dart
- M pkg/analysis_server/lib/src/lsp/handlers/commands/fix_all.dart
- M pkg/analysis_server/lib/src/lsp/handlers/commands/fix_all_in_workspace.dart
- M pkg/analysis_server/lib/src/services/correction/bulk_fix_processor.dart
- M pkg/analysis_server/lib/src/services/user_prompts/dart_fix_prompt_manager.dart
- M pkg/analysis_server/test/abstract_context.dart
- M pkg/analysis_server/test/src/services/correction/fix/bulk_fix_processor_test.dart
- M pkg/analysis_server/test/src/services/correction/fix/fix_processor.dart
Code-Review: +1 by Brian Wilkerson, +1 by Konstantin Shcheglov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |