[M] Change in dart/sdk[main]: [vm/io] Signal to fork()ed child only in non detached mode
0 views
Skip to first unread message
Ryan Macnak (Gerrit)
Jul 13, 2026, 2:23:31 PM (3 days ago) Jul 13
to Martin Kustermann, Slava Egorov, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Martin Kustermann and Slava Egorov
Ryan Macnak voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Martin Kustermann
- Slava Egorov
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Martin Kustermann (Gerrit)
Jul 14, 2026, 5:58:25 AM (2 days ago) Jul 14
to Ryan Macnak, Slava Egorov, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Slava Egorov
Martin Kustermann voted and added 1 comment![]( "Open in Gerrit")
Votes added by Martin Kustermann
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Slava Egorov
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Martin Kustermann (Gerrit)
Jul 15, 2026, 3:47:52 PM (12 hours ago) Jul 15
to Ryan Macnak, Slava Egorov, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Slava Egorov
Martin Kustermann voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Slava Egorov
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jul 15, 2026, 4:21:22 PM (12 hours ago) Jul 15
to Martin Kustermann, Ryan Macnak, Slava Egorov, rev...@dartlang.org, vm-...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[vm/io] Signal to fork()ed child only in non detached mode
When we start a process in detached mode, we're not interested in it's
exit code. The code that makes the child wait for "go signal" from
parent is only there for the case where we're interested in the exit
code.
=> Avoid doing this for detached processes.
Also: If we launch the detached process without stdin/stdout/stderr
communication channels, we can avoid creating the pipe.
Issue https://github.com/dart-lang/sdk/issues/62781
TEST=Existing test suite
Change-Id: I60c658f6211d0a6a068c0f7588bd9e3544daf8ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/523060
Commit-Queue: Martin Kustermann <kuste...@google.com>
Reviewed-by: Ryan Macnak <rma...@google.com>
Files:
- M runtime/bin/process_linux.cc
- M runtime/bin/process_macos.cc
Change size: M
Delta: 2 files changed, 60 insertions(+), 60 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ryan Macnak
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages