[XL] Change in dart/sdk[main]: DeCo. Add PropertyInducingElement.isOriginDeclaration, isOriginGetter...
0 views
Skip to first unread message
Samuel Rawlins (Gerrit)
Dec 1, 2025, 9:08:29 PM (2 days ago) Dec 1
to Konstantin Shcheglov, Paul Berry, Johnni Winther, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther, Konstantin Shcheglov and Paul Berry
Samuel Rawlins voted and added 1 comment![]( "Open in Gerrit")
Votes added by Samuel Rawlins
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Samuel Rawlins . resolved
I like this. I prefer the word "provenance" that you've used in discussions, but that's a little long (and perhaps obscure) for the API. "Origin" seems fine.
Related details
Attention is currently required from:
- Johnni Winther
- Konstantin Shcheglov
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Dec 1, 2025, 9:08:53 PM (2 days ago) Dec 1
to Konstantin Shcheglov, Paul Berry, Johnni Winther, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther, Konstantin Shcheglov and Paul Berry
Samuel Rawlins voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Johnni Winther
- Konstantin Shcheglov
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johnni Winther (Gerrit)
Dec 2, 2025, 6:01:25 AM (21 hours ago) Dec 2
to Konstantin Shcheglov, Samuel Rawlins, Paul Berry, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov and Paul Berry
Johnni Winther voted and added 2 comments![]( "Open in Gerrit")
Votes added by Johnni Winther
| Code-Review | +1 |
2 comments
File pkg/analyzer/lib/dart/element/element.dart
Line 2988, Patchset 5 (Latest):
/// Whether the constructor is from an explicit [FieldDeclaration],Johnni Winther . unresolved
property?
Line 2994, Patchset 5 (Latest):
/// Whether the constructor is from a getter or setter.Johnni Winther . unresolved
property?
Related details
Attention is currently required from:
- Konstantin Shcheglov
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Berry (Gerrit)
Dec 2, 2025, 12:17:25 PM (15 hours ago) Dec 2
to Konstantin Shcheglov, Johnni Winther, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov
Paul Berry added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Paul Berry . resolved
This CL is too large for me to be able to code review effectively. My personal opinion is that it would be good engineering practice to split it up into two CLs: one that adds the new functionality but preserves test expectations (adjusting the element printer if necessary), and a follow-up CL that updates the element printer and the test expectations.
My rationale for suggesting this split is that it would be much easier to argue that the two CLs are safe: the first would be clearly safe because it wouldn't contain any test expectation changes, and the second would be clearly safe because it would contain only test changes.
But since others have already given you +1s, if you want to go ahead and land it on the strength of others' review, I won't try to stop you.
Related details
Attention is currently required from:
- Konstantin Shcheglov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Dec 2, 2025, 12:19:25 PM (15 hours ago) Dec 2
to Johnni Winther, Samuel Rawlins, Paul Berry, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Konstantin Shcheglov added 2 comments![]( "Open in Gerrit")
File pkg/analyzer/lib/dart/element/element.dart
Line 2988, Patchset 5:
/// Whether the constructor is from an explicit [FieldDeclaration],Johnni Winther . resolved
Konstantin Shcheglovproperty?
Done
Line 2994, Patchset 5:
/// Whether the constructor is from a getter or setter.Johnni Winther . resolved
Konstantin Shcheglovproperty?
Done
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Dec 2, 2025, 12:39:21 PM (15 hours ago) Dec 2
to Johnni Winther, Samuel Rawlins, Paul Berry, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Paul Berry
Konstantin Shcheglov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Paul Berry . resolved
This CL is too large for me to be able to code review effectively. My personal opinion is that it would be good engineering practice to split it up into two CLs: one that adds the new functionality but preserves test expectations (adjusting the element printer if necessary), and a follow-up CL that updates the element printer and the test expectations.
My rationale for suggesting this split is that it would be much easier to argue that the two CLs are safe: the first would be clearly safe because it wouldn't contain any test expectation changes, and the second would be clearly safe because it would contain only test changes.
But since others have already given you +1s, if you want to go ahead and land it on the strength of others' review, I won't try to stop you.
Konstantin Shcheglov
I agree, just implementation without changes to the text output, specifically without writing new flags, is useful. See https://dart-review.googlesource.com/c/sdk/+/465663 that I made post factum.
Related details
Attention is currently required from:
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Dec 2, 2025, 2:24:03 PM (13 hours ago) Dec 2
to Johnni Winther, Samuel Rawlins, Paul Berry, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Paul Berry
Konstantin Shcheglov voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Dec 2, 2025, 2:24:25 PM (13 hours ago) Dec 2
to Konstantin Shcheglov, Johnni Winther, Samuel Rawlins, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: pkg/analyzer/lib/dart/element/element.dart
Insertions: 2, Deletions: 2.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
DeCo. Add PropertyInducingElement.isOriginDeclaration, isOriginGetterSetter; FieldElement.isOriginDeclaringFormalParameter, isOriginEnumValues.
Change-Id: I92c756a7c74031222efca38a73224dfeff18598b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/465481
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Files:
- M pkg/analysis_server/lib/src/cider/local_library_contributor.dart
- M pkg/analysis_server/lib/src/cider/rename.dart
- M pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart
- M pkg/analysis_server/lib/src/lsp/handlers/custom/handler_summary.dart
- M pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart
- M pkg/analysis_server/lib/src/services/completion/dart/relevance_computer.dart
- M pkg/analysis_server/lib/src/services/correction/dart/add_late.dart
- M pkg/analysis_server/lib/src/services/correction/dart/add_missing_enum_like_case_clauses.dart
- M pkg/analysis_server/lib/src/services/correction/dart/change_to.dart
- M pkg/analysis_server/lib/src/services/correction/dart/make_field_not_final.dart
- M pkg/analysis_server/lib/src/utilities/import_analyzer.dart
- M pkg/analyzer/CHANGELOG.md
- M pkg/analyzer/api.txt
- M pkg/analyzer/lib/dart/element/element.dart
- M pkg/analyzer/lib/src/dart/analysis/driver.dart
- M pkg/analyzer/lib/src/dart/analysis/search.dart
- M pkg/analyzer/lib/src/dart/element/element.dart
- M pkg/analyzer/lib/src/dart/element/element.g.dart
- M pkg/analyzer/lib/src/dart/element/inheritance_manager3.dart
- M pkg/analyzer/lib/src/dart/element/member.dart
- M pkg/analyzer/lib/src/dart/resolver/flow_analysis_visitor.dart
- M pkg/analyzer/lib/src/error/assignment_verifier.dart
- M pkg/analyzer/lib/src/error/best_practices_verifier.dart
- M pkg/analyzer/lib/src/error/constructor_fields_verifier.dart
- M pkg/analyzer/lib/src/error/inheritance_override.dart
- M pkg/analyzer/lib/src/fine/manifest_item.dart
- M pkg/analyzer/lib/src/generated/error_verifier.dart
- M pkg/analyzer/lib/src/summary2/element_builder.dart
- M pkg/analyzer/lib/src/summary2/instance_member_inferrer.dart
- M pkg/analyzer/lib/src/summary2/library_builder.dart
- M pkg/analyzer/lib/src/summary2/link.dart
- M pkg/analyzer/test/generated/elements_types_mixin.dart
- M pkg/analyzer/test/id_tests/constant_test.dart
- M pkg/analyzer/test/src/dart/analysis/driver_test.dart
- M pkg/analyzer/test/src/dart/analysis/search_test.dart
- M pkg/analyzer/test/src/dart/resolution/instance_member_inference_class_test.dart
- M pkg/analyzer/test/src/summary/element_text.dart
- M pkg/analyzer/test/src/summary/elements/class_test.dart
- M pkg/analyzer/test/src/summary/elements/const_test.dart
- M pkg/analyzer/test/src/summary/elements/default_value_test.dart
- M pkg/analyzer/test/src/summary/elements/duplicate_declaration_test.dart
- M pkg/analyzer/test/src/summary/elements/enum_test.dart
- M pkg/analyzer/test/src/summary/elements/extension_test.dart
- M pkg/analyzer/test/src/summary/elements/extension_type_test.dart
- M pkg/analyzer/test/src/summary/elements/formal_parameter_test.dart
- M pkg/analyzer/test/src/summary/elements/function_type_annotation_test.dart
- M pkg/analyzer/test/src/summary/elements/library_export_test.dart
- M pkg/analyzer/test/src/summary/elements/library_import_test.dart
- M pkg/analyzer/test/src/summary/elements/local_declarations_test.dart
- M pkg/analyzer/test/src/summary/elements/metadata_test.dart
- M pkg/analyzer/test/src/summary/elements/mixin_test.dart
- M pkg/analyzer/test/src/summary/elements/non_synthetic_test.dart
- M pkg/analyzer/test/src/summary/elements/offsets_test.dart
- M pkg/analyzer/test/src/summary/elements/record_type_test.dart
- M pkg/analyzer/test/src/summary/elements/since_sdk_version_test.dart
- M pkg/analyzer/test/src/summary/elements/top_level_function_test.dart
- M pkg/analyzer/test/src/summary/elements/top_level_variable_test.dart
- M pkg/analyzer/test/src/summary/elements/type_alias_test.dart
- M pkg/analyzer/test/src/summary/elements/type_inference_test.dart
- M pkg/analyzer/test/src/summary/elements/types_test.dart
- M pkg/analyzer/test/src/summary/top_level_inference_test.dart
- M pkg/linter/lib/src/extensions.dart
- M pkg/linter/lib/src/rules/analyzer_public_api.dart
- M pkg/linter/lib/src/rules/prefer_initializing_formals.dart
Change size: XL
Delta: 64 files changed, 4074 insertions(+), 3840 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Samuel Rawlins, +1 by Johnni Winther
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages