[M] Change in dart/sdk[main]: DeCo. Don't check for isSynthetic in getClassMembers.
0 views
Skip to first unread message
Konstantin Shcheglov (Gerrit)
Nov 29, 2025, 8:11:11 PM (3 days ago) Nov 29
to Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson
Konstantin Shcheglov voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Brian Wilkerson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Dec 1, 2025, 4:00:17 PM (19 hours ago) Dec 1
to Konstantin Shcheglov, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov
Brian Wilkerson voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Konstantin Shcheglov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Dec 1, 2025, 4:00:29 PM (19 hours ago) Dec 1
to Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Konstantin Shcheglov voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Dec 1, 2025, 4:00:46 PM (19 hours ago) Dec 1
to Konstantin Shcheglov, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
DeCo. Don't check for isSynthetic in getClassMembers.
The clients don't care, we need just to know if there is something or not.
Change-Id: Iaad9a4fb838a7776184e57ab165d160a8daf6105
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/465200
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Files:
- M pkg/analysis_server/lib/src/services/search/hierarchy.dart
- M pkg/analysis_server/test/services/search/hierarchy_test.dart
Change size: M
Delta: 2 files changed, 70 insertions(+), 53 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brian Wilkerson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages