[L] Change in dart/sdk[main]: dart2wasm: Prepare standalone target
0 views
Skip to first unread message
Simon Binder (Gerrit)
Mar 7, 2026, 10:29:29 AM (3 days ago) Mar 7
to Martin Kustermann, dart-fe-te...@google.com, dart-uxr...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Martin Kustermann
Simon Binder added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Simon Binder . unresolved
I'm going to need some help configuring the test bots for this one, I've mostly copied test configurations through pattern matching. I've tested some locally, but I don't know if the CI bot is configured correctly.
Related details
Attention is currently required from:
- Martin Kustermann
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Simon Binder (Gerrit)
Mar 7, 2026, 2:35:26 PM (3 days ago) Mar 7
to Commit Queue, Kevin Moore, Martin Kustermann, dart-fe-te...@google.com, dart-uxr...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Martin Kustermann
Simon Binder added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Simon Binder . unresolved
I've removed the shell (d8, jsc, jsshell) tests to avoid having to specify runtime definitions twice.
Also it looks like the `dart2wasm-linux-standalone-chrome` builder wasn't part of the initial CQ dryrun, but I don't know what configuration might be missing for that.
Related details
Attention is currently required from:
- Martin Kustermann
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages