[XS] Change in dart/sdk[main]: [co19] Roll co19 to 37c5e43f9cc4ebc67422cc5c27cf2b84919a5a71

0 views
Skip to first unread message

Sergey Grekhov (Gerrit)

unread,
Nov 28, 2025, 2:36:42 AM (yesterday) Nov 28
to Alexander Thomas, Erik Ernst, rev...@dartlang.org
Attention needed from Alexander Thomas and Erik Ernst

Sergey Grekhov has uploaded the change for review

Sergey Grekhov would like Alexander Thomas and Erik Ernst to review this change.

Commit message

[co19] Roll co19 to 37c5e43f9cc4ebc67422cc5c27cf2b84919a5a71

2025-11-27 sgrek...@gmail.com dart-lang/co19#3182. Update augmenting_constructors_A11-18* tests (dart-lang/co19#3417)
2025-11-27 sgrek...@gmail.com dart-lang/co19#3182. Update `augmenting_declarations_*` tests (dart-lang/co19#3420)
2025-11-27 sgrek...@gmail.com dart-lang/co19#3182. Add more tests for constructors augmentation (dart-lang/co19#3419)
2025-11-26 sgrek...@gmail.com dart-lang/co19#3182. Rename some test for constructors (dart-lang/co19#3416)
2025-11-25 sgrek...@gmail.com dart-lang/co19#3182. Update augmenting_constructors_A09* tests (dart-lang/co19#3415)
2025-11-25 sgrek...@gmail.com dart-lang/co19#3182. Update augmenting_constructors_A02-04* tests (dart-lang/co19#3413)
2025-11-25 sgrek...@gmail.com dart-lang/co19#3182. Update augmenting_constructors_A05-08* tests (dart-lang/co19#3414)
2025-11-24 sgrek...@gmail.com dart-lang/co19#3182. Rename `Augmentation-libraries` to `Augmentations` (dart-lang/co19#3412)

R=at...@google.com, eer...@google.com
Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try
Change-Id: I519a4047d44d997ebddfd44e9214bfb463ebba7d

Change information

Files:
  • M DEPS
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Thomas
  • Erik Ernst
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I519a4047d44d997ebddfd44e9214bfb463ebba7d
Gerrit-Change-Number: 465020
Gerrit-PatchSet: 1
Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Reviewer: Alexander Thomas <at...@google.com>
Gerrit-Reviewer: Erik Ernst <eer...@google.com>
Gerrit-Reviewer: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Attention: Alexander Thomas <at...@google.com>
Gerrit-Attention: Erik Ernst <eer...@google.com>
unsatisfied_requirement
open
diffy

Erik Ernst (Gerrit)

unread,
Nov 28, 2025, 3:17:39 AM (yesterday) Nov 28
to Sergey Grekhov, Commit Queue, Alexander Thomas, rev...@dartlang.org
Attention needed from Sergey Grekhov

Erik Ernst voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Sergey Grekhov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I519a4047d44d997ebddfd44e9214bfb463ebba7d
Gerrit-Change-Number: 465020
Gerrit-PatchSet: 1
Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Reviewer: Alexander Thomas <at...@google.com>
Gerrit-Reviewer: Erik Ernst <eer...@google.com>
Gerrit-Reviewer: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Attention: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Comment-Date: Fri, 28 Nov 2025 08:17:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Sergey Grekhov (Gerrit)

unread,
Nov 28, 2025, 4:06:34 AM (yesterday) Nov 28
to Erik Ernst, Commit Queue, Alexander Thomas, rev...@dartlang.org
Attention needed from Erik Ernst

Sergey Grekhov added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Sergey Grekhov . resolved

Can be landed. All failures are related to Augmentations. This feature is not implemented yet.

Open in Gerrit

Related details

Attention is currently required from:
  • Erik Ernst
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I519a4047d44d997ebddfd44e9214bfb463ebba7d
Gerrit-Change-Number: 465020
Gerrit-PatchSet: 1
Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Reviewer: Alexander Thomas <at...@google.com>
Gerrit-Reviewer: Erik Ernst <eer...@google.com>
Gerrit-Reviewer: Sergey Grekhov <sgrek...@gmail.com>
Gerrit-Attention: Erik Ernst <eer...@google.com>
Gerrit-Comment-Date: Fri, 28 Nov 2025 09:06:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Alexander Thomas (Gerrit)

unread,
Nov 28, 2025, 5:24:18 AM (yesterday) Nov 28
to Sergey Grekhov, Erik Ernst, Commit Queue, rev...@dartlang.org
Attention needed from Sergey Grekhov

Alexander Thomas voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Sergey Grekhov
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I519a4047d44d997ebddfd44e9214bfb463ebba7d
    Gerrit-Change-Number: 465020
    Gerrit-PatchSet: 1
    Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
    Gerrit-Reviewer: Alexander Thomas <at...@google.com>
    Gerrit-Reviewer: Erik Ernst <eer...@google.com>
    Gerrit-Reviewer: Sergey Grekhov <sgrek...@gmail.com>
    Gerrit-Attention: Sergey Grekhov <sgrek...@gmail.com>
    Gerrit-Comment-Date: Fri, 28 Nov 2025 10:24:12 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Commit Queue (Gerrit)

    unread,
    Nov 28, 2025, 5:54:56 AM (yesterday) Nov 28
    to Sergey Grekhov, Alexander Thomas, Erik Ernst, rev...@dartlang.org

    Commit Queue submitted the change

    Change information

    Commit message:
    [co19] Roll co19 to 37c5e43f9cc4ebc67422cc5c27cf2b84919a5a71

    2025-11-27 sgrek...@gmail.com dart-lang/co19#3182. Update augmenting_constructors_A11-18* tests (dart-lang/co19#3417)
    2025-11-27 sgrek...@gmail.com dart-lang/co19#3182. Update `augmenting_declarations_*` tests (dart-lang/co19#3420)
    2025-11-27 sgrek...@gmail.com dart-lang/co19#3182. Add more tests for constructors augmentation (dart-lang/co19#3419)
    2025-11-26 sgrek...@gmail.com dart-lang/co19#3182. Rename some test for constructors (dart-lang/co19#3416)
    2025-11-25 sgrek...@gmail.com dart-lang/co19#3182. Update augmenting_constructors_A09* tests (dart-lang/co19#3415)
    2025-11-25 sgrek...@gmail.com dart-lang/co19#3182. Update augmenting_constructors_A02-04* tests (dart-lang/co19#3413)
    2025-11-25 sgrek...@gmail.com dart-lang/co19#3182. Update augmenting_constructors_A05-08* tests (dart-lang/co19#3414)
    2025-11-24 sgrek...@gmail.com dart-lang/co19#3182. Rename `Augmentation-libraries` to `Augmentations` (dart-lang/co19#3412)

    R=at...@google.com, eer...@google.com
    Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try,dart2js-minified-linux-d8-try
    Change-Id: I519a4047d44d997ebddfd44e9214bfb463ebba7d
    Commit-Queue: Alexander Thomas <at...@google.com>
    Commit-Queue: Erik Ernst <eer...@google.com>
    Auto-Submit: Sergey Grekhov <sgrek...@gmail.com>
    Reviewed-by: Alexander Thomas <at...@google.com>
    Reviewed-by: Erik Ernst <eer...@google.com>
    Files:
    • M DEPS
    Change size: XS
    Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Alexander Thomas, +1 by Erik Ernst
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I519a4047d44d997ebddfd44e9214bfb463ebba7d
    Gerrit-Change-Number: 465020
    Gerrit-PatchSet: 2
    Gerrit-Owner: Sergey Grekhov <sgrek...@gmail.com>
    Gerrit-Reviewer: Alexander Thomas <at...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages