[M] Change in dart/sdk[main]: [DAS] Fixes `Create (extension) method` for unresolved closure return...
0 views
Skip to first unread message
Felipe Morschel (Gerrit)
Nov 4, 2025, 11:42:41 AM11/4/25
to dart-analys...@google.com, rev...@dartlang.org
Felipe Morschel has uploaded the change for review![]( "Open in Gerrit")
Commit message
[DAS] Fixes `Create (extension) method` for unresolved closure return type
Change-Id: I0b1e7ad208a54a04f0ff4147f27403845f9a379d
Change information
Files:
- M pkg/analysis_server/lib/src/services/correction/dart/create_extension_member.dart
- M pkg/analysis_server/lib/src/services/correction/dart/create_method.dart
- M pkg/analysis_server/test/src/services/correction/fix/create_extension_member_test.dart
- M pkg/analysis_server/test/src/services/correction/fix/create_method_test.dart
- M pkg/analysis_server_plugin/lib/edit/dart/correction_producer.dart
Change size: M
Delta: 5 files changed, 55 insertions(+), 3 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Morschel (Gerrit)
Dec 5, 2025, 5:09:31 PM12/5/25
to Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Samuel Rawlins
Felipe Morschel added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Brian Wilkerson
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Dec 5, 2025, 5:34:49 PM12/5/25
to Felipe Morschel, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Felipe Morschel
Samuel Rawlins voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Brian Wilkerson
- Felipe Morschel
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Morschel (Gerrit)
Dec 8, 2025, 9:38:04 AM12/8/25
to Commit Queue, Samuel Rawlins, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Samuel Rawlins
Felipe Morschel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Felipe Morschel
| Auto-Submit | +1 |
Felipe Morschel
Rebased and fixed the broken bots. Thanks!
If possible, I'd like to land this one before https://dart-review.googlesource.com/c/sdk/+/466760, since this one is smaller.
That one better handles type arguments in create function/method/operator fixes.
Related details
Attention is currently required from:
- Brian Wilkerson
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Dec 8, 2025, 11:32:49 PM12/8/25
to Felipe Morschel, Commit Queue, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Felipe Morschel
Samuel Rawlins voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Brian Wilkerson
- Felipe Morschel
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Felipe Morschel (Gerrit)
Dec 9, 2025, 12:40:47 AM12/9/25
to Samuel Rawlins, Commit Queue, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Samuel Rawlins
Felipe Morschel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Felipe Morschel
| Auto-Submit | +1 |
Felipe Morschel . unresolved
Felipe MorschelFriendly ping @brianwi...@google.com @sraw...@google.com
Rebased and fixed the broken bots. Thanks!
If possible, I'd like to land this one before https://dart-review.googlesource.com/c/sdk/+/466760, since this one is smaller.
That one better handles type arguments in create function/method/operator fixes.
Felipe Morschel
My last change showed a flaw in how we were writing function types. I've fixed that too. Thanks for the new bots. Everything should be fine now!
Related details
Attention is currently required from:
- Brian Wilkerson
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Dec 10, 2025, 10:43:30 AM12/10/25
to Felipe Morschel, Commit Queue, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Felipe Morschel
Samuel Rawlins voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Brian Wilkerson
- Felipe Morschel
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Dec 10, 2025, 1:40:04 PM12/10/25
to Felipe Morschel, Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[DAS] Fixes `Create (extension) method` for unresolved closure return type
Change-Id: I0b1e7ad208a54a04f0ff4147f27403845f9a379d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/459521
Reviewed-by: Samuel Rawlins <sraw...@google.com>
Auto-Submit: Felipe Morschel <g...@fmorschel.dev>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Brian Wilkerson <brianwi...@google.com>
Files:
- M pkg/analysis_server/lib/src/services/correction/dart/create_extension_member.dart
- M pkg/analysis_server/lib/src/services/correction/dart/create_method.dart
- M pkg/analysis_server/lib/src/services/correction/dart/create_method_or_function.dart
- M pkg/analysis_server/test/src/services/correction/fix/create_extension_member_test.dart
- M pkg/analysis_server/test/src/services/correction/fix/create_method_test.dart
- M pkg/analysis_server_plugin/lib/edit/dart/correction_producer.dart
- M pkg/analyzer_plugin/lib/src/utilities/change_builder/change_builder_dart.dart
Change size: M
Delta: 7 files changed, 67 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brian Wilkerson, +1 by Samuel Rawlins
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages