[M] Change in dart/sdk[main]: This change introduces the _findWorkspaceRoot method to locate a proj...

0 views

Skip to first unread message

Ben Konyi (Gerrit)

unread,

Mar 20, 2026, 2:40:39 PM (10 days ago) Mar 20

to Jaime Wren, Commit Queue, rev...@dartlang.org

Attention needed from Jaime Wren

Ben Konyi added 1 comment

File pkg/dtd_impl/lib/src/dart_tooling_daemon.dart

Line 476, Patchset 1 (Latest): File(p.join(current.path, 'pubspec.yaml')).existsSync()) {

Ben Konyi . unresolved

I don't think this is correct in the context of Pub workspaces. If I'm not mistaken, we should be looking for the `.dart_tool` directory.

Open in Gerrit

Related details

Attention is currently required from:

Jaime Wren

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Brian Wilkerson (Gerrit)

unread,

Mar 20, 2026, 2:44:07 PM (10 days ago) Mar 20

to Jaime Wren, Brian Wilkerson, Ben Konyi, Commit Queue, rev...@dartlang.org

Attention needed from Jaime Wren

Brian Wilkerson added 1 comment

File pkg/dtd_impl/lib/src/dart_tooling_daemon.dart

Line 476, Patchset 1 (Latest): File(p.join(current.path, 'pubspec.yaml')).existsSync()) {

Ben Konyi . unresolved

I don't think this is correct in the context of Pub workspaces. If I'm not mistaken, we should be looking for the `.dart_tool` directory.

Brian Wilkerson

Or more specifically, the `package_config.json` file inside it. I'm not aware of any rule against having a `.dart_tool` directory somewhere under the root of the workspace / package.

Open in Gerrit

Related details

Attention is currently required from:

Jaime Wren

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jaime Wren (Gerrit)

unread,

6:12 PM (2 hours ago) 6:12 PM

to Brian Wilkerson, Ben Konyi, Commit Queue, rev...@dartlang.org

Jaime Wren abandoned this change.

View Change

Abandoned

Jaime Wren abandoned this change

Related details

Attention set is empty

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages