[M] Change in dart/sdk[main]: [vm,dyn_modules] Rename DebugCheck to Noop and use after debugger() c...
0 views
Skip to first unread message
Tess Strickland (Gerrit)
Feb 12, 2026, 7:12:47 AM (6 days ago) Feb 12
to Alexander Markov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Alexander Markov
Tess Strickland added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Tess Strickland . resolved
Pulling out the Noop rename and the use after debugger() into its own CL as I continue working on the other thing I'm chasing down.
Related details
Attention is currently required from:
- Alexander Markov
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
10:59 AM (10 hours ago) 10:59 AM
to Tess Strickland, Alexander Markov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Tess Strickland
Alexander Markov voted and added 3 comments![]( "Open in Gerrit")
Votes added by Alexander Markov
| Code-Review | +1 |
3 comments
File pkg/dart2bytecode/lib/bytecode_generator.dart
Line 152, Patchset 1 (Latest):
Set<Library> get allLibraries => _allLibraries == null
? _allLibraries = {...libraries, ...extraLoadedLibraries}
: _allLibraries!;Alexander Markov . unresolved
Nit: `=> (_allLibraries ??= {...libraries, ...extraLoadedLibraries});`
File pkg/dart2bytecode/lib/dbc.dart
Line 28, Patchset 1 (Latest):
kNoop,Alexander Markov . unresolved
Nit: `Nop` is a more standard name for the "no operation" instruction.
Also, please update pkg/dart2bytecode/docs/bytecode.md.
File runtime/vm/constants_kbc.h
Line 54, Patchset 1 (Latest):
/* single stepping, Noop is effectively the same and so reuses the id. */ \Alexander Markov . unresolved
Nit: we don't really need to leave this historical comment here as it doesn't explain the current code. This explanation can be a part of the CL description if you'd like.
Related details
Attention is currently required from:
- Tess Strickland
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Markov (Gerrit)
11:06 AM (9 hours ago) 11:06 AM
to Tess Strickland, Alexander Markov, Commit Queue, rev...@dartlang.org, vm-...@dartlang.org
Attention needed from Tess Strickland
Alexander Markov added 1 comment![]( "Open in Gerrit")
File pkg/dart2bytecode/lib/bytecode_generator.dart
Line 152, Patchset 1 (Latest):
Set<Library> get allLibraries => _allLibraries == null
? _allLibraries = {...libraries, ...extraLoadedLibraries}
: _allLibraries!;Alexander Markov . unresolved
Nit: `=> (_allLibraries ??= {...libraries, ...extraLoadedLibraries});`
Alexander Markov
Actually, `_allLibraries` field and `allLibraries` getter can be replaced with a
```
late final Set<Library> allLibraries = {...libraries, ...extraLoadedLibraries};
```
Related details
Attention is currently required from:
- Tess Strickland
Submit Requirements:
Code-Owners
Code-Review
Commit-Message-Has-TEST
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages