[M] Change in dart/sdk[main]: [dart2bytecode] Add test for prefixed duplicate libraries
Sigmund Cherem (Gerrit)
Sigmund Cherem voted and added 2 comments![]( "Open in Gerrit")
Votes added by Sigmund Cherem
| Code-Review | +1 |
2 comments
await helper.load('entry1.dart');since the value you are creating in both entry1 and entry2 is a constant, it will also show one of the nuances of doing import rewrites: the two constants are no longer the same, since each `common.dart` copy is unique.
Consider adding an expectation check here about that? For example:
```
final a1 = await.load('entry1.dart');
final a2 = await.load('entry2.dart');
Expect.notEquals(a1, a2);
Expect.notEquals(a1.runtimeType, a2.runtimeType);
helper.done();
```
if (test.name.endsWith('_prefixed'))(optional) now that we have this, I'm torn about whether to still pass a prefix all the time. It is not harmful, so I guess it's OK, but may be confusing.
The alternative would be to move the flag under this condition too:
```
if (test.name.endsWith('_prefixed'))
...[
'--prefix-library-uris',
name
],
```
Related details
- Ivan Inozemtsev
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ivan Inozemtsev (Gerrit)
Ivan Inozemtsev added 2 comments![]( "Open in Gerrit")
since the value you are creating in both entry1 and entry2 is a constant, it will also show one of the nuances of doing import rewrites: the two constants are no longer the same, since each `common.dart` copy is unique.
Consider adding an expectation check here about that? For example:
```
final a1 = await.load('entry1.dart');
final a2 = await.load('entry2.dart');
Expect.notEquals(a1, a2);
Expect.notEquals(a1.runtimeType, a2.runtimeType);
helper.done();
```
Great suggestion! Done.
(optional) now that we have this, I'm torn about whether to still pass a prefix all the time. It is not harmful, so I guess it's OK, but may be confusing.
The alternative would be to move the flag under this condition too:
```
if (test.name.endsWith('_prefixed'))
...[
'--prefix-library-uris',
name
],
```
I think "constant" prefixing is still beneficial to check that uri rewriting works correctly, but I've changed this to make args closer to each other
Related details
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ivan Inozemtsev (Gerrit)
Ivan Inozemtsev voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Commit Queue submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: pkg/dynamic_modules/test/data/duplicate_library_prefixed/main.dart
Insertions: 5, Deletions: 2.
The diff is too large to show. Please review the diff.
```
```
The name of the file: pkg/dynamic_modules/test/runner/vm.dart
Insertions: 9, Deletions: 5.
The diff is too large to show. Please review the diff.
```
Change information
[dart2bytecode] Add test for prefixed duplicate libraries
- A pkg/dynamic_modules/test/data/duplicate_library_prefixed/dynamic_interface.yaml
- A pkg/dynamic_modules/test/data/duplicate_library_prefixed/main.dart
- A pkg/dynamic_modules/test/data/duplicate_library_prefixed/modules/common.dart
- A pkg/dynamic_modules/test/data/duplicate_library_prefixed/modules/entry1.dart
- A pkg/dynamic_modules/test/data/duplicate_library_prefixed/modules/entry2.dart
- M pkg/dynamic_modules/test/runner/vm.dart
Code-Review: +1 by Sigmund Cherem
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |