[XL] Change in dart/sdk[main]: Revert "CQ. Use List<Token> tokens in DottedName, using it for Librar...
0 views
Skip to first unread message
Brian Wilkerson (Gerrit)
Mar 13, 2026, 2:13:46 PMMar 13
to Konstantin Shcheglov, Brian Wilkerson, Paul Berry, Johnni Winther, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther, Konstantin Shcheglov and Paul Berry
Brian Wilkerson voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Johnni Winther
- Konstantin Shcheglov
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Berry (Gerrit)
Mar 13, 2026, 2:27:08 PMMar 13
to Konstantin Shcheglov, Brian Wilkerson, Johnni Winther, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther and Konstantin Shcheglov
Paul Berry voted and added 1 comment![]( "Open in Gerrit")
Votes added by Paul Berry
| Code-Review | +1 |
Related details
Attention is currently required from:
- Johnni Winther
- Konstantin Shcheglov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Mar 13, 2026, 2:27:22 PMMar 13
to Paul Berry, Brian Wilkerson, Johnni Winther, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther
Konstantin Shcheglov voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Johnni Winther
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Mar 13, 2026, 2:27:35 PMMar 13
to Konstantin Shcheglov, Paul Berry, Brian Wilkerson, Johnni Winther, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "CQ. Use List<Token> tokens in DottedName, using it for LibraryDirective and PartOfDirective."
This reverts commit 44993f75706c62fa9a1dbb84d5ccec63acb8120c.
I still would like to do this refactoring, but as in-place breaking
change.
Change-Id: I40c355720fc5ffa423fecb90007dc771e46a10cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/487884
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Reviewed-by: Paul Berry <paul...@google.com>
Files:
- M pkg/analyzer/CHANGELOG.md
- M pkg/analyzer/api.txt
- M pkg/analyzer/lib/dart/ast/ast.dart
- M pkg/analyzer/lib/src/dart/analysis/file_state.dart
- M pkg/analyzer/lib/src/dart/ast/ast.dart
- M pkg/analyzer/lib/src/fasta/ast_builder.dart
- M pkg/analyzer/lib/src/generated/resolver.dart
- M pkg/analyzer/lib/src/summary2/ast_binary_reader.dart
- M pkg/analyzer/lib/src/summary2/informative_data.dart
- M pkg/analyzer/lib/src/summary2/library_builder.dart
- M pkg/analyzer/test/src/dart/resolution/library_directive_test.dart
- M pkg/analyzer/test/src/dart/resolution/library_export_test.dart
- M pkg/analyzer/test/src/dart/resolution/library_import_test.dart
- M pkg/analyzer/test/src/dart/resolution/part_test.dart
- M pkg/analyzer/tool/generators/ast_generator.dart
Change size: XL
Delta: 15 files changed, 151 insertions(+), 1512 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brian Wilkerson, +1 by Paul Berry
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages