[XS] Change in dart/sdk[main]: Roll dart_style into the SDK.

0 views
Skip to first unread message

Bob Nystrom (Gerrit)

unread,
Aug 8, 2025, 8:16:51 PM8/8/25
to Alexander Thomas, Jens Johansen, rev...@dartlang.org
Attention needed from Alexander Thomas

Bob Nystrom voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Thomas
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: If6ef15de45edee9b94afde5f5609b6650647798d
Gerrit-Change-Number: 444371
Gerrit-PatchSet: 1
Gerrit-Owner: Bob Nystrom <rnys...@google.com>
Gerrit-Reviewer: Alexander Thomas <at...@google.com>
Gerrit-Reviewer: Bob Nystrom <rnys...@google.com>
Gerrit-CC: Jens Johansen <je...@google.com>
Gerrit-Attention: Alexander Thomas <at...@google.com>
Gerrit-Comment-Date: Sat, 09 Aug 2025 00:16:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Alexander Thomas (Gerrit)

unread,
Aug 11, 2025, 3:01:14 AM8/11/25
to Bob Nystrom, Commit Queue, Jens Johansen, rev...@dartlang.org
Attention needed from Bob Nystrom

Alexander Thomas voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Bob Nystrom
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: If6ef15de45edee9b94afde5f5609b6650647798d
Gerrit-Change-Number: 444371
Gerrit-PatchSet: 1
Gerrit-Owner: Bob Nystrom <rnys...@google.com>
Gerrit-Reviewer: Alexander Thomas <at...@google.com>
Gerrit-Reviewer: Bob Nystrom <rnys...@google.com>
Gerrit-CC: Jens Johansen <je...@google.com>
Gerrit-Attention: Bob Nystrom <rnys...@google.com>
Gerrit-Comment-Date: Mon, 11 Aug 2025 07:01:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Aug 11, 2025, 3:44:52 AM8/11/25
to Bob Nystrom, Alexander Thomas, Jens Johansen, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
Roll dart_style into the SDK.

This only has two small changes:

- Remove tests of invalid syntax which will no longer be accepted by
  the parser soon: https://github.com/dart-lang/dart_style/pull/1758

- Don't insert a space between `?` and `.` in one corner of the grammar
  because the parser will handle it correctly without a space.

Nothing in the SDK should be affected by this.
Change-Id: If6ef15de45edee9b94afde5f5609b6650647798d
Commit-Queue: Alexander Thomas <at...@google.com>
Auto-Submit: Bob Nystrom <rnys...@google.com>
Reviewed-by: Alexander Thomas <at...@google.com>
Files:
  • M DEPS
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Alexander Thomas
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: If6ef15de45edee9b94afde5f5609b6650647798d
Gerrit-Change-Number: 444371
Gerrit-PatchSet: 2
Gerrit-Owner: Bob Nystrom <rnys...@google.com>
Gerrit-Reviewer: Alexander Thomas <at...@google.com>
Gerrit-Reviewer: Bob Nystrom <rnys...@google.com>
Gerrit-CC: Jens Johansen <je...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages