[XL] Change in dart/sdk[main]: [dart2wasm] Interfaces for accessing memories

0 views

Skip to first unread message

Simon Binder (Gerrit)

unread,

Dec 29, 2025, 7:50:57 AM (2 days ago) Dec 29

to Nate Biggs, dart-fe-te...@google.com, dart-uxr...@google.com, dart2js-te...@google.com, dart2wasm-t...@google.com, rev...@dartlang.org

Attention needed from Nate Biggs

Simon Binder added 2 comments

File sdk/lib/wasm/wasm.dart

Line 114, Patchset 2: external int loadFloat32(int address, {int align = 0, int offset = 0});

Simon Binder . unresolved

I've adopted this documentation comment from the `ByteData` class. I can adopt it for the other methods as well once we know that the API is what we want.

File tests/web/wasm/externs_assert_error_test.dart

Line 9, Patchset 2:// [cfe] This external getter returns a memory instance, but no annotation describing it was found

Simon Binder . unresolved

I couldn't find a configuration to run this CFE test, could someone please help me with that? I'm not that familiar with the test infrastructure of the SDK, does this need to be in another directory?

Open in Gerrit

Related details

Attention is currently required from:

Nate Biggs

Submit Requirements:

Code-Owners
Code-Review
Core-Library-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages