[S] Change in dart/sdk[main]: [analysis_server] Update comments explaining placeholders outside of ...

0 views
Skip to first unread message

Brian Wilkerson (Gerrit)

unread,
10:33 AM (8 hours ago) 10:33 AM
to Danny Tuppeny, Brian Wilkerson, Keerti Parthasarathy, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Danny Tuppeny and Keerti Parthasarathy

Brian Wilkerson voted

Code-Review+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Danny Tuppeny
  • Keerti Parthasarathy
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I7061d6364086c504916746a8fbbcebebc7abd5a3
Gerrit-Change-Number: 531620
Gerrit-PatchSet: 1
Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
Gerrit-Attention: Danny Tuppeny <da...@tuppeny.com>
Gerrit-Attention: Keerti Parthasarathy <kee...@google.com>
Gerrit-Comment-Date: Wed, 05 Aug 2026 14:33:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Keerti Parthasarathy (Gerrit)

unread,
1:51 PM (5 hours ago) 1:51 PM
to Danny Tuppeny, dart-...@luci-project-accounts.iam.gserviceaccount.com, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Danny Tuppeny

Keerti Parthasarathy voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
  • Danny Tuppeny
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I7061d6364086c504916746a8fbbcebebc7abd5a3
    Gerrit-Change-Number: 531620
    Gerrit-PatchSet: 1
    Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
    Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Attention: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Comment-Date: Wed, 05 Aug 2026 17:51:11 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Keerti Parthasarathy (Gerrit)

    unread,
    1:51 PM (5 hours ago) 1:51 PM
    to Danny Tuppeny, dart-...@luci-project-accounts.iam.gserviceaccount.com, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Brian Wilkerson and Danny Tuppeny

    Keerti Parthasarathy voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Brian Wilkerson
    • Danny Tuppeny
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I7061d6364086c504916746a8fbbcebebc7abd5a3
    Gerrit-Change-Number: 531620
    Gerrit-PatchSet: 1
    Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
    Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Attention: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Comment-Date: Wed, 05 Aug 2026 17:51:18 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

    unread,
    1:51 PM (5 hours ago) 1:51 PM
    to Danny Tuppeny, Keerti Parthasarathy, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org

    dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change

    Change information

    Commit message:
    [analysis_server] Update comments explaining placeholders outside of LSP snippet text edits

    This improves a comment that explains what was found while investigating https://github.com/dart-lang/sdk/issues/63824, and also removes a TODO comment that was answered in a review (and concluded there's nothing to do).
    Change-Id: I7061d6364086c504916746a8fbbcebebc7abd5a3
    Reviewed-by: Keerti Parthasarathy <kee...@google.com>
    Reviewed-by: Brian Wilkerson <brianwi...@google.com>
    Commit-Queue: Keerti Parthasarathy <kee...@google.com>
    Files:
    • M pkg/analysis_server/lib/src/lsp/snippets.dart
    • M pkg/dartdev/lib/src/lsp_analysis_server.dart
    Change size: S
    Delta: 2 files changed, 17 insertions(+), 5 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Brian Wilkerson, +1 by Keerti Parthasarathy
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I7061d6364086c504916746a8fbbcebebc7abd5a3
    Gerrit-Change-Number: 531620
    Gerrit-PatchSet: 2
    Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages