[XL] Change in dart/sdk[main]: Do not report missingFunctionBody when augmentation flag is set.

0 views
Skip to first unread message

Konstantin Shcheglov (Gerrit)

unread,
Mar 28, 2026, 7:45:05 PM (2 days ago) Mar 28
to Fedor Shcheglov, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov

Konstantin Shcheglov added 14 comments

File pkg/_fe_analyzer_shared/lib/src/parser/parser_impl.dart
Line 4470, Patchset 4 (Latest): (isExternal || _isAugmentationsFeatureEnabled) && inPlainSync,
Konstantin Shcheglov . unresolved

Why `inPlainSync`?

File pkg/analyzer/test/generated/error_parser_test.dart
Line 845, Patchset 4 (Latest): void test_emptyFunctionBody_language35() {
Konstantin Shcheglov . unresolved

Lets use `language305`

Line 3382, Patchset 4 (Latest): void test_TopLevelSetter_emptyBody() {
Konstantin Shcheglov . unresolved

`_top`, don't capitalize

Line 3436, Patchset 4 (Latest): void test_Typedef_emptyBody() {
Konstantin Shcheglov . unresolved

I don't understand why we get these two tests.

File pkg/analyzer/test/generated/expression_parser_test.dart
Line 3931, Patchset 4 (Latest): void test_parseStringLiteral_interpolated_void_language35() {
Konstantin Shcheglov . unresolved

This was weird test.
We don't need its another version, just keep default, and remove this.

File pkg/analyzer/test/generated/simple_parser_test.dart
Line 2036, Patchset 4 (Latest): void test_parseLibraryIdentifier_invalid_language35() {
Konstantin Shcheglov . unresolved

Also weird, no need for copy.

File pkg/analyzer/test/src/dart/parser/class_test.dart
Line 1512, Patchset 4 (Latest): test_method_static_body_empty_language305() {
Konstantin Shcheglov . resolved

Good!

File pkg/analyzer/test/src/dart/parser/top_level_function_test.dart
Line 6, Patchset 4 (Latest):import 'package:pub_semver/pub_semver.dart';
Konstantin Shcheglov . unresolved

Why?

Line 45, Patchset 4 (Latest):int foo();
Konstantin Shcheglov . unresolved

void

Line 64, Patchset 4 (Latest): test_function_body_empty_language310() {
Konstantin Shcheglov . unresolved

???

File pkg/analyzer/test/src/dart/resolution/prefixed_identifier_test.dart
Line 629, Patchset 4 (Latest): A.foo;
Konstantin Shcheglov . unresolved

remove

File pkg/analyzer/test/src/fasta/recovery/invalid_code_test.dart
Line 378, Patchset 4 (Latest): void test_const_mistyped_language35() {
Konstantin Shcheglov . unresolved

Weird, remove.

File pkg/analyzer/test/src/fasta/recovery/partial_code/annotation_test.dart
Line 2395, Patchset 4 (Latest): void test_annotation_topLevel_ampersand_typedef_language35() {
Konstantin Shcheglov . unresolved

Weird, remove.

File pkg/analyzer/test/src/fasta/recovery/partial_code/enum_declaration_test.dart
Line 434, Patchset 4 (Latest): void test_enum_declaration_comma_typedef_language35() {
Konstantin Shcheglov . unresolved

Weird, remove.
Similarly for other recovery code.

Open in Gerrit

Related details

Attention is currently required from:
  • Fedor Shcheglov
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I0b46392521701ec3846830a9adc04487c7a8541b
Gerrit-Change-Number: 491440
Gerrit-PatchSet: 4
Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-CC: Paul Berry <paul...@google.com>
Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Comment-Date: Sat, 28 Mar 2026 23:45:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Fedor Shcheglov (Gerrit)

unread,
Mar 28, 2026, 8:43:30 PM (2 days ago) Mar 28
to Konstantin Shcheglov, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov

Fedor Shcheglov added 13 comments

File pkg/_fe_analyzer_shared/lib/src/parser/parser_impl.dart
Line 4470, Patchset 4: (isExternal || _isAugmentationsFeatureEnabled) && inPlainSync,
Konstantin Shcheglov . resolved

Why `inPlainSync`?

Fedor Shcheglov

Done

File pkg/analyzer/test/generated/error_parser_test.dart
Line 845, Patchset 4: void test_emptyFunctionBody_language35() {
Konstantin Shcheglov . resolved

Lets use `language305`

Fedor Shcheglov

Done

Line 3382, Patchset 4: void test_TopLevelSetter_emptyBody() {
Konstantin Shcheglov . resolved

`_top`, don't capitalize

Fedor Shcheglov

Done

Line 3436, Patchset 4: void test_Typedef_emptyBody() {
Konstantin Shcheglov . resolved

I don't understand why we get these two tests.

Fedor Shcheglov

Done

File pkg/analyzer/test/generated/expression_parser_test.dart
Line 3931, Patchset 4: void test_parseStringLiteral_interpolated_void_language35() {
Konstantin Shcheglov . resolved

This was weird test.
We don't need its another version, just keep default, and remove this.

Fedor Shcheglov

Done

File pkg/analyzer/test/generated/simple_parser_test.dart
Line 2036, Patchset 4: void test_parseLibraryIdentifier_invalid_language35() {
Konstantin Shcheglov . resolved

Also weird, no need for copy.

Fedor Shcheglov

Done

File pkg/analyzer/test/src/dart/parser/top_level_function_test.dart
Line 6, Patchset 4:import 'package:pub_semver/pub_semver.dart';
Konstantin Shcheglov . resolved

Why?

Fedor Shcheglov

Done

Line 45, Patchset 4:int foo();
Konstantin Shcheglov . resolved

void

Fedor Shcheglov

Done

Line 64, Patchset 4: test_function_body_empty_language310() {
Konstantin Shcheglov . resolved

???

Fedor Shcheglov

Done

File pkg/analyzer/test/src/dart/resolution/prefixed_identifier_test.dart
Line 629, Patchset 4: A.foo;
Konstantin Shcheglov . resolved

remove

Fedor Shcheglov

Done

File pkg/analyzer/test/src/fasta/recovery/invalid_code_test.dart
Line 378, Patchset 4: void test_const_mistyped_language35() {
Konstantin Shcheglov . resolved

Weird, remove.

Fedor Shcheglov

Done

File pkg/analyzer/test/src/fasta/recovery/partial_code/annotation_test.dart
Line 2395, Patchset 4: void test_annotation_topLevel_ampersand_typedef_language35() {
Konstantin Shcheglov . resolved

Weird, remove.

Fedor Shcheglov

Done

File pkg/analyzer/test/src/fasta/recovery/partial_code/enum_declaration_test.dart
Line 434, Patchset 4: void test_enum_declaration_comma_typedef_language35() {
Konstantin Shcheglov . resolved

Weird, remove.
Similarly for other recovery code.

Fedor Shcheglov

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Konstantin Shcheglov
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I0b46392521701ec3846830a9adc04487c7a8541b
Gerrit-Change-Number: 491440
Gerrit-PatchSet: 5
Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-CC: Paul Berry <paul...@google.com>
Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
Gerrit-Comment-Date: Sun, 29 Mar 2026 00:43:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Konstantin Shcheglov <sche...@google.com>
unsatisfied_requirement
open
diffy

Konstantin Shcheglov (Gerrit)

unread,
Mar 28, 2026, 9:02:24 PM (2 days ago) Mar 28
to Fedor Shcheglov, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov

Konstantin Shcheglov added 3 comments

File pkg/analyzer/test/generated/error_parser_test.dart
Line 2014, Patchset 5 (Parent): void test_invalidTopLevelSetter() {
Konstantin Shcheglov . unresolved

These were good, just remove missing function body expectation.

Line 3143, Patchset 5: void test_staticGetterWithoutBody_language305() {
Konstantin Shcheglov . unresolved

When you add gette eith empty body, we don't need this.

File pkg/analyzer/test/generated/simple_parser_test.dart
Line 1512, Patchset 5: var node =
Konstantin Shcheglov . unresolved

Easier the whole unit.

Open in Gerrit

Related details

Attention is currently required from:
  • Fedor Shcheglov
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I0b46392521701ec3846830a9adc04487c7a8541b
Gerrit-Change-Number: 491440
Gerrit-PatchSet: 5
Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-CC: Paul Berry <paul...@google.com>
Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Comment-Date: Sun, 29 Mar 2026 01:02:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Fedor Shcheglov (Gerrit)

unread,
Mar 28, 2026, 9:37:33 PM (2 days ago) Mar 28
to Konstantin Shcheglov, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov

Fedor Shcheglov added 3 comments

File pkg/analyzer/test/generated/error_parser_test.dart
Line 2014, Patchset 5 (Parent): void test_invalidTopLevelSetter() {
Konstantin Shcheglov . resolved

These were good, just remove missing function body expectation.

Fedor Shcheglov

Done

Line 3143, Patchset 5: void test_staticGetterWithoutBody_language305() {
Konstantin Shcheglov . resolved

When you add gette eith empty body, we don't need this.

Fedor Shcheglov

Done

File pkg/analyzer/test/generated/simple_parser_test.dart
Konstantin Shcheglov . resolved

Easier the whole unit.

Fedor Shcheglov

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Konstantin Shcheglov
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I0b46392521701ec3846830a9adc04487c7a8541b
Gerrit-Change-Number: 491440
Gerrit-PatchSet: 8
Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-CC: Paul Berry <paul...@google.com>
Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
Gerrit-Comment-Date: Sun, 29 Mar 2026 01:37:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Konstantin Shcheglov <sche...@google.com>
unsatisfied_requirement
open
diffy

Konstantin Shcheglov (Gerrit)

unread,
Mar 28, 2026, 9:39:49 PM (2 days ago) Mar 28
to Fedor Shcheglov, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov

Konstantin Shcheglov added 3 comments

File pkg/analyzer/test/src/dart/parser/class_test.dart
Line 1419, Patchset 8 (Latest):''', featureSet: FeatureSets.latest);
Konstantin Shcheglov . unresolved

We don't need this.

Line 1561, Patchset 8 (Latest):''', featureSet: FeatureSets.latest);
Konstantin Shcheglov . unresolved

And this.

Line 3194, Patchset 8 (Latest):''', featureSet: FeatureSets.latest);
Konstantin Shcheglov . unresolved

And this.

Open in Gerrit

Related details

Attention is currently required from:
  • Konstantin Shcheglov
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I0b46392521701ec3846830a9adc04487c7a8541b
Gerrit-Change-Number: 491440
Gerrit-PatchSet: 8
Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-CC: Paul Berry <paul...@google.com>
Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
Gerrit-Comment-Date: Sun, 29 Mar 2026 01:39:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Konstantin Shcheglov (Gerrit)

unread,
Mar 28, 2026, 9:42:42 PM (2 days ago) Mar 28
to Fedor Shcheglov, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov

Konstantin Shcheglov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fedor Shcheglov
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I0b46392521701ec3846830a9adc04487c7a8541b
    Gerrit-Change-Number: 491440
    Gerrit-PatchSet: 9
    Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-CC: Paul Berry <paul...@google.com>
    Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Comment-Date: Sun, 29 Mar 2026 01:42:39 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Fedor Shcheglov (Gerrit)

    unread,
    Mar 28, 2026, 9:49:58 PM (2 days ago) Mar 28
    to Commit Queue, Konstantin Shcheglov, Paul Berry, dart-analys...@google.com, rev...@dartlang.org

    Fedor Shcheglov added 3 comments

    File pkg/analyzer/test/src/dart/parser/class_test.dart
    Line 1419, Patchset 8:''', featureSet: FeatureSets.latest);
    Konstantin Shcheglov . resolved

    We don't need this.

    Fedor Shcheglov

    Done

    Line 1561, Patchset 8:''', featureSet: FeatureSets.latest);
    Konstantin Shcheglov . resolved

    And this.

    Fedor Shcheglov

    Done

    Line 3194, Patchset 8:''', featureSet: FeatureSets.latest);
    Konstantin Shcheglov . resolved

    And this.

    Fedor Shcheglov

    Done

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I0b46392521701ec3846830a9adc04487c7a8541b
    Gerrit-Change-Number: 491440
    Gerrit-PatchSet: 9
    Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-CC: Paul Berry <paul...@google.com>
    Gerrit-Comment-Date: Sun, 29 Mar 2026 01:49:55 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Konstantin Shcheglov <sche...@google.com>
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages