[S] Change in dart/sdk[main]: Don't lint on raw types in constant patterns if the matched type is o...
0 views
Skip to first unread message
Brian Wilkerson (Gerrit)
Jun 9, 2026, 4:01:11 PM (2 days ago) Jun 9
to Jake Macdonald, Brian Wilkerson, Phil Quitslund, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Jake Macdonald and Phil Quitslund
Brian Wilkerson voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jake Macdonald
- Phil Quitslund
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jake Macdonald (Gerrit)
Jun 9, 2026, 4:03:26 PM (2 days ago) Jun 9
to dart-...@luci-project-accounts.iam.gserviceaccount.com, Brian Wilkerson, Phil Quitslund, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Phil Quitslund
Jake Macdonald voted Auto-Submit+1![]( "Open in Gerrit")
Attention is currently required from:
- Phil Quitslund
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Phil Quitslund (Gerrit)
Jun 9, 2026, 6:15:02 PM (2 days ago) Jun 9
to Jake Macdonald, dart-...@luci-project-accounts.iam.gserviceaccount.com, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Jake Macdonald
Phil Quitslund voted and added 1 comment![]( "Open in Gerrit")
Votes added by Phil Quitslund
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Phil Quitslund . resolved
This seems reasonable to me but if Brian disagrees (or would just prefer), let's go ahead and open an issue and invite a broader conversation.
Related details
Attention is currently required from:
- Brian Wilkerson
- Jake Macdonald
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jake Macdonald (Gerrit)
Jun 10, 2026, 11:23:36 AM (18 hours ago) Jun 10
to Phil Quitslund, dart-...@luci-project-accounts.iam.gserviceaccount.com, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson
Jake Macdonald voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Brian Wilkerson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 10, 2026, 11:23:47 AM (18 hours ago) Jun 10
to Jake Macdonald, Phil Quitslund, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Don't lint on raw types in constant patterns if the matched type is of type Type.
The issue does not have total consensus but I do feel strongly and the
fix was trivial and so I am just sending this out.
Feel free to push back if you feel strongly, or I should go through some
formal process.
Change-Id: I7c5e25e9754c4cebd427b8dc9ccfbe8daa57e71a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510460
Auto-Submit: Jake Macdonald <jak...@google.com>
Commit-Queue: Jake Macdonald <jak...@google.com>
Reviewed-by: Phil Quitslund <pquit...@google.com>
Files:
- M pkg/analysis_server/test/src/services/correction/fix/convert_to_constant_pattern_test.dart
- M pkg/linter/CHANGELOG.md
- M pkg/linter/lib/src/rules/type_literal_in_constant_pattern.dart
- M pkg/linter/test/rules/type_literal_in_constant_pattern_test.dart
Change size: M
Delta: 4 files changed, 27 insertions(+), 34 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Phil Quitslund
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages