[S] Change in dart/sdk[main]: analyzer: Add a CHANGELOG entry for Dart 3.11 and analysis_server_plugin

0 views
Skip to first unread message

Felipe Morschel (Gerrit)

unread,
Dec 10, 2025, 1:15:04 PM12/10/25
to Samuel Rawlins, Brian Wilkerson, Danny Tuppeny, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Samuel Rawlins

Felipe Morschel added 2 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Felipe Morschel . resolved

Besides my question below, everything else here LGTM. Thanks, Sam!

File CHANGELOG.md
Line 32, Patchset 1 (Latest):#### Analyzer
Felipe Morschel . unresolved

Do we want to announce the `with-fine-dependencies` flag somewhere too?

Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
  • Samuel Rawlins
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Id3505a7ff5070969ad4480f6698991c0814dc655
Gerrit-Change-Number: 467383
Gerrit-PatchSet: 1
Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-CC: Danny Tuppeny <dan...@google.com>
Gerrit-CC: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Wed, 10 Dec 2025 18:15:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Brian Wilkerson (Gerrit)

unread,
Dec 10, 2025, 1:21:31 PM12/10/25
to Samuel Rawlins, Brian Wilkerson, Felipe Morschel, Danny Tuppeny, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins

Brian Wilkerson voted and added 1 comment

Votes added by Brian Wilkerson

Code-Review+1

1 comment

File CHANGELOG.md
Felipe Morschel . unresolved

Do we want to announce the `with-fine-dependencies` flag somewhere too?

Brian Wilkerson

I believe that it's already enabled by default and that the flag only allows users to disable it in case they run into problems after upgrading. So we probably don't need to include anything about the flag here. (An entry for the feature itself might be a different matter.)

Open in Gerrit

Related details

Attention is currently required from:
  • Samuel Rawlins
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Id3505a7ff5070969ad4480f6698991c0814dc655
Gerrit-Change-Number: 467383
Gerrit-PatchSet: 1
Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-CC: Danny Tuppeny <dan...@google.com>
Gerrit-CC: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Wed, 10 Dec 2025 18:21:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felipe Morschel <g...@fmorschel.dev>
satisfied_requirement
open
diffy

Felipe Morschel (Gerrit)

unread,
Dec 10, 2025, 1:24:05 PM12/10/25
to Samuel Rawlins, Brian Wilkerson, Danny Tuppeny, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins

Felipe Morschel added 1 comment

File CHANGELOG.md
Felipe Morschel . resolved

Do we want to announce the `with-fine-dependencies` flag somewhere too?

Brian Wilkerson

I believe that it's already enabled by default and that the flag only allows users to disable it in case they run into problems after upgrading. So we probably don't need to include anything about the flag here. (An entry for the feature itself might be a different matter.)

Felipe Morschel

An entry for the feature itself might be a different matter

Alright. I'll leave to you to decide if we want to handle this here or in a separate CL.

Open in Gerrit

Related details

Attention is currently required from:
  • Samuel Rawlins
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Id3505a7ff5070969ad4480f6698991c0814dc655
Gerrit-Change-Number: 467383
Gerrit-PatchSet: 1
Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-CC: Danny Tuppeny <dan...@google.com>
Gerrit-CC: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Wed, 10 Dec 2025 18:24:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Brian Wilkerson <brianwi...@google.com>
Comment-In-Reply-To: Felipe Morschel <g...@fmorschel.dev>
satisfied_requirement
open
diffy

Samuel Rawlins (Gerrit)

unread,
Dec 10, 2025, 2:15:18 PM12/10/25
to Konstantin Shcheglov, Brian Wilkerson, Felipe Morschel, Danny Tuppeny, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel

Samuel Rawlins added 1 comment

File CHANGELOG.md
Felipe Morschel . resolved

Do we want to announce the `with-fine-dependencies` flag somewhere too?

Brian Wilkerson

I believe that it's already enabled by default and that the flag only allows users to disable it in case they run into problems after upgrading. So we probably don't need to include anything about the flag here. (An entry for the feature itself might be a different matter.)

Felipe Morschel

An entry for the feature itself might be a different matter

Alright. I'll leave to you to decide if we want to handle this here or in a separate CL.

Samuel Rawlins
Open in Gerrit

Related details

Attention is currently required from:
  • Felipe Morschel
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Id3505a7ff5070969ad4480f6698991c0814dc655
Gerrit-Change-Number: 467383
Gerrit-PatchSet: 1
Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-CC: Danny Tuppeny <dan...@google.com>
Gerrit-CC: Felipe Morschel <g...@fmorschel.dev>
Gerrit-CC: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Comment-Date: Wed, 10 Dec 2025 19:15:16 +0000
satisfied_requirement
open
diffy

Samuel Rawlins (Gerrit)

unread,
Dec 10, 2025, 2:15:23 PM12/10/25
to Konstantin Shcheglov, Brian Wilkerson, Felipe Morschel, Danny Tuppeny, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Felipe Morschel

Samuel Rawlins voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Felipe Morschel
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Id3505a7ff5070969ad4480f6698991c0814dc655
Gerrit-Change-Number: 467383
Gerrit-PatchSet: 1
Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-CC: Danny Tuppeny <dan...@google.com>
Gerrit-CC: Felipe Morschel <g...@fmorschel.dev>
Gerrit-CC: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Felipe Morschel <g...@fmorschel.dev>
Gerrit-Comment-Date: Wed, 10 Dec 2025 19:15:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Dec 10, 2025, 2:15:36 PM12/10/25
to Samuel Rawlins, Konstantin Shcheglov, Brian Wilkerson, Felipe Morschel, Danny Tuppeny, dart-analys...@google.com, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
analyzer: Add a CHANGELOG entry for Dart 3.11 and analysis_server_plugin
Change-Id: Id3505a7ff5070969ad4480f6698991c0814dc655
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Files:
  • M CHANGELOG.md
  • M pkg/analysis_server_plugin/CHANGELOG.md
Change size: S
Delta: 2 files changed, 25 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Brian Wilkerson
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Id3505a7ff5070969ad4480f6698991c0814dc655
Gerrit-Change-Number: 467383
Gerrit-PatchSet: 2
Gerrit-Owner: Samuel Rawlins <sraw...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages