[M] Change in dart/sdk[main]: Enable omit_obvious_local_variable_types lint for pkg/cfg and pkg/nat...

0 views
Skip to first unread message

Alexander Markov (Gerrit)

unread,
Dec 1, 2025, 12:58:05 PM (2 days ago) Dec 1
to Alexander Markov, Slava Egorov, Nate Biggs, Stephen Adams, Tess Strickland, Alexander Aprelev, Nicholas Shahan, Commit Queue, rev...@dartlang.org
Attention needed from Slava Egorov

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Slava Egorov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: If45f0d5e8b10a7927fb4e783efd2c8e90a763af6
Gerrit-Change-Number: 465361
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-CC: Alexander Aprelev <a...@google.com>
Gerrit-CC: Nate Biggs <nate...@google.com>
Gerrit-CC: Nicholas Shahan <nsh...@google.com>
Gerrit-CC: Stephen Adams <s...@google.com>
Gerrit-CC: Tess Strickland <sstr...@google.com>
Gerrit-Attention: Slava Egorov <veg...@google.com>
Gerrit-Comment-Date: Mon, 01 Dec 2025 17:57:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Slava Egorov (Gerrit)

unread,
Dec 2, 2025, 5:24:31 AM (yesterday) Dec 2
to Alexander Markov, Nate Biggs, Stephen Adams, Tess Strickland, Alexander Aprelev, Nicholas Shahan, Commit Queue, rev...@dartlang.org
Attention needed from Alexander Markov

Slava Egorov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alexander Markov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: If45f0d5e8b10a7927fb4e783efd2c8e90a763af6
Gerrit-Change-Number: 465361
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-CC: Alexander Aprelev <a...@google.com>
Gerrit-CC: Nate Biggs <nate...@google.com>
Gerrit-CC: Nicholas Shahan <nsh...@google.com>
Gerrit-CC: Stephen Adams <s...@google.com>
Gerrit-CC: Tess Strickland <sstr...@google.com>
Gerrit-Attention: Alexander Markov <alexm...@google.com>
Gerrit-Comment-Date: Tue, 02 Dec 2025 10:24:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Alexander Markov (Gerrit)

unread,
Dec 2, 2025, 9:24:42 AM (20 hours ago) Dec 2
to Alexander Markov, Slava Egorov, Nate Biggs, Stephen Adams, Tess Strickland, Alexander Aprelev, Nicholas Shahan, Commit Queue, rev...@dartlang.org

Alexander Markov voted and added 1 comment

Votes added by Alexander Markov

Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Alexander Markov . resolved

Thank you, Slava.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: If45f0d5e8b10a7927fb4e783efd2c8e90a763af6
Gerrit-Change-Number: 465361
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-CC: Alexander Aprelev <a...@google.com>
Gerrit-CC: Nate Biggs <nate...@google.com>
Gerrit-CC: Nicholas Shahan <nsh...@google.com>
Gerrit-CC: Stephen Adams <s...@google.com>
Gerrit-CC: Tess Strickland <sstr...@google.com>
Gerrit-Comment-Date: Tue, 02 Dec 2025 14:24:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Dec 2, 2025, 9:24:54 AM (20 hours ago) Dec 2
to Alexander Markov, Slava Egorov, Nate Biggs, Stephen Adams, Tess Strickland, Alexander Aprelev, Nicholas Shahan, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
Enable omit_obvious_local_variable_types lint for pkg/cfg and pkg/native_compiler
Change-Id: If45f0d5e8b10a7927fb4e783efd2c8e90a763af6
Commit-Queue: Alexander Markov <alexm...@google.com>
Reviewed-by: Slava Egorov <veg...@google.com>
Files:
  • M pkg/cfg/analysis_options.yaml
  • M pkg/cfg/lib/front_end/ast_to_ir.dart
  • M pkg/cfg/lib/ir/dominators.dart
  • M pkg/cfg/lib/ir/flow_graph_checker.dart
  • M pkg/cfg/lib/ir/instructions.dart
  • M pkg/cfg/lib/ir/liveness_analysis.dart
  • M pkg/cfg/lib/ir/loops.dart
  • M pkg/cfg/lib/utils/bit_vector.dart
  • M pkg/cfg/lib/utils/misc.dart
  • M pkg/cfg/test/ir_test.dart
  • M pkg/cfg/test/utils/arena_test.dart
  • M pkg/cfg/test/utils/bit_vector_test.dart
  • M pkg/cfg/test/utils/misc_test.dart
  • M pkg/cfg/testcases/dominators.dart
  • M pkg/cfg/testcases/loops.dart
  • M pkg/cfg/testcases/numbers.dart
  • M pkg/cfg/testcases/statements.dart
  • M pkg/cfg/testcases/unreachable_ast.dart
  • M pkg/native_compiler/analysis_options.yaml
Change size: M
Delta: 19 files changed, 77 insertions(+), 67 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Slava Egorov
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: If45f0d5e8b10a7927fb4e783efd2c8e90a763af6
Gerrit-Change-Number: 465361
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Alexander Markov <alexm...@google.com>
Gerrit-Reviewer: Slava Egorov <veg...@google.com>
Gerrit-CC: Alexander Aprelev <a...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages