Attention is currently required from: Oleh Prypin.
Devon Carew would like Oleh Prypin to review this change.
[deps] revert the recent roll of package:csslib
Change-Id: Ifa857de259f8ee4750bcdfa8c63f5c9a72322d1a
---
M DEPS
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/DEPS b/DEPS
index 1beb8e8..f8ac44f 100644
--- a/DEPS
+++ b/DEPS
@@ -123,7 +123,7 @@
"collection_rev": "0d0e184a5f70ca4e23dab23df686127ec40bfb11",
"convert_rev": "83886e3fd895211a98e49b7595a92796fa216641",
"crypto_rev": "03eb2c9098069a7816bbace581dc2d6e196c63ca",
- "csslib_rev": "e6c83089e83dd0320dc560c33a73ff66a80e51fe",
+ "csslib_rev": "f33d63211f77e2a895b90bcf22508ab7a0af4466", # b/268132431
# Note: Updates to dart_style have to be coordinated with the infrastructure
# team so that the internal formatter `tools/sdks/dart-sdk/bin/dart format`
# matches the version here. Please follow this process to make updates:
To view, visit change 281341. To unsubscribe, or for help writing mail filters, visit settings.
Attention is currently required from: Oleh Prypin.
Patch set 1:Auto-Submit +1
Attention is currently required from: Devon Carew.
Patch set 1:Code-Review +1Commit-Queue +1
1 comment:
Patchset:
Let's make sure to wait for all tests.
source_span and csslib are both involved in the stack trace and were both revved, it could be that they have some related changes
To view, visit change 281341. To unsubscribe, or for help writing mail filters, visit settings.
1 comment:
Patchset:
Let's make sure to wait for all tests.
Submitting to the commit queue does do a full bot run first, so I think we're good there.
To view, visit change 281341. To unsubscribe, or for help writing mail filters, visit settings.
Patch set 1:Commit-Queue +2
go/dart-cbuild result: SUCCESS
Details: https://goto.google.com/dart-cbuild/find/73922abe84bb8cf5b3d684baf3465a9385500668
Commit Queue submitted this change.
[deps] revert the recent roll of package:csslib
Change-Id: Ifa857de259f8ee4750bcdfa8c63f5c9a72322d1a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/281341
Reviewed-by: Oleh Prypin <opr...@google.com>
Auto-Submit: Devon Carew <devon...@google.com>
Commit-Queue: Oleh Prypin <opr...@google.com>
Commit-Queue: Devon Carew <devon...@google.com>
---
M DEPS
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/DEPS b/DEPS
index 1beb8e8..f8ac44f 100644
--- a/DEPS
+++ b/DEPS
@@ -123,7 +123,7 @@
"collection_rev": "0d0e184a5f70ca4e23dab23df686127ec40bfb11",
"convert_rev": "83886e3fd895211a98e49b7595a92796fa216641",
"crypto_rev": "03eb2c9098069a7816bbace581dc2d6e196c63ca",
- "csslib_rev": "e6c83089e83dd0320dc560c33a73ff66a80e51fe",
+ "csslib_rev": "f33d63211f77e2a895b90bcf22508ab7a0af4466", # b/268132431
# Note: Updates to dart_style have to be coordinated with the infrastructure
# team so that the internal formatter `tools/sdks/dart-sdk/bin/dart format`
# matches the version here. Please follow this process to make updates:
To view, visit change 281341. To unsubscribe, or for help writing mail filters, visit settings.
go/dart-cbuild result: SUCCESS
Details: https://goto.google.com/dart-cbuild/find/145b6c4a8ca09a55bd9f4ba5089d71e8f7e56048