[S] Change in dart/sdk[main]: [deps] revert the recent roll of package:csslib

0 views
Skip to first unread message

Devon Carew (Gerrit)

unread,
Feb 7, 2023, 10:45:05 AM2/7/23
to Oleh Prypin, rev...@dartlang.org

Attention is currently required from: Oleh Prypin.

Devon Carew would like Oleh Prypin to review this change.

View Change

[deps] revert the recent roll of package:csslib

Change-Id: Ifa857de259f8ee4750bcdfa8c63f5c9a72322d1a
---
M DEPS
1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/DEPS b/DEPS
index 1beb8e8..f8ac44f 100644
--- a/DEPS
+++ b/DEPS
@@ -123,7 +123,7 @@
"collection_rev": "0d0e184a5f70ca4e23dab23df686127ec40bfb11",
"convert_rev": "83886e3fd895211a98e49b7595a92796fa216641",
"crypto_rev": "03eb2c9098069a7816bbace581dc2d6e196c63ca",
- "csslib_rev": "e6c83089e83dd0320dc560c33a73ff66a80e51fe",
+ "csslib_rev": "f33d63211f77e2a895b90bcf22508ab7a0af4466", # b/268132431
# Note: Updates to dart_style have to be coordinated with the infrastructure
# team so that the internal formatter `tools/sdks/dart-sdk/bin/dart format`
# matches the version here. Please follow this process to make updates:

To view, visit change 281341. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ifa857de259f8ee4750bcdfa8c63f5c9a72322d1a
Gerrit-Change-Number: 281341
Gerrit-PatchSet: 1
Gerrit-Owner: Devon Carew <devon...@google.com>
Gerrit-Reviewer: Devon Carew <devon...@google.com>
Gerrit-Reviewer: Oleh Prypin <opr...@google.com>
Gerrit-Attention: Oleh Prypin <opr...@google.com>
Gerrit-MessageType: newchange

Devon Carew (Gerrit)

unread,
Feb 7, 2023, 10:45:06 AM2/7/23
to rev...@dartlang.org, Oleh Prypin

Attention is currently required from: Oleh Prypin.

Patch set 1:Auto-Submit +1

View Change

    To view, visit change 281341. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifa857de259f8ee4750bcdfa8c63f5c9a72322d1a
    Gerrit-Change-Number: 281341
    Gerrit-PatchSet: 1
    Gerrit-Owner: Devon Carew <devon...@google.com>
    Gerrit-Reviewer: Devon Carew <devon...@google.com>
    Gerrit-Reviewer: Oleh Prypin <opr...@google.com>
    Gerrit-Attention: Oleh Prypin <opr...@google.com>
    Gerrit-Comment-Date: Tue, 07 Feb 2023 15:45:01 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Oleh Prypin (Gerrit)

    unread,
    Feb 7, 2023, 10:52:00 AM2/7/23
    to Devon Carew, rev...@dartlang.org, Oleh Prypin

    Attention is currently required from: Devon Carew.

    Patch set 1:Code-Review +1Commit-Queue +1

    View Change

    1 comment:

    • Patchset:

      • Patch Set #1:

        Let's make sure to wait for all tests.

        source_span and csslib are both involved in the stack trace and were both revved, it could be that they have some related changes

    To view, visit change 281341. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifa857de259f8ee4750bcdfa8c63f5c9a72322d1a
    Gerrit-Change-Number: 281341
    Gerrit-PatchSet: 1
    Gerrit-Owner: Devon Carew <devon...@google.com>
    Gerrit-Reviewer: Devon Carew <devon...@google.com>
    Gerrit-Reviewer: Oleh Prypin <opr...@google.com>
    Gerrit-Attention: Devon Carew <devon...@google.com>
    Gerrit-Comment-Date: Tue, 07 Feb 2023 15:51:54 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Devon Carew (Gerrit)

    unread,
    Feb 7, 2023, 10:57:06 AM2/7/23
    to rev...@dartlang.org, Commit Queue, Oleh Prypin

    View Change

    1 comment:

    • Patchset:

      • Submitting to the commit queue does do a full bot run first, so I think we're good there.

    To view, visit change 281341. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifa857de259f8ee4750bcdfa8c63f5c9a72322d1a
    Gerrit-Change-Number: 281341
    Gerrit-PatchSet: 1
    Gerrit-Owner: Devon Carew <devon...@google.com>
    Gerrit-Reviewer: Devon Carew <devon...@google.com>
    Gerrit-Reviewer: Oleh Prypin <opr...@google.com>
    Gerrit-Comment-Date: Tue, 07 Feb 2023 15:57:01 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Oleh Prypin <opr...@google.com>
    Gerrit-MessageType: comment

    Devon Carew (Gerrit)

    unread,
    Feb 7, 2023, 11:06:04 AM2/7/23
    to rev...@dartlang.org, Commit Queue, Oleh Prypin

    Patch set 1:Commit-Queue +2

    View Change

      To view, visit change 281341. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: sdk
      Gerrit-Branch: main
      Gerrit-Change-Id: Ifa857de259f8ee4750bcdfa8c63f5c9a72322d1a
      Gerrit-Change-Number: 281341
      Gerrit-PatchSet: 1
      Gerrit-Owner: Devon Carew <devon...@google.com>
      Gerrit-Reviewer: Devon Carew <devon...@google.com>
      Gerrit-Reviewer: Oleh Prypin <opr...@google.com>
      Gerrit-Comment-Date: Tue, 07 Feb 2023 16:05:56 +0000

      CBuild (Gerrit)

      unread,
      Feb 7, 2023, 11:28:57 AM2/7/23
      to Devon Carew, rev...@dartlang.org, Commit Queue, Oleh Prypin

      go/dart-cbuild result: SUCCESS

      Details: https://goto.google.com/dart-cbuild/find/73922abe84bb8cf5b3d684baf3465a9385500668

      View Change

        To view, visit change 281341. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: sdk
        Gerrit-Branch: main
        Gerrit-Change-Id: Ifa857de259f8ee4750bcdfa8c63f5c9a72322d1a
        Gerrit-Change-Number: 281341
        Gerrit-PatchSet: 1
        Gerrit-Owner: Devon Carew <devon...@google.com>
        Gerrit-Reviewer: Devon Carew <devon...@google.com>
        Gerrit-Reviewer: Oleh Prypin <opr...@google.com>
        Gerrit-Comment-Date: Tue, 07 Feb 2023 16:28:52 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: No
        Gerrit-MessageType: comment

        Commit Queue (Gerrit)

        unread,
        Feb 7, 2023, 12:25:19 PM2/7/23
        to Devon Carew, rev...@dartlang.org, CBuild, Oleh Prypin

        Commit Queue submitted this change.

        View Change

        Approvals: Devon Carew: Send CL to CQ automatically after approval; Commit Oleh Prypin: Looks good to me, approved; Dry run
        [deps] revert the recent roll of package:csslib

        Change-Id: Ifa857de259f8ee4750bcdfa8c63f5c9a72322d1a
        Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/281341
        Reviewed-by: Oleh Prypin <opr...@google.com>
        Auto-Submit: Devon Carew <devon...@google.com>
        Commit-Queue: Oleh Prypin <opr...@google.com>
        Commit-Queue: Devon Carew <devon...@google.com>
        ---
        M DEPS
        1 file changed, 15 insertions(+), 1 deletion(-)

        diff --git a/DEPS b/DEPS
        index 1beb8e8..f8ac44f 100644
        --- a/DEPS
        +++ b/DEPS
        @@ -123,7 +123,7 @@
        "collection_rev": "0d0e184a5f70ca4e23dab23df686127ec40bfb11",
        "convert_rev": "83886e3fd895211a98e49b7595a92796fa216641",
        "crypto_rev": "03eb2c9098069a7816bbace581dc2d6e196c63ca",
        - "csslib_rev": "e6c83089e83dd0320dc560c33a73ff66a80e51fe",
        + "csslib_rev": "f33d63211f77e2a895b90bcf22508ab7a0af4466", # b/268132431
        # Note: Updates to dart_style have to be coordinated with the infrastructure
        # team so that the internal formatter `tools/sdks/dart-sdk/bin/dart format`
        # matches the version here. Please follow this process to make updates:

        To view, visit change 281341. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: sdk
        Gerrit-Branch: main
        Gerrit-Change-Id: Ifa857de259f8ee4750bcdfa8c63f5c9a72322d1a
        Gerrit-Change-Number: 281341
        Gerrit-PatchSet: 2
        Gerrit-Owner: Devon Carew <devon...@google.com>
        Gerrit-Reviewer: Devon Carew <devon...@google.com>
        Gerrit-Reviewer: Oleh Prypin <opr...@google.com>
        Gerrit-MessageType: merged

        CBuild (Gerrit)

        unread,
        Feb 7, 2023, 1:03:10 PM2/7/23
        to Commit Queue, Devon Carew, rev...@dartlang.org, Oleh Prypin

        go/dart-cbuild result: SUCCESS

        Details: https://goto.google.com/dart-cbuild/find/145b6c4a8ca09a55bd9f4ba5089d71e8f7e56048

        View Change

          To view, visit change 281341. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-Project: sdk
          Gerrit-Branch: main
          Gerrit-Change-Id: Ifa857de259f8ee4750bcdfa8c63f5c9a72322d1a
          Gerrit-Change-Number: 281341
          Gerrit-PatchSet: 2
          Gerrit-Owner: Devon Carew <devon...@google.com>
          Gerrit-Reviewer: Devon Carew <devon...@google.com>
          Gerrit-Reviewer: Oleh Prypin <opr...@google.com>
          Gerrit-Comment-Date: Tue, 07 Feb 2023 18:03:06 +0000
          Reply all
          Reply to author
          Forward
          0 new messages