[L] Change in dart/sdk[main]: Implement lazy reading/writing of EnumElement and EnumFragment.

0 views
Skip to first unread message

Konstantin Shcheglov (Gerrit)

unread,
6:37 PM (4 hours ago) 6:37 PM
to Fedor Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov

Konstantin Shcheglov added 5 comments

File pkg/analyzer/test/src/summary/elements/class_test.dart
Line 12924, Patchset 3 (Latest): solo_test_class_lazy_byReference_getter() async {
Konstantin Shcheglov . unresolved

Remove `solo_`.

Line 12999, Patchset 3 (Latest): var A = library.getClass('A')!;
var methods = A.methods;
expect(methods, hasLength(1));
Konstantin Shcheglov . unresolved

Revert this.

File pkg/analyzer/test/src/summary/elements/enum_test.dart
Line 299, Patchset 3 (Latest): #F0 <testLibraryFragment>
Konstantin Shcheglov . unresolved

?

Line 3589, Patchset 3 (Latest): int foo() => 0;
Konstantin Shcheglov . unresolved

`void foo`

Line 3651, Patchset 3 (Latest): int foo() => 0;
Konstantin Shcheglov . unresolved

`void foo`

Open in Gerrit

Related details

Attention is currently required from:
  • Fedor Shcheglov
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I4b5227aa68489c87c4806b1fce6589523723da49
Gerrit-Change-Number: 469740
Gerrit-PatchSet: 3
Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Comment-Date: Wed, 24 Dec 2025 23:37:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Konstantin Shcheglov (Gerrit)

unread,
6:43 PM (4 hours ago) 6:43 PM
to Fedor Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov

Konstantin Shcheglov added 1 comment

File pkg/analyzer/lib/src/dart/element/element.dart
Line 2034, Patchset 4 (Latest): return [
for (
EnumFragmentImpl? fragment = _firstFragment;
fragment != null;
fragment = fragment.nextFragment
)
fragment,
];
}
Konstantin Shcheglov . unresolved

format?

Open in Gerrit

Related details

Attention is currently required from:
  • Fedor Shcheglov
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I4b5227aa68489c87c4806b1fce6589523723da49
Gerrit-Change-Number: 469740
Gerrit-PatchSet: 4
Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Comment-Date: Wed, 24 Dec 2025 23:43:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Fedor Shcheglov (Gerrit)

unread,
7:06 PM (4 hours ago) 7:06 PM
to Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov

Fedor Shcheglov added 6 comments

File pkg/analyzer/lib/src/dart/element/element.dart

for (
EnumFragmentImpl? fragment = _firstFragment;
fragment != null;
fragment = fragment.nextFragment
)
fragment,
];
}
Konstantin Shcheglov . resolved

format?

Fedor Shcheglov

Done

File pkg/analyzer/test/src/summary/elements/class_test.dart
Line 12924, Patchset 3: solo_test_class_lazy_byReference_getter() async {
Konstantin Shcheglov . resolved

Remove `solo_`.

Fedor Shcheglov

Done

Line 12999, Patchset 3: var A = library.getClass('A')!;

var methods = A.methods;
expect(methods, hasLength(1));
Konstantin Shcheglov . resolved

Revert this.

Fedor Shcheglov

Done

File pkg/analyzer/test/src/summary/elements/enum_test.dart
Line 299, Patchset 3: #F0 <testLibraryFragment>
Konstantin Shcheglov . resolved

?

Fedor Shcheglov

Done

Line 3589, Patchset 3: int foo() => 0;
Konstantin Shcheglov . resolved

`void foo`

Fedor Shcheglov

Done

Line 3651, Patchset 3: int foo() => 0;
Konstantin Shcheglov . resolved

`void foo`

Fedor Shcheglov

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Konstantin Shcheglov
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I4b5227aa68489c87c4806b1fce6589523723da49
Gerrit-Change-Number: 469740
Gerrit-PatchSet: 8
Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
Gerrit-Comment-Date: Thu, 25 Dec 2025 00:06:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Konstantin Shcheglov <sche...@google.com>
unsatisfied_requirement
open
diffy

Konstantin Shcheglov (Gerrit)

unread,
7:52 PM (3 hours ago) 7:52 PM
to Fedor Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov

Konstantin Shcheglov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fedor Shcheglov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I4b5227aa68489c87c4806b1fce6589523723da49
Gerrit-Change-Number: 469740
Gerrit-PatchSet: 9
Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Comment-Date: Thu, 25 Dec 2025 00:52:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Konstantin Shcheglov (Gerrit)

unread,
8:03 PM (3 hours ago) 8:03 PM
to Fedor Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov

Konstantin Shcheglov added 4 comments

File pkg/analyzer/test/src/summary/elements/extension_test.dart
Line 5, Patchset 9 (Latest):import 'package:matcher/expect.dart';
Konstantin Shcheglov . unresolved

Lets import `package:test` instead.

Konstantin Shcheglov . unresolved

?

Line 156, Patchset 9 (Latest): int set foo(int _){}
Konstantin Shcheglov . unresolved

?

Line 156, Patchset 9 (Latest): int set foo(int _){}
Konstantin Shcheglov . unresolved

space

Open in Gerrit

Related details

Attention is currently required from:
  • Fedor Shcheglov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I4b5227aa68489c87c4806b1fce6589523723da49
Gerrit-Change-Number: 469740
Gerrit-PatchSet: 9
Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Comment-Date: Thu, 25 Dec 2025 01:02:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages