[XS] Change in dart/sdk[main]: [dart2wasm] Recreate the library index after TFA to avoid dangling re...

0 views
Skip to first unread message

Martin Kustermann (Gerrit)

unread,
Oct 29, 2025, 5:33:23 AM (3 days ago) Oct 29
to Nate Biggs, Commit Queue, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Nate Biggs

Martin Kustermann voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Nate Biggs
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ieaaa908ec1045520f502ad0e2c1b1f639101bde2
Gerrit-Change-Number: 458180
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Kustermann <kuste...@google.com>
Gerrit-Reviewer: Martin Kustermann <kuste...@google.com>
Gerrit-Reviewer: Nate Biggs <nate...@google.com>
Gerrit-Attention: Nate Biggs <nate...@google.com>
Gerrit-Comment-Date: Wed, 29 Oct 2025 09:33:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nate Biggs (Gerrit)

unread,
Oct 29, 2025, 11:52:10 AM (3 days ago) Oct 29
to Martin Kustermann, Commit Queue, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Martin Kustermann

Nate Biggs voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Martin Kustermann
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ieaaa908ec1045520f502ad0e2c1b1f639101bde2
Gerrit-Change-Number: 458180
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Kustermann <kuste...@google.com>
Gerrit-Reviewer: Martin Kustermann <kuste...@google.com>
Gerrit-Reviewer: Nate Biggs <nate...@google.com>
Gerrit-Attention: Martin Kustermann <kuste...@google.com>
Gerrit-Comment-Date: Wed, 29 Oct 2025 15:52:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Martin Kustermann (Gerrit)

unread,
Oct 30, 2025, 6:40:47 AM (2 days ago) Oct 30
to Nate Biggs, Commit Queue, dart2wasm-t...@google.com, rev...@dartlang.org

Martin Kustermann voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ieaaa908ec1045520f502ad0e2c1b1f639101bde2
Gerrit-Change-Number: 458180
Gerrit-PatchSet: 4
Gerrit-Owner: Martin Kustermann <kuste...@google.com>
Gerrit-Reviewer: Martin Kustermann <kuste...@google.com>
Gerrit-Reviewer: Nate Biggs <nate...@google.com>
Gerrit-Comment-Date: Thu, 30 Oct 2025 10:40:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Oct 30, 2025, 7:11:52 AM (2 days ago) Oct 30
to Martin Kustermann, Nate Biggs, dart2wasm-t...@google.com, rev...@dartlang.org

Commit Queue submitted the change

Unreviewed changes

3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
[dart2wasm] Recreate the library index after TFA to avoid dangling references
Change-Id: Ieaaa908ec1045520f502ad0e2c1b1f639101bde2
Reviewed-by: Nate Biggs <nate...@google.com>
Commit-Queue: Martin Kustermann <kuste...@google.com>
Files:
  • M pkg/dart2wasm/lib/compile.dart
  • M pkg/dart2wasm/lib/translator.dart
Change size: XS
Delta: 2 files changed, 5 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Nate Biggs
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ieaaa908ec1045520f502ad0e2c1b1f639101bde2
Gerrit-Change-Number: 458180
Gerrit-PatchSet: 5
Gerrit-Owner: Martin Kustermann <kuste...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages