[S] Change in dart/sdk[main]: [analyzer] Add parameter deprecation support to api.txt.

0 views
Skip to first unread message

Paul Berry (Gerrit)

unread,
Aug 5, 2025, 6:30:43 PM8/5/25
to Konstantin Shcheglov, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Konstantin Shcheglov

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
  • Konstantin Shcheglov
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I27620d9faaa834299a1b7158b66424065e7bfda7
Gerrit-Change-Number: 443634
Gerrit-PatchSet: 3
Gerrit-Owner: Paul Berry <paul...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Reviewer: Paul Berry <paul...@google.com>
Gerrit-Attention: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
Gerrit-Comment-Date: Tue, 05 Aug 2025 22:30:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Konstantin Shcheglov (Gerrit)

unread,
Aug 5, 2025, 7:16:10 PM8/5/25
to Paul Berry, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson and Paul Berry

Konstantin Shcheglov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
  • Paul Berry
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I27620d9faaa834299a1b7158b66424065e7bfda7
    Gerrit-Change-Number: 443634
    Gerrit-PatchSet: 3
    Gerrit-Owner: Paul Berry <paul...@google.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Paul Berry <paul...@google.com>
    Gerrit-Attention: Paul Berry <paul...@google.com>
    Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Comment-Date: Tue, 05 Aug 2025 23:16:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Paul Berry (Gerrit)

    unread,
    Aug 8, 2025, 1:28:48 PM8/8/25
    to Phil Quitslund, Konstantin Shcheglov, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Brian Wilkerson and Phil Quitslund

    Paul Berry added 1 comment

    Patchset-level comments
    File-level comment, Patchset 3 (Latest):
    Paul Berry . resolved

    Phil, can you take a look at the changes to `pkg/analyzer_plugin/api.txt` and `pkg/analyzer/api.txt`? Brian is out today.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Brian Wilkerson
    • Phil Quitslund
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I27620d9faaa834299a1b7158b66424065e7bfda7
    Gerrit-Change-Number: 443634
    Gerrit-PatchSet: 3
    Gerrit-Owner: Paul Berry <paul...@google.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Paul Berry <paul...@google.com>
    Gerrit-Reviewer: Phil Quitslund <pquit...@google.com>
    Gerrit-Attention: Phil Quitslund <pquit...@google.com>
    Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Comment-Date: Fri, 08 Aug 2025 17:28:45 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Phil Quitslund (Gerrit)

    unread,
    Aug 10, 2025, 1:28:31 PM8/10/25
    to Paul Berry, Konstantin Shcheglov, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Brian Wilkerson and Paul Berry

    Phil Quitslund voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Brian Wilkerson
    • Paul Berry
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I27620d9faaa834299a1b7158b66424065e7bfda7
    Gerrit-Change-Number: 443634
    Gerrit-PatchSet: 4
    Gerrit-Owner: Paul Berry <paul...@google.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Paul Berry <paul...@google.com>
    Gerrit-Reviewer: Phil Quitslund <pquit...@google.com>
    Gerrit-Attention: Paul Berry <paul...@google.com>
    Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Comment-Date: Sun, 10 Aug 2025 17:28:29 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Paul Berry (Gerrit)

    unread,
    Aug 11, 2025, 10:03:43 AM8/11/25
    to Phil Quitslund, Konstantin Shcheglov, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Brian Wilkerson

    Paul Berry voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Brian Wilkerson
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I27620d9faaa834299a1b7158b66424065e7bfda7
    Gerrit-Change-Number: 443634
    Gerrit-PatchSet: 4
    Gerrit-Owner: Paul Berry <paul...@google.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Paul Berry <paul...@google.com>
    Gerrit-Reviewer: Phil Quitslund <pquit...@google.com>
    Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Comment-Date: Mon, 11 Aug 2025 14:02:43 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Commit Queue (Gerrit)

    unread,
    Aug 11, 2025, 10:35:31 AM8/11/25
    to Paul Berry, Phil Quitslund, Konstantin Shcheglov, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org

    Commit Queue submitted the change

    Change information

    Commit message:
    [analyzer] Add parameter deprecation support to api.txt.

    When I added `deprecated` annotations to `api.txt`, I forgot that
    function parameters could be deprecated too. This change fixes the
    omission and regenerates `api.txt`.

    There is no actual API change.
    Change-Id: I27620d9faaa834299a1b7158b66424065e7bfda7
    Reviewed-by: Konstantin Shcheglov <sche...@google.com>
    Reviewed-by: Phil Quitslund <pquit...@google.com>
    Commit-Queue: Paul Berry <paul...@google.com>
    Files:
    • M pkg/analyzer/api.txt
    • M pkg/analyzer_plugin/api.txt
    • M pkg/analyzer_utilities/lib/tool/api.dart
    Change size: S
    Delta: 3 files changed, 22 insertions(+), 8 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Konstantin Shcheglov, +1 by Phil Quitslund
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I27620d9faaa834299a1b7158b66424065e7bfda7
    Gerrit-Change-Number: 443634
    Gerrit-PatchSet: 5
    Gerrit-Owner: Paul Berry <paul...@google.com>
    Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages