[M] Change in dart/sdk[main]: Greatly simplify _readFormalParameters and _writeFormalParameters

0 views
Skip to first unread message

Konstantin Shcheglov (Gerrit)

unread,
Dec 29, 2025, 6:08:41 PM (2 days ago) Dec 29
to Fedor Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov

Konstantin Shcheglov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fedor Shcheglov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I9f78d80a11666026ebfc3d2270cacdd4c27a09ce
Gerrit-Change-Number: 470040
Gerrit-PatchSet: 2
Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
Gerrit-Comment-Date: Mon, 29 Dec 2025 23:08:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Samuel Rawlins (Gerrit)

unread,
Dec 29, 2025, 6:44:13 PM (2 days ago) Dec 29
to Fedor Shcheglov, Commit Queue, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Fedor Shcheglov

Samuel Rawlins voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Fedor Shcheglov
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I9f78d80a11666026ebfc3d2270cacdd4c27a09ce
    Gerrit-Change-Number: 470040
    Gerrit-PatchSet: 2
    Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Comment-Date: Mon, 29 Dec 2025 23:44:10 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Konstantin Shcheglov (Gerrit)

    unread,
    Dec 29, 2025, 6:44:53 PM (2 days ago) Dec 29
    to Fedor Shcheglov, Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Fedor Shcheglov

    Konstantin Shcheglov voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Fedor Shcheglov
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I9f78d80a11666026ebfc3d2270cacdd4c27a09ce
    Gerrit-Change-Number: 470040
    Gerrit-PatchSet: 2
    Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Reviewer: Konstantin Shcheglov <sche...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Fedor Shcheglov <fedor.s...@gmail.com>
    Gerrit-Comment-Date: Mon, 29 Dec 2025 23:44:49 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Commit Queue (Gerrit)

    unread,
    Dec 29, 2025, 6:45:03 PM (2 days ago) Dec 29
    to Fedor Shcheglov, Samuel Rawlins, Konstantin Shcheglov, dart-analys...@google.com, rev...@dartlang.org

    Commit Queue submitted the change

    Change information

    Commit message:
    Greatly simplify _readFormalParameters and _writeFormalParameters
    Change-Id: I9f78d80a11666026ebfc3d2270cacdd4c27a09ce
    Reviewed-by: Konstantin Shcheglov <sche...@google.com>
    Reviewed-by: Samuel Rawlins <sraw...@google.com>
    Commit-Queue: Konstantin Shcheglov <sche...@google.com>
    Files:
    • M pkg/analyzer/lib/src/summary2/bundle_reader.dart
    • M pkg/analyzer/lib/src/summary2/bundle_writer.dart
    Change size: M
    Delta: 2 files changed, 11 insertions(+), 56 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Konstantin Shcheglov, +1 by Samuel Rawlins
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I9f78d80a11666026ebfc3d2270cacdd4c27a09ce
    Gerrit-Change-Number: 470040
    Gerrit-PatchSet: 3
    Gerrit-Owner: Fedor Shcheglov <fedor.s...@gmail.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages