[XL] Change in dart/sdk[main]: AST. Implement CompoundAssignment.
1 view
Skip to first unread message
Konstantin Shcheglov (Gerrit)
Aug 3, 2026, 6:31:32 PM (2 days ago) Aug 3
to Paul Berry, Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther and Paul Berry
Konstantin Shcheglov voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Johnni Winther
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Berry (Gerrit)
Aug 4, 2026, 1:01:00 PM (2 days ago) Aug 4
to Konstantin Shcheglov, Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther and Konstantin Shcheglov
Paul Berry voted and added 2 comments![]( "Open in Gerrit")
Votes added by Paul Berry
| Code-Review | +1 |
2 comments
Patchset-level comments
File pkg/analyzer/api.txt
Line 1417, Patchset 2 (Latest):
operatorResultType (getter: DartType?)Paul Berry . unresolved
Shouldn't there also be getters to access:
- the LHS of the assignment?
- the operator token?
- the RHS of the assignment?
Related details
Attention is currently required from:
- Johnni Winther
- Konstantin Shcheglov
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Aug 5, 2026, 7:41:43 PM (8 hours ago) Aug 5
to Paul Berry, Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther
Konstantin Shcheglov added 1 comment![]( "Open in Gerrit")
File pkg/analyzer/api.txt
Shouldn't there also be getters to access:
- the LHS of the assignment?
- the operator token?
- the RHS of the assignment?
Konstantin Shcheglov
These are inherited from `AssignmentExpression2`: `target` is the LHS, `operator` is the operator token, and `value` is the RHS. api.txt only lists the members declared directly by `CompoundAssignment`.
Related details
Attention is currently required from:
- Johnni Winther
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Aug 5, 2026, 8:19:00 PM (7 hours ago) Aug 5
to Paul Berry, Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther
Konstantin Shcheglov voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Johnni Winther
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Aug 5, 2026, 8:19:12 PM (7 hours ago) Aug 5
to Konstantin Shcheglov, Paul Berry, Johnni Winther, dart-analys...@google.com, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: pkg/analyzer/test/src/dart/resolution/assignment_test.dart
Insertions: 83, Deletions: 95.
The diff is too large to show. Please review the diff.
```
```
The name of the file: pkg/analyzer/lib/src/dart/ast/ast.dart
Insertions: 2, Deletions: 3.
The diff is too large to show. Please review the diff.
```
```
The name of the file: pkg/analyzer/lib/src/error/unused_local_elements_verifier.dart
Insertions: 2, Deletions: 4.
The diff is too large to show. Please review the diff.
```
```
The name of the file: pkg/analyzer/lib/src/hint/sdk_constraint_verifier.dart
Insertions: 2, Deletions: 3.
The diff is too large to show. Please review the diff.
```
```
The name of the file: pkg/analyzer/lib/src/generated/error_verifier.dart
Insertions: 3, Deletions: 3.
The diff is too large to show. Please review the diff.
```
```
The name of the file: pkg/analyzer/lib/src/dart/analysis/driver.dart
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: pkg/analyzer/lib/src/error/element_usage_detector.dart
Insertions: 14, Deletions: 3.
The diff is too large to show. Please review the diff.
```
```
The name of the file: pkg/analyzer/test/src/summary/resolved_ast_printer.dart
Insertions: 2, Deletions: 0.
The diff is too large to show. Please review the diff.
```
```
The name of the file: pkg/analyzer/test/src/dart/resolution/extension_method_test.dart
Insertions: 12, Deletions: 14.
The diff is too large to show. Please review the diff.
```
```
The name of the file: pkg/analyzer/lib/src/dart/resolver/assignment_expression_resolver.dart
Insertions: 6, Deletions: 6.
The diff is too large to show. Please review the diff.
```
```
The name of the file: pkg/analyzer/lib/src/dart/analysis/index.dart
Insertions: 2, Deletions: 3.
The diff is too large to show. Please review the diff.
```
```
The name of the file: pkg/analyzer/test/src/summary/elements/const_test.dart
Insertions: 9, Deletions: 10.
The diff is too large to show. Please review the diff.
```
```
The name of the file: pkg/analyzer/test/src/diagnostics/use_of_nullable_value_test.dart
Insertions: 12, Deletions: 14.
The diff is too large to show. Please review the diff.
```
```
The name of the file: pkg/analyzer/test/src/dart/resolution/function_reference_test.dart
Insertions: 6, Deletions: 7.
The diff is too large to show. Please review the diff.
```
```
The name of the file: pkg/analyzer/lib/src/generated/resolver.dart
Insertions: 2, Deletions: 4.
The diff is too large to show. Please review the diff.
```
```
The name of the file: pkg/analyzer/lib/src/dart/micro/utils.dart
Insertions: 2, Deletions: 3.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
AST. Implement CompoundAssignment.
Change-Id: Ie294f00d05b80860311a20c3f24b5afcd5f76e75
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/530800
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Paul Berry <paul...@google.com>
Files:
- M pkg/analyzer/api.txt
- M pkg/analyzer/lib/analysis_rule/rule_visitor_registry.g.dart
- M pkg/analyzer/lib/dart/ast/ast.dart
- M pkg/analyzer/lib/dart/ast/visitor.g.dart
- M pkg/analyzer/lib/src/dart/analysis/driver.dart
- M pkg/analyzer/lib/src/dart/analysis/index.dart
- M pkg/analyzer/lib/src/dart/ast/ast.dart
- M pkg/analyzer/lib/src/dart/ast/ast.g.dart
- M pkg/analyzer/lib/src/dart/ast/element_locator.dart
- M pkg/analyzer/lib/src/dart/ast/to_source_visitor.dart
- M pkg/analyzer/lib/src/dart/micro/utils.dart
- M pkg/analyzer/lib/src/dart/resolver/assignment_expression_resolver.dart
- M pkg/analyzer/lib/src/dart/resolver/flow_analysis_visitor.dart
- M pkg/analyzer/lib/src/dart/resolver/property_element_resolver.dart
- M pkg/analyzer/lib/src/dart/resolver/type_property_resolver.dart
- M pkg/analyzer/lib/src/error/best_practices_verifier.dart
- M pkg/analyzer/lib/src/error/const_argument_verifier.dart
- M pkg/analyzer/lib/src/error/element_usage_detector.dart
- M pkg/analyzer/lib/src/error/unused_local_elements_verifier.dart
- M pkg/analyzer/lib/src/fasta/ast_builder.dart
- M pkg/analyzer/lib/src/generated/error_verifier.dart
- M pkg/analyzer/lib/src/generated/resolver.dart
- M pkg/analyzer/lib/src/hint/sdk_constraint_verifier.dart
- M pkg/analyzer/lib/src/lint/linter_visitor.g.dart
- M pkg/analyzer/lib/src/summary2/ast_binary_reader.dart
- M pkg/analyzer/lib/src/summary2/ast_binary_tag.dart
- M pkg/analyzer/lib/src/summary2/ast_binary_writer.dart
- M pkg/analyzer/lib/src/summary2/informative_data.dart
- M pkg/analyzer/lib/src/test_utilities/find_node.dart
- M pkg/analyzer/lib/src/wolf/ir/ast_to_ir.dart
- M pkg/analyzer/test/generated/class_member_parser_test.dart
- M pkg/analyzer/test/id_tests/definite_assignment_test.dart
- M pkg/analyzer/test/id_tests/definite_unassignment_test.dart
- M pkg/analyzer/test/id_tests/nullability_test.dart
- M pkg/analyzer/test/id_tests/type_promotion_test.dart
- M pkg/analyzer/test/src/dart/ast/ast_test.dart
- M pkg/analyzer/test/src/dart/ast/element_locator_test.dart
- M pkg/analyzer/test/src/dart/ast/to_source_visitor_test.dart
- M pkg/analyzer/test/src/dart/resolution/assignment_test.dart
- M pkg/analyzer/test/src/dart/resolution/extension_method_test.dart
- M pkg/analyzer/test/src/dart/resolution/function_reference_test.dart
- M pkg/analyzer/test/src/diagnostics/use_of_nullable_value_test.dart
- M pkg/analyzer/test/src/summary/elements/const_test.dart
- M pkg/analyzer/test/src/summary/resolved_ast_printer.dart
- M pkg/analyzer/test/src/wolf/ir/ast_to_ir_test.dart
Change size: XL
Delta: 45 files changed, 1760 insertions(+), 168 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Paul Berry
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages