[M] Change in dart/sdk[main]: [ Service ] Add support for ID zones to package:dart_runtime_service_vm

0 views

Skip to first unread message

Ben Konyi (Gerrit)

unread,

Mar 26, 2026, 5:21:35 PM (4 days ago) Mar 26

to Nicholas Shahan, Jessy Yameogo, Mark Zhou, Srujan Gaddam, rev...@dartlang.org

Attention needed from Jessy Yameogo and Nicholas Shahan

Ben Konyi voted Commit-Queue+1

Commit-Queue

Open in Gerrit

Related details

Attention is currently required from:

Jessy Yameogo
Nicholas Shahan

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nicholas Shahan (Gerrit)

unread,

1:59 PM (7 hours ago) 1:59 PM

to Ben Konyi, Commit Queue, Jessy Yameogo, Mark Zhou, Srujan Gaddam, rev...@dartlang.org

Attention needed from Ben Konyi and Jessy Yameogo

Nicholas Shahan voted and added 1 comment

Votes added by Nicholas Shahan

Code-Review

1 comment

File pkg/dart_runtime_service_vm/lib/src/dart_runtime_service_vm_rpcs.dart

Line 30, Patchset 2 (Latest): static const _kIdZoneId = 'idZoneId';

Nicholas Shahan . unresolved

The two "Id" portions of this name read a little awkward. Is there some history behind this? What does the leading "Id" actually mean?

Open in Gerrit

Related details

Attention is currently required from:

Ben Konyi
Jessy Yameogo

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages