[L] Change in dart/sdk[main]: [CFE] Expression evaluation: access private members in superclasses

0 views
Skip to first unread message

Johnni Winther (Gerrit)

unread,
Oct 29, 2025, 10:45:22 AM (4 days ago) Oct 29
to Jens Johansen, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Jens Johansen

Johnni Winther voted and added 1 comment

Votes added by Johnni Winther

Code-Review+1

1 comment

File pkg/front_end/lib/src/base/incremental_compiler.dart
Line 2594, Patchset 3 (Latest): if (setter && field.isFinal) continue;
Johnni Winther . unresolved

This should be `!field.hasSetter` since late final fields without initializers have setters.

Open in Gerrit

Related details

Attention is currently required from:
  • Jens Johansen
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ifcd7ec34ecab0d8f2c50506ff8c24e6590ddafa2
Gerrit-Change-Number: 458260
Gerrit-PatchSet: 3
Gerrit-Owner: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Attention: Jens Johansen <je...@google.com>
Gerrit-Comment-Date: Wed, 29 Oct 2025 14:45:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Jens Johansen (Gerrit)

unread,
Oct 31, 2025, 4:38:25 AM (2 days ago) Oct 31
to Johnni Winther, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther

Jens Johansen voted and added 1 comment

Votes added by Jens Johansen

Commit-Queue+1

1 comment

File pkg/front_end/lib/src/base/incremental_compiler.dart
Line 2594, Patchset 3: if (setter && field.isFinal) continue;
Johnni Winther . resolved

This should be `!field.hasSetter` since late final fields without initializers have setters.

Jens Johansen

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Johnni Winther
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ifcd7ec34ecab0d8f2c50506ff8c24e6590ddafa2
Gerrit-Change-Number: 458260
Gerrit-PatchSet: 4
Gerrit-Owner: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Fri, 31 Oct 2025 08:38:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Johnni Winther <johnni...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Johnni Winther (Gerrit)

unread,
Oct 31, 2025, 7:54:28 AM (2 days ago) Oct 31
to Jens Johansen, Commit Queue, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Jens Johansen

Johnni Winther voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jens Johansen
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: Ifcd7ec34ecab0d8f2c50506ff8c24e6590ddafa2
Gerrit-Change-Number: 458260
Gerrit-PatchSet: 4
Gerrit-Owner: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Attention: Jens Johansen <je...@google.com>
Gerrit-Comment-Date: Fri, 31 Oct 2025 11:54:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages