[M] Change in dart/sdk[main]: Fine. Store formal parameter default values separately from FunctionT...
0 views
Skip to first unread message
Konstantin Shcheglov (Gerrit)
Jun 9, 2026, 2:07:10 PM (2 days ago) Jun 9
to Paul Berry, Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther and Paul Berry
Konstantin Shcheglov voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Johnni Winther
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johnni Winther (Gerrit)
Jun 10, 2026, 3:43:13 AM (yesterday) Jun 10
to Konstantin Shcheglov, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov and Paul Berry
Johnni Winther voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Konstantin Shcheglov
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Jun 10, 2026, 12:25:22 PM (yesterday) Jun 10
to Johnni Winther, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Paul Berry
Konstantin Shcheglov voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 10, 2026, 1:29:39 PM (yesterday) Jun 10
to Konstantin Shcheglov, Johnni Winther, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fine. Store formal parameter default values separately from FunctionType(s).
A type is just a type, it should not attempt to carry element semantics.
Change-Id: I9dacc4f5cc4060d862f7e1bb1ececdd9dc1a303c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510420
Reviewed-by: Johnni Winther <johnni...@google.com>
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Files:
- M pkg/analyzer/lib/src/dart/analysis/driver.dart
- M pkg/analyzer/lib/src/fine/manifest_ast.dart
- M pkg/analyzer/lib/src/fine/manifest_item.dart
- M pkg/analyzer/lib/src/fine/manifest_type.dart
- M pkg/analyzer/test/src/dart/analysis/driver_test.dart
- M pkg/analyzer/test/src/dart/analysis/result_printer.dart
Change size: M
Delta: 6 files changed, 116 insertions(+), 27 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Johnni Winther
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages