[M] Change in dart/sdk[main]: [ Service ] Add support for binary events in package:dart_runtime_ser...

0 views

Skip to first unread message

Ben Konyi (Gerrit)

unread,

Mar 25, 2026, 11:56:56 AM (5 days ago) Mar 25

to Jessy Yameogo, Nicholas Shahan, Srujan Gaddam, Mark Zhou, rev...@dartlang.org

Attention needed from Jessy Yameogo and Nicholas Shahan

Ben Konyi voted Commit-Queue+1

Commit-Queue

Open in Gerrit

Related details

Attention is currently required from:

Jessy Yameogo
Nicholas Shahan

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jessy Yameogo (Gerrit)

unread,

Mar 26, 2026, 6:09:28 PM (4 days ago) Mar 26

to Ben Konyi, Commit Queue, Nicholas Shahan, Srujan Gaddam, Mark Zhou, rev...@dartlang.org

Attention needed from Ben Konyi and Nicholas Shahan

Jessy Yameogo voted Code-Review+1

Code-Review

Open in Gerrit

Related details

Attention is currently required from:

Ben Konyi
Nicholas Shahan

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Nicholas Shahan (Gerrit)

unread,

2:17 PM (6 hours ago) 2:17 PM

to Ben Konyi, Jessy Yameogo, Commit Queue, Srujan Gaddam, Mark Zhou, rev...@dartlang.org

Attention needed from Ben Konyi

Nicholas Shahan added 1 comment

File pkg/dart_runtime_service/lib/src/clients.dart

Line 35, Patchset 1:

    _clientPeer = json_rpc.Peer(
      // Manually create a StreamChannel<String> instead of calling
      // .cast<String>() as cast() results in addStream() being called,
      // binding the underlying sink. This results in a StateError being thrown
      // if we try and add directly to the sink, which we do for binary events
      // in [EventStreamMethod]'s streamNotify().
      StreamChannel<String>(
        connection.stream.cast(),
        StreamController(sync: true)
          ..stream
              .cast<String>()
              .listen((event) => connection.sink.add(event))
              .onDone(() => connection.sink.close()),
      ),
      strictProtocolChecks: false,
    );

Nicholas Shahan . unresolved

Could we introduce some local variables, I'm finding this really hard to parse.

Open in Gerrit

Related details

Attention is currently required from:

Ben Konyi

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages