[M] Change in dart/sdk[main]: [migrate] Support Dart 3 backwards compatibility.
0 views
Skip to first unread message
Kallen Tu (Gerrit)
Jul 14, 2026, 5:49:41 PM (2 days ago) Jul 14
to Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson
Kallen Tu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kallen Tu
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Kallen Tu . resolved
I don't really see us getting around this since we don't import the pub package itself. But the migration tool doesn't work smoothly without this special case since so many packages aren't migrated.
Related details
Attention is currently required from:
- Brian Wilkerson
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Wilkerson (Gerrit)
Jul 15, 2026, 2:54:14 PM (13 hours ago) Jul 15
to Kallen Tu, Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Kallen Tu
Brian Wilkerson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Brian Wilkerson
| Code-Review | +1 |
1 comment
File pkg/analysis_server/lib/src/utilities/pubspec.dart
Line 28, Patchset 2 (Latest):
// Apply Dart 3 package compatibility re-interpretation:Brian Wilkerson . unresolved
I don't think I ever knew that this was a thing. Could you include the URL from the CL comment (https://dart.dev/resources/dart-3-migration#dart-3-backwards-compatibility) in this comment for future reference?
Related details
Attention is currently required from:
- Kallen Tu
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kallen Tu (Gerrit)
Jul 15, 2026, 3:39:37 PM (12 hours ago) Jul 15
to Brian Wilkerson, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Kallen Tu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kallen Tu
| Commit-Queue | +2 |
1 comment
File pkg/analysis_server/lib/src/utilities/pubspec.dart
Line 28, Patchset 2:
// Apply Dart 3 package compatibility re-interpretation:Brian Wilkerson . resolved
I don't think I ever knew that this was a thing. Could you include the URL from the CL comment (https://dart.dev/resources/dart-3-migration#dart-3-backwards-compatibility) in this comment for future reference?
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jul 15, 2026, 4:06:26 PM (12 hours ago) Jul 15
to Kallen Tu, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: pkg/analysis_server/lib/src/utilities/pubspec.dart
Insertions: 1, Deletions: 0.
@@ -29,6 +29,7 @@
// If the package is null-safe (min SDK >= 2.12.0) and has max constraint
// <3.0.0 (which is parsed as max: 3.0.0-0, includeMax: false),
// re-interpret the max constraint as <4.0.0.
+ // https://dart.dev/resources/dart-3-migration#dart-3-backwards-compatibility
if (constraint is VersionRange) {
var min = constraint.min;
var max = constraint.max;
```
Change information
Commit message:
[migrate] Support Dart 3 backwards compatibility.
Pub reinterprets `<3.0.0` as `<4.0.0` when the lower constraint is
`2.12` or higher which allows users to use Dart 3 sound null safety
with packages that support 2.12 null safety.
https://dart.dev/resources/dart-3-migration#dart-3-backwards-compatibility
Currently, the migrate tool doesn't take this into consideration and
will flag the constraint as a dependency error.
This CL will add the extra case onto the check.
Change-Id: I4eff59843668ebb9cff1a13c7f3ad54fec64a547
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/524200
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Kallen Tu <kall...@google.com>
Files:
- M pkg/analysis_server/lib/src/utilities/pubspec.dart
- M pkg/analysis_server/test/lsp/migrate_test.dart
Change size: M
Delta: 2 files changed, 62 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brian Wilkerson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages