[M] Change in dart/sdk[main]: CQ. Store FormalParameterElementImpl flags.
0 views
Skip to first unread message
Konstantin Shcheglov (Gerrit)
Jun 23, 2026, 12:46:34 AM (23 hours ago) Jun 23
to Paul Berry, Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther and Paul Berry
Konstantin Shcheglov voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Johnni Winther
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johnni Winther (Gerrit)
Jun 23, 2026, 9:04:10 AM (15 hours ago) Jun 23
to Konstantin Shcheglov, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Konstantin Shcheglov and Paul Berry
Johnni Winther voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Konstantin Shcheglov
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Jun 23, 2026, 1:46:00 PM (10 hours ago) Jun 23
to Johnni Winther, Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Paul Berry
Konstantin Shcheglov voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Paul Berry
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jun 23, 2026, 2:45:24 PM (9 hours ago) Jun 23
to Konstantin Shcheglov, Johnni Winther, Paul Berry, dart-analys...@google.com, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: pkg/analyzer/lib/src/dart/analysis/driver.dart
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
CQ. Store FormalParameterElementImpl flags.
Store FormalParameterElementImpl flags in the summary element data
instead of encoding inherited covariance as resolution data.
This makes inherited covariance part of generated element flag storage
and allows isCovariant to use the stored value without forcing enclosing
executable resolution. Read and write parameter element flags for
constructors, methods, accessors, and top-level functions before their
deferred resolution data.
Bump the summary data version for the format change.
Change-Id: Ia99ea8642564ae221956af5e8cada30f8ecf9016
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/516180
Commit-Queue: Konstantin Shcheglov <sche...@google.com>
Reviewed-by: Johnni Winther <johnni...@google.com>
Files:
- M pkg/analyzer/lib/src/dart/analysis/driver.dart
- M pkg/analyzer/lib/src/dart/element/element.dart
- M pkg/analyzer/lib/src/summary2/bundle_reader.dart
- M pkg/analyzer/lib/src/summary2/bundle_writer.dart
- M pkg/analyzer/test/src/summary/elements/formal_parameter_test.dart
- M pkg/analyzer/test/src/summary/top_level_inference_test.dart
Change size: M
Delta: 6 files changed, 65 insertions(+), 57 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Johnni Winther
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages