[M] Change in dart/sdk[main]: [DAS] Fixes some `Replace 'final' with 'var'` false-negatives

0 views

Skip to first unread message

Felipe Morschel (Gerrit)

unread,

7:46 AM (8 hours ago) 7:46 AM

to dart-analys...@google.com, rev...@dartlang.org

Felipe Morschel has uploaded the change for review

Commit message

[DAS] Fixes some `Replace 'final' with 'var'` false-negatives

Fixes: https://github.com/dart-lang/sdk/issues/62689

Change-Id: I5ccb3571986d518e015504abe9e482e815676052

Change information

Files:

M pkg/analysis_server/lib/src/services/correction/dart/replace_final_with_var.dart
M pkg/analysis_server/test/src/services/correction/fix/replace_final_with_var_test.dart

Change size: M

Delta: 2 files changed, 52 insertions(+), 0 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Samuel Rawlins (Gerrit)

unread,

10:32 AM (6 hours ago) 10:32 AM

to Felipe Morschel, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org

Attention needed from Brian Wilkerson and Felipe Morschel

Samuel Rawlins voted Code-Review+1

Code-Review

Open in Gerrit

Related details

Attention is currently required from:

Brian Wilkerson
Felipe Morschel

Submit Requirements:

Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages