[XL] Change in dart/sdk[main]: Add documentation for most of the errors and warnings in analysis opt...

0 views
Skip to first unread message

Brian Wilkerson (Gerrit)

unread,
Oct 16, 2025, 5:27:05 PMOct 16
to Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Samuel Rawlins
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I9b059524ffcedc1e3b8a7602b7124f419095a702
Gerrit-Change-Number: 455481
Gerrit-PatchSet: 1
Gerrit-Owner: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
Gerrit-Attention: Samuel Rawlins <sraw...@google.com>
Gerrit-Comment-Date: Thu, 16 Oct 2025 21:27:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Samuel Rawlins (Gerrit)

unread,
Oct 17, 2025, 12:34:05 PMOct 17
to Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Brian Wilkerson

Samuel Rawlins voted and added 2 comments

Votes added by Samuel Rawlins

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Samuel Rawlins . resolved

Thanks for these additional 600 lines of documentation! Huge benefit!

File pkg/analyzer/test/src/diagnostics/analysis_options/recursive_include_file_test.dart
Line 29, Patchset 1 (Latest): "The URI 'analysis_options.yaml' included in "
Samuel Rawlins . resolved

Thanks for these improvements!

Open in Gerrit

Related details

Attention is currently required from:
  • Brian Wilkerson
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I9b059524ffcedc1e3b8a7602b7124f419095a702
    Gerrit-Change-Number: 455481
    Gerrit-PatchSet: 1
    Gerrit-Owner: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Comment-Date: Fri, 17 Oct 2025 16:34:01 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Connie Ooi (Gerrit)

    unread,
    Nov 26, 2025, 6:10:02 PM (4 days ago) Nov 26
    to Brian Wilkerson, Samuel Rawlins, dart-analys...@google.com, rev...@dartlang.org
    Attention needed from Brian Wilkerson

    Connie Ooi added 21 comments

    File pkg/analyzer/messages.yaml
    Line 91, Patchset 2 (Latest): The following code produces this diagnostic because the included file
    isn't valid YAML (the `analyzer` section has two `enable-experiment` keys
    in the same map):
    Connie Ooi . unresolved

    "The following code produces this diagnostic because the included file isn't valid YAML: the `analyzer` map contains duplicate `enable-experiment` keys."

    Line 105, Patchset 2 (Latest): If the file is intended to be included, then change the content of the
    included file to be valid YAML:
    Connie Ooi . unresolved

    "If the file is intended to be included, then correct the included file to be valid YAML:"

    Line 154, Patchset 2 (Latest): Change the content of the file to be valid YAML:
    Connie Ooi . unresolved

    "Correct the file to be valid YAML:"

    Line 175, Patchset 2 (Latest): The analyzer produces this diagnostic when an option used in an analysis
    options file is deprecated.
    Connie Ooi . unresolved

    "The analyzer produces this diagnostic when an option in an analysis options file is deprecated."

    Line 191, Patchset 2 (Latest): If there's a new way to specify the same information, then update the file
    to use the new way:
    Connie Ooi . unresolved

    "If a replacement option or format exists, update the file to use it:"

    Line 201, Patchset 2 (Latest): If there isn't a new way to specify the same information, then remove the
    option.
    Connie Ooi . unresolved

    "If no replacement is available, remove the deprecated option."

    Line 224, Patchset 2 (Latest): The analyzer produces this diagnostic when a lint rule is enabled when the
    rule is deprecated and should no longer be used.
    Connie Ooi . unresolved

    "The analyzer produces this diagnostic when an enabled lint rule is deprecated."

    Line 242, Patchset 2 (Latest): If there's a replacement for the rule, then enable the new lint rule:
    Connie Ooi . unresolved

    "If a replacement rule exists, enable it:"

    Line 252, Patchset 2 (Latest): If there isn't a replacement for the rule, then remove the deprecated lint
    rule from the list:
    Connie Ooi . unresolved

    "If no replacement rule exists, remove the deprecated lint rule from the list:"

    Line 359, Patchset 2 (Latest): The analyzer produces this diagnostic when an analysis options file
    contains an `include` key, and the included URI either can't be resolved
    or the file doesn't exist.
    Connie Ooi . unresolved

    "The analyzer produces this diagnostic when an `include` key in an analysis options file specifies a URI that either can't be resolved or doesn't exist."

    Line 375, Patchset 2 (Latest): If the URI is incorrect, replace the URI with a URI that exists:
    Connie Ooi . unresolved

    "If the URI is incorrect, replace it with a correct URI:"

    Line 382, Patchset 2 (Latest): If the URI is correct but the package isn't a dependency, then add a
    dev-dependency to the package in the `pubspec.yaml` file and run either
    `dart pub get` or `flutter pub get`.
    Connie Ooi . unresolved

    "If the URI is correct but the package isn't a dependency, add a dev_dependency for the package to the `pubspec.yaml` file and run `dart pub get` or `flutter pub get`."

    Line 480, Patchset 2 (Latest): If you want to specify the option, then provide a valid value for it:
    Connie Ooi . unresolved

    If you specify the option, provide a valid value for it.

    Line 490, Patchset 2 (Latest): If you don't need to specify the option, then remove it:
    Connie Ooi . unresolved

    If you don't need the option, remove it.

    Line 509, Patchset 2 (Latest): The analyzer produces this diagnostic when an analysis options file
    contains a section (key) and the content of that section is not the
    expected format, such as having a list where a map is expected.
    Connie Ooi . unresolved

    The analyzer produces this diagnostic when an analysis options file contains a configuration section (key) whose content is not in the expected data structure or format. This occurs when the configuration requires a map but is provided a list.

    Line 560, Patchset 2 (Latest): Given a file named `analysis_options.yaml` in a directory below the root
    directory of a package, the following code produces this diagnostic
    because it defined plugins:
    Connie Ooi . unresolved

    Given an `analysis_options.yaml` file located in a subdirectory of the package root, the following code produces this diagnostic because it attempts to define plugins there:

    Line 676, Patchset 2 (Latest): The analyzer produces this diagnostic when an analysis options file
    enables a lint that isn't defined.
    Connie Ooi . unresolved

    The analyzer produces this diagnostic when an analysis options file attempts to enable a lint rule that is not defined

    Line 704, Patchset 2 (Latest): If there is no lint like the one being flagged, then remove the undefined
    lint:
    Connie Ooi . unresolved

    If there is no lint corresponding to the flagged entry, then remove the undefined lint:

    Line 798, Patchset 2 (Latest): If there is a supported option that was intended to be used, then replace the unsupported option with the supported one:
    Connie Ooi . unresolved

    If you intended to use a supported option, then replace the unsupported option with the supported one.

    Line 807, Patchset 2 (Latest): If there is no option for what you're trying to accomplish, then remove the unsupported option:
    Connie Ooi . unresolved

    If no option exists for your intended purpose, then remove the unsupported option:

    Line 856, Patchset 2 (Latest): If there is a valid value that specifies the intended behavior, then
    replace the unsupported value with it:
    Connie Ooi . unresolved

    If a valid value specifies the intended behavior, then replace the unsupported value with it:

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Brian Wilkerson
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: sdk
    Gerrit-Branch: main
    Gerrit-Change-Id: I9b059524ffcedc1e3b8a7602b7124f419095a702
    Gerrit-Change-Number: 455481
    Gerrit-PatchSet: 2
    Gerrit-Owner: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Reviewer: Connie Ooi <conn...@google.com>
    Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>
    Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>
    Gerrit-Comment-Date: Wed, 26 Nov 2025 23:09:59 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages