[M] Change in dart/sdk[main]: analyzer: Guard DotShorthandConstructorInvocation from Deprecated.ins...
0 views
Skip to first unread message
Kallen Tu (Gerrit)
Sep 26, 2025, 1:42:35 PM (3 days ago) Sep 26
to Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Kallen Tu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kallen Tu
| Code-Review | +1 |
1 comment
File pkg/analyzer/lib/src/error/deprecated_functionality_verifier.dart
Line 55, Patchset 4 (Latest):
void dotShorthandInvocation(DotShorthandInvocation node) {Kallen Tu . unresolved
If you haven't already, maybe check with dot shorthand invocations as well? (These would be named constructor instantiations like `.named()`)
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Sep 26, 2025, 2:47:22 PM (3 days ago) Sep 26
to Kallen Tu, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Samuel Rawlins added 1 comment![]( "Open in Gerrit")
File pkg/analyzer/lib/src/error/deprecated_functionality_verifier.dart
If you haven't already, maybe check with dot shorthand invocations as well? (These would be named constructor instantiations like `.named()`)
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Konstantin Shcheglov (Gerrit)
Sep 26, 2025, 2:50:28 PM (3 days ago) Sep 26
to Samuel Rawlins, Kallen Tu, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Konstantin Shcheglov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Sep 26, 2025, 3:24:47 PM (3 days ago) Sep 26
to Konstantin Shcheglov, Kallen Tu, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Samuel Rawlins voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit Queue (Gerrit)
Sep 26, 2025, 3:25:03 PM (3 days ago) Sep 26
to Samuel Rawlins, Konstantin Shcheglov, Kallen Tu, dart-analys...@google.com, rev...@dartlang.org
Commit Queue submitted the change![]( "Open in Gerrit")
Change information
Commit message:
analyzer: Guard DotShorthandConstructorInvocation from Deprecated.instantiate
DotShorthandConstructorInvocation does not have a ConstructorName,
so we convert `DeprecatedFunctionalityVerifier.constructorName` into
`._checkForDeprecatedInstantiate`, and then call that in
`constructorName`, `dotShorthandConstructorInvocation` and
`instanceCreationExpression`.
Change-Id: I04d0aea70afce94fe2e574c38e02bbd5dbb7933f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/451661
Reviewed-by: Kallen Tu <kall...@google.com>
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Commit-Queue: Samuel Rawlins <sraw...@google.com>
Files:
- M pkg/analyzer/lib/src/error/deprecated_functionality_verifier.dart
- M pkg/analyzer/test/src/diagnostics/deprecated_instantiate_test.dart
Change size: M
Delta: 2 files changed, 74 insertions(+), 12 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Konstantin Shcheglov, +1 by Kallen Tu
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages