[L] Change in dart/sdk[main]: [dart2wasm] Enable --gufa also in deferred loading scenario
0 views
Skip to first unread message
Martin Kustermann (Gerrit)
May 18, 2026, 6:31:41 AMMay 18
to Srujan Gaddam, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Srujan Gaddam
Martin Kustermann added 1 comment![]( "Open in Gerrit")
Commit Message
Line 17, Patchset 2 (Latest):
[0] https://github.com/WebAssembly/binaryen/issues/8691Martin Kustermann . unresolved
This revealed some other binaryen bugs. Filed one for now:
Related details
Attention is currently required from:
- Srujan Gaddam
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Srujan Gaddam (Gerrit)
May 18, 2026, 4:52:57 PMMay 18
to Martin Kustermann, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Martin Kustermann
Srujan Gaddam voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Martin Kustermann
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Martin Kustermann (Gerrit)
Jun 2, 2026, 4:35:16 PM (yesterday) Jun 2
to Srujan Gaddam, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Srujan Gaddam
Martin Kustermann added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Commit Message
Line 17, Patchset 2:
[0] https://github.com/WebAssembly/binaryen/issues/8691Martin Kustermann . resolved
This revealed some other binaryen bugs. Filed one for now:
Martin Kustermann
The binaryen bug was marked as fixed, so we can roll new version in this CL.
Related details
Attention is currently required from:
- Srujan Gaddam
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Srujan Gaddam (Gerrit)
Jun 2, 2026, 4:47:50 PM (yesterday) Jun 2
to Martin Kustermann, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Martin Kustermann
Srujan Gaddam voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Martin Kustermann
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Srujan Gaddam (Gerrit)
Jun 2, 2026, 4:48:37 PM (yesterday) Jun 2
to Martin Kustermann, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Martin Kustermann
Srujan Gaddam added 1 comment![]( "Open in Gerrit")
File pkg/dart2wasm/lib/compile.dart
Line 194, Patchset 4 (Latest):
'-Os',
'--gufa',
'-Os',
'-Os',Srujan Gaddam . unresolved
You may have mentioned this before, but why do we need the multiple `-Os`?
Related details
Attention is currently required from:
- Martin Kustermann
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Martin Kustermann (Gerrit)
3:27 AM (14 hours ago) 3:27 AM
to Srujan Gaddam, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart2wasm-t...@google.com, rev...@dartlang.org
Attention needed from Srujan Gaddam
Martin Kustermann added 1 comment![]( "Open in Gerrit")
File pkg/dart2wasm/lib/compile.dart
Line 194, Patchset 4 (Latest):
'-Os',
'--gufa',
'-Os',
'-Os',Srujan Gaddam . unresolved
You may have mentioned this before, but why do we need the multiple `-Os`?
Martin Kustermann
Yeah, that's because unlike normal compiler like GCC/Clang, `wasm-opt` runs a fixed pipeline of optimization passes with `-Os` which leave unoptimized things behind. The recommended way to use it is to run it multiple times, see the issue I've filed
https://github.com/WebAssembly/binaryen/issues/8077
Though it seems there's more binaryen bugs with the new roll, so this CL will have to wait until they are fixed as well
Related details
Attention is currently required from:
- Srujan Gaddam
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages