[M] Change in dart/sdk[main]: [kernel] Make InvalidExpression.message non-nullable

0 views
Skip to first unread message

Johnni Winther (Gerrit)

unread,
Nov 27, 2025, 3:51:33 AM (2 days ago) Nov 27
to Jens Johansen, Commit Queue, Alexander Markov, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Jens Johansen

Johnni Winther voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jens Johansen
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I0b88dfa01a8e2caae8631266310aa3b0a5f5e0bc
Gerrit-Change-Number: 464685
Gerrit-PatchSet: 1
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-CC: Alexander Markov <alexm...@google.com>
Gerrit-Attention: Jens Johansen <je...@google.com>
Gerrit-Comment-Date: Thu, 27 Nov 2025 08:51:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jens Johansen (Gerrit)

unread,
Nov 27, 2025, 5:53:26 AM (2 days ago) Nov 27
to Johnni Winther, Commit Queue, Alexander Markov, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther

Jens Johansen voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Johnni Winther
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I0b88dfa01a8e2caae8631266310aa3b0a5f5e0bc
Gerrit-Change-Number: 464685
Gerrit-PatchSet: 2
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Jens Johansen <je...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-CC: Alexander Markov <alexm...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Thu, 27 Nov 2025 10:53:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Nov 27, 2025, 8:15:10 AM (2 days ago) Nov 27
to Johnni Winther, Jens Johansen, Alexander Markov, dart-fe-te...@google.com, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
[kernel] Make InvalidExpression.message non-nullable
Change-Id: I0b88dfa01a8e2caae8631266310aa3b0a5f5e0bc
Reviewed-by: Jens Johansen <je...@google.com>
Files:
  • M pkg/front_end/lib/src/fragment/constructor/encoding.dart
  • M pkg/front_end/lib/src/kernel/body_builder.dart
  • M pkg/front_end/testcases/regress/extension_type_declared_instance_field_01.dart.strong.expect
  • M pkg/front_end/testcases/regress/extension_type_declared_instance_field_01.dart.strong.modular.expect
  • M pkg/front_end/testcases/regress/extension_type_declared_instance_field_01.dart.strong.transformed.expect
  • M pkg/front_end/testcases/regress/extension_type_declared_instance_field_03.dart.strong.expect
  • M pkg/front_end/testcases/regress/extension_type_declared_instance_field_03.dart.strong.modular.expect
  • M pkg/front_end/testcases/regress/extension_type_declared_instance_field_03.dart.strong.transformed.expect
  • M pkg/kernel/lib/binary/ast_from_binary.dart
  • M pkg/kernel/lib/binary/ast_to_binary.dart
  • M pkg/kernel/lib/src/ast/expressions.dart
  • M pkg/kernel/lib/src/node_creator.dart
  • M pkg/kernel/lib/target/targets.dart
  • M pkg/kernel/lib/text/ast_to_text.dart
Change size: M
Delta: 14 files changed, 59 insertions(+), 21 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Jens Johansen
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I0b88dfa01a8e2caae8631266310aa3b0a5f5e0bc
Gerrit-Change-Number: 464685
Gerrit-PatchSet: 3
Gerrit-Owner: Johnni Winther <johnni...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages