[S] Change in dart/sdk[main]: meta: Annotate _Literal with TargetKind.constructor
0 views
Skip to first unread message
Konstantin Shcheglov (Gerrit)
Dec 30, 2025, 12:17:31 PM (18 hours ago) Dec 30
to Samuel Rawlins, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Samuel Rawlins
Konstantin Shcheglov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Konstantin Shcheglov
| Code-Review | +1 |
1 comment
File pkg/analyzer/test/src/diagnostics/invalid_literal_annotation_test.dart
Line 44, Patchset 3 (Parent):
test_extensionType_declaration() async {Konstantin Shcheglov . unresolved
Why are we removing these tests?
Not working? Not interesting / obvious?
Related details
Attention is currently required from:
- Samuel Rawlins
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Dec 30, 2025, 12:20:24 PM (18 hours ago) Dec 30
to Konstantin Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Samuel Rawlins added 1 comment![]( "Open in Gerrit")
File pkg/analyzer/test/src/diagnostics/invalid_literal_annotation_test.dart
Line 44, Patchset 3 (Parent):
test_extensionType_declaration() async {Konstantin Shcheglov . resolved
Why are we removing these tests?
Not working? Not interesting / obvious?
Samuel Rawlins
These tests are for code which is no longer related to this warning. Reporting on an extension type or a method is the purview of the `invalid_annotation_target` warning. I'll note this in the summary.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Dec 30, 2025, 12:20:53 PM (18 hours ago) Dec 30
to Konstantin Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Samuel Rawlins voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Samuel Rawlins (Gerrit)
Dec 30, 2025, 12:29:41 PM (18 hours ago) Dec 30
to Konstantin Shcheglov, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Samuel Rawlins submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
meta: Annotate _Literal with TargetKind.constructor
Work towards https://github.com/dart-lang/sdk/issues/62253
The removed tests are for code which is no longer related to this
warning. Reporting on an extension type or a method is the purview of
the `invalid_annotation_target` warning. I'll note this in the summary.
Change-Id: Ide349bc1e414da339b9e89da25e383859a8144a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/469761
Reviewed-by: Konstantin Shcheglov <sche...@google.com>
Files:
- M pkg/analyzer/lib/src/error/annotation_verifier.dart
- M pkg/analyzer/messages.yaml
- M pkg/analyzer/test/src/diagnostics/invalid_literal_annotation_test.dart
- M pkg/analyzer_testing/lib/src/mock_packages/meta/meta.dart
- M pkg/meta/lib/meta.dart
Change size: S
Delta: 5 files changed, 11 insertions(+), 36 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Konstantin Shcheglov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages