[M] Change in dart/sdk[main]: [cfe] Add test for issue 63506

0 views
Skip to first unread message

Johnni Winther (Gerrit)

unread,
6:30 AM (12 hours ago) 6:30 AM
to Paul Berry, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther and Paul Berry

Johnni Winther voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Johnni Winther
  • Paul Berry
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I568ba16bc6ec62f3b45cd6742ef5f84c7066b230
Gerrit-Change-Number: 508920
Gerrit-PatchSet: 1
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Paul Berry <paul...@google.com>
Gerrit-Attention: Paul Berry <paul...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Wed, 03 Jun 2026 10:30:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Paul Berry (Gerrit)

unread,
1:42 PM (5 hours ago) 1:42 PM
to Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther

Paul Berry voted and added 1 comment

Votes added by Paul Berry

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Paul Berry . unresolved

lgtm; triggering auto-submit.

Johnni, would you mind adding a language test as well? I noticed that https://dart-review.googlesource.com/c/sdk/+/507401 didn't make any change in language test expectations, which means that this case wasn't covered at all by language tests. It would be nice to cover it to avoid a regression in the analyzer.

Open in Gerrit

Related details

Attention is currently required from:
  • Johnni Winther
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I568ba16bc6ec62f3b45cd6742ef5f84c7066b230
Gerrit-Change-Number: 508920
Gerrit-PatchSet: 1
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Paul Berry <paul...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Wed, 03 Jun 2026 17:42:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Paul Berry (Gerrit)

unread,
2:17 PM (4 hours ago) 2:17 PM
to Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-fe-te...@google.com, rev...@dartlang.org
Attention needed from Johnni Winther

Paul Berry added 1 comment

Patchset-level comments
Paul Berry . resolved

Force submitting to bypass unrelated ddc-linux-chrome-try failures.

Open in Gerrit

Related details

Attention is currently required from:
  • Johnni Winther
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I568ba16bc6ec62f3b45cd6742ef5f84c7066b230
Gerrit-Change-Number: 508920
Gerrit-PatchSet: 1
Gerrit-Owner: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Johnni Winther <johnni...@google.com>
Gerrit-Reviewer: Paul Berry <paul...@google.com>
Gerrit-Attention: Johnni Winther <johnni...@google.com>
Gerrit-Comment-Date: Wed, 03 Jun 2026 18:17:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Paul Berry (Gerrit)

unread,
2:17 PM (4 hours ago) 2:17 PM
to Johnni Winther, dart-...@luci-project-accounts.iam.gserviceaccount.com, dart-fe-te...@google.com, rev...@dartlang.org

Paul Berry submitted the change

Change information

Commit message:
[cfe] Add test for issue 63506

This adds a test for the problem reported in #63506. The problem has been fixed recently in https://dart-review.googlesource.com/c/sdk/+/507401

Closes #63506
Change-Id: I568ba16bc6ec62f3b45cd6742ef5f84c7066b230
Reviewed-by: Paul Berry <paul...@google.com>
Auto-Submit: Johnni Winther <johnni...@google.com>
Files:
  • A pkg/front_end/testcases/primary_constructors/issue63506.dart
  • A pkg/front_end/testcases/primary_constructors/issue63506.dart.strong.expect
  • A pkg/front_end/testcases/primary_constructors/issue63506.dart.strong.modular.expect
  • A pkg/front_end/testcases/primary_constructors/issue63506.dart.strong.outline.expect
  • A pkg/front_end/testcases/primary_constructors/issue63506.dart.strong.transformed.expect
  • A pkg/front_end/testcases/primary_constructors/issue63506.dart.textual_outline.expect
  • A pkg/front_end/testcases/primary_constructors/issue63506.dart.textual_outline_modelled.expect
Change size: M
Delta: 7 files changed, 100 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Paul Berry
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I568ba16bc6ec62f3b45cd6742ef5f84c7066b230
Gerrit-Change-Number: 508920
Gerrit-PatchSet: 2
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages