[L] Change in dart/sdk[main]: [perf tesing]Add an option to write out a log with performance relate...

0 views
Skip to first unread message

Brian Wilkerson (Gerrit)

unread,
Dec 17, 2025, 10:27:13 AM (4 days ago) Dec 17
to Keerti Parthasarathy, Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org
Attention needed from Keerti Parthasarathy

Brian Wilkerson voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Keerti Parthasarathy
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I3e5ff4b77c62d36e47ba7bac8f656b19ba19c457
Gerrit-Change-Number: 468600
Gerrit-PatchSet: 6
Gerrit-Owner: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
Gerrit-Attention: Keerti Parthasarathy <kee...@google.com>
Gerrit-Comment-Date: Wed, 17 Dec 2025 15:27:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Keerti Parthasarathy (Gerrit)

unread,
Dec 18, 2025, 10:12:00 AM (3 days ago) Dec 18
to Brian Wilkerson, Commit Queue, dart-analys...@google.com, rev...@dartlang.org

Keerti Parthasarathy voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I3e5ff4b77c62d36e47ba7bac8f656b19ba19c457
Gerrit-Change-Number: 468600
Gerrit-PatchSet: 6
Gerrit-Owner: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
Gerrit-Comment-Date: Thu, 18 Dec 2025 15:11:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Commit Queue (Gerrit)

unread,
Dec 18, 2025, 10:35:54 AM (3 days ago) Dec 18
to Keerti Parthasarathy, Brian Wilkerson, dart-analys...@google.com, rev...@dartlang.org

Commit Queue submitted the change

Change information

Commit message:
[perf tesing]Add an option to write out a log with performance related data

This is mainly to exercise the performance test framework, for writing
a report for the test runs.

- adds a flag to specify a file
- logs context information and info from the message scheduler

Started with just these two as an example as I was not sure what performance data we do want to record.
Change-Id: I3e5ff4b77c62d36e47ba7bac8f656b19ba19c457
Reviewed-by: Brian Wilkerson <brianwi...@google.com>
Commit-Queue: Keerti Parthasarathy <kee...@google.com>
Files:
  • M pkg/analysis_server/integration_test/server/message_scheduler_test.dart
  • M pkg/analysis_server/lib/src/analysis_server.dart
  • M pkg/analysis_server/lib/src/legacy_analysis_server.dart
  • M pkg/analysis_server/lib/src/lsp/lsp_analysis_server.dart
  • M pkg/analysis_server/lib/src/lsp/lsp_socket_server.dart
  • M pkg/analysis_server/lib/src/scheduler/scheduled_message.dart
  • M pkg/analysis_server/lib/src/scheduler/scheduler_tracking_listener.dart
  • M pkg/analysis_server/lib/src/server/driver.dart
  • M pkg/analysis_server/lib/src/socket_server.dart
  • M pkg/analysis_server/lib/src/status/pages/collect_report_page.dart
  • A pkg/analysis_server/lib/src/status/performance_logger.dart
  • A pkg/analysis_server/lib/src/status/utilities/report_data.dart
  • M pkg/analysis_server/test/socket_server_test.dart
Change size: L
Delta: 13 files changed, 494 insertions(+), 394 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Brian Wilkerson
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: sdk
Gerrit-Branch: main
Gerrit-Change-Id: I3e5ff4b77c62d36e47ba7bac8f656b19ba19c457
Gerrit-Change-Number: 468600
Gerrit-PatchSet: 7
Gerrit-Owner: Keerti Parthasarathy <kee...@google.com>
Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>
Gerrit-Reviewer: Keerti Parthasarathy <kee...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages