[S] Change in dart/sdk[main]: Do not forward `Proxy-Authorization` to the proxied request.
0 views
Skip to first unread message
Jonas Jensen (Gerrit)
Jun 23, 2026, 3:34:27 AM (yesterday) Jun 23
to Brian Quinlan, rev...@dartlang.org
Attention needed from Brian Quinlan
Jonas Jensen voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jonas Jensen
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jonas Jensen . resolved
@bquinlan, I'm not entirely sure this is the right fix.
I'm a little unsure if the proxied connection should even have access to the `_Proxy` object, maybe it's there for debugging purposes or so.
Related details
Attention is currently required from:
- Brian Quinlan
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brian Quinlan (Gerrit)
Jun 23, 2026, 12:42:50 PM (20 hours ago) Jun 23
to Jonas Jensen, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Attention needed from Jonas Jensen
Brian Quinlan voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jonas Jensen
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jonas Jensen (Gerrit)
3:49 AM (5 hours ago) 3:49 AM
to Brian Quinlan, dart-...@luci-project-accounts.iam.gserviceaccount.com, rev...@dartlang.org
Jonas Jensen voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
dart-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
4:16 AM (4 hours ago) 4:16 AM
to Jonas Jensen, Brian Quinlan, rev...@dartlang.org
dart-...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Do not forward `Proxy-Authorization` to the proxied request.
When `HttpClient.findProxy` returns a proxy with authorization included,
we send a `Proxy-Authorization` header when we open a connection to the
proxy server. This header should not be included in the request we send
over the proxy connection (the proxied request).
Fixed: b/521830793
Change-Id: Ibf41aa775aa34ffed317daa40116ecb6a55d55cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/516201
Reviewed-by: Brian Quinlan <bqui...@google.com>
Commit-Queue: Jonas Jensen <jon...@google.com>
Auto-Submit: Jonas Jensen <jon...@google.com>
Files:
- M sdk/lib/_http/http_impl.dart
- M tests/standalone/io/http_proxy_advanced_test.dart
Change size: S
Delta: 2 files changed, 10 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Brian Quinlan
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages