[L] Change in dart/sdk[main]: [analysis_server] Add command/resolve to support using Interactive Fo...

[Samuel Rawlins (Gerrit)]

Attention needed from Brian Wilkerson and Danny Tuppeny

Samuel Rawlins voted and added 1 comment

Votes added by Samuel Rawlins

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Samuel Rawlins . resolved

Looks good, great tests

Open in Gerrit

Related details

Attention is currently required from:

• Brian Wilkerson
• Danny Tuppeny

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I414a41fa2958ca9dcefe097f35ba28f3fa2fe367

Gerrit-Change-Number: 508121

Gerrit-PatchSet: 1

Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>

Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>

Gerrit-Attention: Danny Tuppeny <da...@tuppeny.com>

Gerrit-Comment-Date: Mon, 01 Jun 2026 18:55:24 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Brian Wilkerson (Gerrit)]

Attention needed from Danny Tuppeny

Brian Wilkerson voted and added 2 comments

Votes added by Brian Wilkerson

Code-Review

+1

2 comments

File pkg/analysis_server/lib/src/lsp/client_configuration.dart

Line 302, Patchset 1 (Latest): /// Whether experimental Go-specified Interactive Forms (that can be used by

Brian Wilkerson . unresolved

nit: I'd remove this adjective. The goal is to eventually make this a standard, so it would be better not to paint it as something specific to one language (server).

File pkg/analysis_server/test/src/services/refactoring/move_top_level_to_file_test.dart

Line 23, Patchset 1 (Latest):/// Tests running using the new (Go-specified) interactive forms refactors

Brian Wilkerson . unresolved

Ditto

Open in Gerrit

Related details

Attention is currently required from:

• Danny Tuppeny

Submit Requirements:

• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I414a41fa2958ca9dcefe097f35ba28f3fa2fe367

Gerrit-Change-Number: 508121

Gerrit-PatchSet: 1

Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>

Gerrit-Attention: Danny Tuppeny <da...@tuppeny.com>

Gerrit-Comment-Date: Mon, 01 Jun 2026 18:59:16 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Danny Tuppeny (Gerrit)]

Attention needed from Brian Wilkerson and Samuel Rawlins

Danny Tuppeny added 4 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Danny Tuppeny . resolved

Patch set 2 are the changes, and PS3 is just a rebase on the parent to clear the merge conflict status.

File pkg/analysis_server/lib/src/lsp/client_configuration.dart

Line 302, Patchset 1: /// Whether experimental Go-specified Interactive Forms (that can be used by

Brian Wilkerson . resolved

nit: I'd remove this adjective. The goal is to eventually make this a standard, so it would be better not to paint it as something specific to one language (server).

Danny Tuppeny

Done, here and in a few other places.

File pkg/analysis_server/test/src/services/refactoring/move_top_level_to_file_test.dart

Line 23, Patchset 1:/// Tests running using the new (Go-specified) interactive forms refactors

Brian Wilkerson . resolved

Ditto

Danny Tuppeny

Done

File pkg/analysis_server/tool/lsp_spec/README.md

Line 64, Patchset 2 (Parent):- Plugins: This functionality can be extended by third party analyzer plugins.

Danny Tuppeny . resolved

I also dropped this column in this CL since I had it open and was making minor changes.

Open in Gerrit

Related details

Attention is currently required from:

• Brian Wilkerson
• Samuel Rawlins

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I414a41fa2958ca9dcefe097f35ba28f3fa2fe367

Gerrit-Change-Number: 508121

Gerrit-PatchSet: 3

Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>

Gerrit-Attention: Brian Wilkerson <brianwi...@google.com>

Gerrit-Attention: Samuel Rawlins <sraw...@google.com>

Gerrit-Comment-Date: Mon, 01 Jun 2026 19:11:38 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Brian Wilkerson <brianwi...@google.com>

[Brian Wilkerson (Gerrit)]

Attention needed from Danny Tuppeny and Samuel Rawlins

Brian Wilkerson voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Danny Tuppeny
• Samuel Rawlins

Submit Requirements:

• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I414a41fa2958ca9dcefe097f35ba28f3fa2fe367

Gerrit-Change-Number: 508121

Gerrit-PatchSet: 3

Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>

Gerrit-Attention: Danny Tuppeny <da...@tuppeny.com>

Gerrit-Attention: Samuel Rawlins <sraw...@google.com>

Gerrit-Comment-Date: Mon, 01 Jun 2026 19:45:04 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Samuel Rawlins (Gerrit)]

Attention needed from Danny Tuppeny

Samuel Rawlins voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Danny Tuppeny

Submit Requirements:

• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I414a41fa2958ca9dcefe097f35ba28f3fa2fe367

Gerrit-Change-Number: 508121

Gerrit-PatchSet: 6

Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>

Gerrit-Attention: Danny Tuppeny <da...@tuppeny.com>

Gerrit-Comment-Date: Wed, 03 Jun 2026 15:15:36 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Samuel Rawlins (Gerrit)]

Attention needed from Danny Tuppeny

Samuel Rawlins voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

• Danny Tuppeny

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I414a41fa2958ca9dcefe097f35ba28f3fa2fe367

Gerrit-Change-Number: 508121

Gerrit-PatchSet: 6

Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>

Gerrit-Attention: Danny Tuppeny <da...@tuppeny.com>

Gerrit-Comment-Date: Wed, 03 Jun 2026 15:15:47 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Samuel Rawlins (Gerrit)]

Samuel Rawlins submitted the change

Change information

Commit message:

[analysis_server] Add command/resolve to support using Interactive Forms in refactors

This adds support for the `command/resolve` request to support the new Interactive Forms functionality, and updates the refactor processes to use it instead of the original protocol when the client indicates support.

Currently only the "Move to File" refactor uses this functionality (matching the previous version) and it requires the `dart.experimentalInteractiveForms` setting be enabled for it to be used (in case we find bugs while developing the front-end that require incompatible changes).

Fixes https://github.com/dart-lang/sdk/issues/63371

Change-Id: I414a41fa2958ca9dcefe097f35ba28f3fa2fe367

Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/508121

Reviewed-by: Samuel Rawlins <sraw...@google.com>

Reviewed-by: Brian Wilkerson <brianwi...@google.com>

Files:

• M pkg/analysis_server/lib/src/lsp/client_capabilities.dart
• M pkg/analysis_server/lib/src/lsp/client_configuration.dart
• M pkg/analysis_server/lib/src/lsp/constants.dart
• M pkg/analysis_server/lib/src/lsp/handlers/commands/refactor_command_executor.dart
• M pkg/analysis_server/lib/src/lsp/handlers/commands/refactor_command_handler_mixin.dart
• A pkg/analysis_server/lib/src/lsp/handlers/commands/refactor_command_resolver.dart
• A pkg/analysis_server/lib/src/lsp/handlers/custom/handler_command_resolve.dart
• M pkg/analysis_server/lib/src/lsp/handlers/handler_states.dart
• M pkg/analysis_server/lib/src/lsp/server_capabilities_computer.dart
• M pkg/analysis_server/lib/src/services/refactoring/framework/refactoring_processor.dart
• M pkg/analysis_server/lib/src/services/refactoring/framework/refactoring_producer.dart
• M pkg/analysis_server/lib/src/services/refactoring/move_top_level_to_file.dart
• A pkg/analysis_server/test/lsp/commands/resolve_test.dart
• M pkg/analysis_server/test/lsp/commands/test_all.dart
• M pkg/analysis_server/test/lsp/request_helpers_mixin.dart
• M pkg/analysis_server/test/lsp/server_abstract.dart
• M pkg/analysis_server/test/src/services/refactoring/move_top_level_to_file_test.dart
• M pkg/analysis_server/test/support/interactive_forms.dart
• M pkg/analysis_server/tool/lsp_spec/README.md
• M pkg/analysis_server/tool/lsp_spec/custom/interactive_forms.dart
• M pkg/analysis_server/tool/lsp_spec/generate_all.dart

Change size: XL

Delta: 21 files changed, 887 insertions(+), 144 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Brian Wilkerson, +1 by Samuel Rawlins

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: sdk

Gerrit-Branch: main

Gerrit-Change-Id: I414a41fa2958ca9dcefe097f35ba28f3fa2fe367

Gerrit-Change-Number: 508121

Gerrit-PatchSet: 7

Gerrit-Owner: Danny Tuppeny <da...@tuppeny.com>

Gerrit-Reviewer: Brian Wilkerson <brianwi...@google.com>

Gerrit-Reviewer: Samuel Rawlins <sraw...@google.com>

Gerrit-CC: dart-...@luci-project-accounts.iam.gserviceaccount.com <dart-...@luci-project-accounts.iam.gserviceaccount.com>